> This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445).
> 
> Context: the warning might be more important than it seems. Our JavaFX-based 
> desktop app has [an issue](https://github.com/defold/defold/issues/7845) — 
> when the user opens 2 instances of the app, one of the instances hangs after 
> a while. While debugging the issue, I found that it's somehow related to the 
> system menu bar — not refreshing it fixes the issue. Further investigations 
> revealed that the app hangs only if we show menus that use F1-F24 shortcuts. 
> This reminded me of the warnings we get about `NSEventModifierFlagFunction 
> specified to -setKeyEquivalentModifierMask` for such shortcuts. I 
> experimented with removing the modifier for these shortcuts, and it helped 
> with our issue!

vlaaad has updated the pull request incrementally with one additional commit 
since the last revision:

  Don't use NSFunctionKeyMask as modifier at all

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1252/files
  - new: https://git.openjdk.org/jfx/pull/1252/files/115663b0..468ff293

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1252&range=02
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1252&range=01-02

  Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jfx/pull/1252.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1252/head:pull/1252

PR: https://git.openjdk.org/jfx/pull/1252

Reply via email to