On Mon, 30 Oct 2023 18:08:52 GMT, Martin Fox <d...@openjdk.org> wrote:
>> vlaaad has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Revert java changes and set NSFunctionKeyMask for non-F1-F24 menu items
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassMenu.m line 247:
>
>> 245: int delta = jshortcut -
>> com_sun_glass_events_KeyEvent_VK_F13;
>> 246: shortcut = [NSString stringWithFormat:@"%C", (unsigned
>> short)(NSF13FunctionKey + delta)];
>> 247: } else {
>
> This else clause can be removed. JavaFX should never set the
> NSFunctionKeyMask so this PR can be just a one-line change (remove line 239).
>
> Sorry I wasn't clearer about this earlier. I was basically diagnosing a
> different bug in the same area of code. Not your concern.
A-ha, now I understand, thanks for the clarification!
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1252#discussion_r1377184067
