On Thu, 7 Aug 2025 16:07:05 GMT, Ziad El Midaoui wrote:
> Skipping failing `MenuDoubleShortcutTest#nonMacMenuBarComesBeforeScene()`
This pull request has now been integrated.
Changeset: 00820f4f
Author: Ziad El Midaoui
Committer: Kevin Rushforth
URL:
https://git.openjdk.org/
> Skipping failing `MenuDoubleShortcutTest#nonMacMenuBarComesBeforeScene()`
Ziad El Midaoui has updated the pull request incrementally with one additional
commit since the last revision:
Minor update to MenuDoubleShortcutTest
-
Changes:
- all: https://git.openjdk.org/jfx/p
On Thu, 7 Aug 2025 17:01:59 GMT, Kevin Rushforth wrote:
>> tests/system/src/test/java/test/robot/javafx/scene/MenuDoubleShortcutTest.java
>> line 108:
>>
>>> 106: // On platforms other than Mac the menu bar should process the
>>> event
>>> 107: // and the scene should not.
>>> 108:
Skipping failing `MenuDoubleShortcutTest#nonMacMenuBarComesBeforeScene()`
-
Commit messages:
- Disabled Test nonMacMenuBarComesBeforeScene()
Changes: https://git.openjdk.org/jfx/pull/1867/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1867&range=00
Issue: https://bugs.op
On Mon, 30 Jun 2025 21:49:22 GMT, Ziad El Midaoui
wrote:
> The issue is that when we use null value for root item in a TreeView and then
> expand the root or change it dynamically there are phantom disclosure nodes
> that appear incorrectly.
> The issue was caused by t
; `TreeCellSkin#updateDisclosureNode()` as it prevents the method from running
> unless the cell's value is not empty and it caused the creation of disclosure
> nodes visually without any logic behind.
Ziad El Midaoui has updated the pull request incrementally with one additional
commit since t
> Fix for phantom disclosure nodes appearing when root is null
Ziad El Midaoui has updated the pull request incrementally with one additional
commit since the last revision:
Update TreeCellSkin.java
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1838/files
- new: ht
On Mon, 28 Jul 2025 22:20:52 GMT, Ziad El Midaoui
wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeCellSkin.java
>> line 363:
>>
>>> 361: private void updateDisclosureNode() {
>>> 362: //JDK-8341281 :
On Mon, 28 Jul 2025 18:49:34 GMT, Andy Goryachev wrote:
>> Fix for phantom disclosure nodes appearing when root is null
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeCellSkin.java
> line 363:
>
>> 361: private void updateDisclosureNode() {
>> 362: //JDK-834
Fix for phantom disclosure nodes appearing when root is null
-
Commit messages:
- Fix for issue with null root in TreeView
- Merge branch 'openjdk:master' into 8341286.TreeViewArtifacts
- Partial fix
Changes: https://git.openjdk.org/jfx/pull/1838/files
Webrev: https://webrevs.op
On Fri, 27 Jun 2025 15:02:29 GMT, Andy Goryachev wrote:
>> ## Summary
>> This change adds new methods to the `TextFlow` which work correctly in the
>> presence of non-empty insets (borders/padding). For backward compatibility,
>> the old buggy methods are getting deprecated (not for removal). A
On Thu, 29 May 2025 18:42:10 GMT, Andy Goryachev wrote:
>> Fixing a bug that breaks proper saving of character attributes.
>>
>> This, unfortunately, makes a breaking change in the RichTextArea native
>> format [0].
>>
>> ## References
>>
>> [0]
>> https://github.com/andy-goryachev-oracle/Te
On Thu, 10 Apr 2025 12:41:44 GMT, Ziad El Midaoui
wrote:
> When the Root TreeItem is set to null, need to relayout to show the children
> items
This pull request has now been integrated.
Changeset: 11f31146
Author: Ziad El Midaoui
Committer: Andy Goryachev
URL:
On Tue, 3 Jun 2025 13:23:35 GMT, Ziad El Midaoui wrote:
>> When the Root TreeItem is set to null, need to relayout to show the children
>> items
>
> Ziad El Midaoui has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev e
On Tue, 3 Jun 2025 13:23:35 GMT, Ziad El Midaoui wrote:
>> When the Root TreeItem is set to null, need to relayout to show the children
>> items
>
> Ziad El Midaoui has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev e
> When the Root TreeItem is set to null, need to relayout to show the children
> items
Ziad El Midaoui has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request co
> When the Root TreeItem is set to null, need to relayout to show the children
> items
Ziad El Midaoui has updated the pull request incrementally with two additional
commits since the last revision:
- Merge remote-tracking branch 'origin/8341281.RootTreeItem' into
8341
On Mon, 2 Jun 2025 15:38:04 GMT, Ambarish Rapte wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor change : new line added
>
> modules/javafx.controls/src/main/
On Tue, 27 May 2025 16:09:52 GMT, Ziad El Midaoui
wrote:
>> When the Root TreeItem is set to null, need to relayout to show the children
>> items
>
> Ziad El Midaoui has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
> When the Root TreeItem is set to null, need to relayout to show the children
> items
Ziad El Midaoui has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request co
On Tue, 27 May 2025 15:43:23 GMT, Andy Goryachev wrote:
>> Ziad El Midaoui has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/8341281.RootTreeItem' into
>>
> When the Root TreeItem is set to null, need to relayout to show the children
> items
Ziad El Midaoui has updated the pull request incrementally with one additional
commit since the last revision:
Minor change : new line added
-
Changes:
- all: https://git.openjdk.o
> When the Root TreeItem is set to null, need to relayout to show the children
> items
Ziad El Midaoui has updated the pull request incrementally with two additional
commits since the last revision:
- Merge remote-tracking branch 'origin/8341281.RootTreeItem' into
8341
On Mon, 28 Apr 2025 18:27:37 GMT, Jose Pereda wrote:
>> Note: The JBS issue
>> [JDK-8207333](https://bugs.openjdk.org/browse/JDK-8207333) refers to Linux,
>> but it happens on macOS too.
>>
>> When a TableColumn has a ContextMenu, if the user right clicks on the
>> tableColumnHeader, the Con
On Wed, 21 May 2025 10:22:10 GMT, Ziad El Midaoui
wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the
On Wed, 19 Feb 2025 16:45:54 GMT, Ziad El Midaoui
wrote:
> The issue occurred because items preceding an item with children (items with
> a disclosure node) had different widths, which led to misalignment. This can
> be fixed by requesting a cell relayout whenever the disclosure nod
On Wed, 21 May 2025 05:09:28 GMT, Ambarish Rapte wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid re-layout items twice after disclosure node width value updated
>
> modules
> The issue occurred because items preceding an item with children (items with
> a disclosure node) had different widths, which led to misalignment. This can
> be fixed by requesting a cell relayout whenever the disclosure node's width
> changes.
Ziad El Midaoui has updated
On Tue, 20 May 2025 17:53:54 GMT, Andy Goryachev wrote:
>> Yes, the cells after disclosure node use the new `defaultDisclosureWidth`.
>> But their layout happens twice using the new `defaultDisclosureWidth`.
>>
>> **First time**: The loop `for (IndexedCell cell : flow.cells) {` initiates
>> th
> The issue occurred because items preceding an item with children (items with
> a disclosure node) had different widths, which led to misalignment. This can
> be fixed by requesting a cell relayout whenever the disclosure node's width
> changes.
Ziad El Midaoui has updated
On Thu, 15 May 2025 07:07:07 GMT, Ambarish Rapte wrote:
> Would it be possible to avoid re-layout of the cells that are after the Cell
> with a disclosureNode ?
This is actually what is happening, when we scroll down and find a TreeCell
that has a disclosure node this is when the condition `di
On Wed, 14 May 2025 17:27:59 GMT, Andy Goryachev wrote:
>>> does this create any visual artifacts?
>>
>> No artifacts, just that one can notice the re-layout and the TreeCell shift
>> to right.
>
> this is the expected behavior though, right?
>
> what we **don't** want is the flicker - when th
On Mon, 21 Apr 2025 15:42:20 GMT, Ziad El Midaoui
wrote:
> Fixed Caret disappear after unfocus then focus on the TextArea, the issue was
> happening because the caret position was set to -1 when we focus on the
> TextArea with empty text and caused the caret to disappear from at
On Wed, 14 May 2025 14:28:23 GMT, Ambarish Rapte wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeCellSkin.java
>> line 232:
>>
>>> 230: cell.layout();
>>> 231: }
>>> 232: }
>>
>> T
On Fri, 2 May 2025 15:44:03 GMT, Andy Goryachev wrote:
>> Moving MenuBarSkin initialization code to install() which always happens in
>> the FX Application Thread.
>>
>> Also, ensure that the reverse process also happens in the FX application
>> thread.
>
> Andy Goryachev has updated the pull
On Tue, 13 May 2025 15:23:01 GMT, Andy Goryachev wrote:
> Do you think it is possible to write a test for this case that would fail
> without the fix and pass with the fix?
I have tried to make a test for it but I cannot get the information about
whether the caret is visible or the caret posit
Fixed Caret disappear after unfocus then focus on the TextArea, the issue was
happening because the caret position was set to -1 when we focus on the
TextArea with empty text and caused the caret to disappear from at the skin
level when the position is set to -1
-
Commit messages:
On Fri, 9 May 2025 10:51:20 GMT, Ziad El Midaoui wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the discl
> The issue occurred because items preceding an item with children (items with
> a disclosure node) had different widths, which led to misalignment. This can
> be fixed by requesting a cell relayout whenever the disclosure node's width
> changes.
Ziad El Midaoui has updated
On Wed, 7 May 2025 23:09:51 GMT, Andy Goryachev wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update TreeCellSkin.java
>
> modules/javafx.controls/src/main/java/javafx/scene/
> The issue occurred because items preceding an item with children (items with
> a disclosure node) had different widths, which led to misalignment. This can
> be fixed by requesting a cell relayout whenever the disclosure node's width
> changes.
Ziad El Midaoui has updated
On Thu, 8 May 2025 15:03:25 GMT, Andy Goryachev wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixed minor issues and added test
>
> modules/javafx.controls/src/test/
> The issue occurred because items preceding an item with children (items with
> a disclosure node) had different widths, which led to misalignment. This can
> be fixed by requesting a cell relayout whenever the disclosure node's width
> changes.
Ziad El Midaoui has updated
> The issue occurred because items preceding an item with children (items with
> a disclosure node) had different widths, which led to misalignment. This can
> be fixed by requesting a cell relayout whenever the disclosure node's width
> changes.
Ziad El Midaoui has updated
On Wed, 19 Feb 2025 16:45:54 GMT, Ziad El Midaoui
wrote:
> The issue occurred because items preceding an item with children (items with
> a disclosure node) had different widths, which led to misalignment. This can
> be fixed by requesting a cell relayout whenever the disclosure nod
The issue occurred because items preceding an item with children (items with a
disclosure node) had different widths, which led to misalignment. This can be
fixed by requesting a cell relayout whenever the disclosure node's width
changes.
-
Commit messages:
- Fixed import error
-
On Thu, 1 May 2025 22:08:46 GMT, Ziad El Midaoui wrote:
> The issue was happening because `-fx-highlight-text-fill` was set to white ,
> so when the background color is bright (>60% brightness ) the text is not
> visible , the solution is to change the value to be dynamically s
On Mon, 5 May 2025 21:28:08 GMT, Ziad El Midaoui wrote:
>> The issue was happening because `-fx-highlight-text-fill` was set to white ,
>> so when the background color is bright (>60% brightness ) the text is not
>> visible , the solution is to change the value
nd this is done by
> `-fx-focused-text-base-color` .
Ziad El Midaoui has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains five additional
commits since
On Mon, 5 May 2025 14:32:27 GMT, Kevin Rushforth wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Created ModenaTest
>
> modules/javafx.controls/src/test/java/test/com/sun/ja
On Mon, 5 May 2025 14:46:01 GMT, Andy Goryachev wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Created ModenaTest
>
> modules/javafx.controls/src/test/java/test/com/sun/ja
nd this is done by
> `-fx-focused-text-base-color` .
Ziad El Midaoui has updated the pull request incrementally with two additional
commits since the last revision:
- Added standard copyright, javadoc and changed file name to
TextInputControlModenaTest
- Added standard copyright, javado
nd this is done by
> `-fx-focused-text-base-color` .
Ziad El Midaoui has updated the pull request incrementally with one additional
commit since the last revision:
Created ModenaTest
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1801/files
- new: https://git.openjdk
On Thu, 1 May 2025 22:08:46 GMT, Ziad El Midaoui wrote:
> The issue was happening because `-fx-highlight-text-fill` was set to white ,
> so when the background color is bright (>60% brightness ) the text is not
> visible , the solution is to change the value to be dynamically s
The issue was happening because `-fx-highlight-text-fill` was set to white , so
when the background color is bright (>60% brightness ) the text is not visible
, the solution is to change the value to be dynamically set depending on the
level of brightness of the background this is done by
`-fx-
When the Root TreeItem is set to null, need to relayout to show the children
items
-
Commit messages:
- Fixed issue with TreeTableView not showing the root's children when set to
null
Changes: https://git.openjdk.org/jfx/pull/1767/files
Webrev: https://webrevs.openjdk.org/?repo=
On Wed, 19 Feb 2025 16:50:02 GMT, Ziad El Midaoui
wrote:
> Added multi line prompt support for TextArea this will provide the ability to
> have multiple lines in textArea as expected,
> Also fixed tests to meet the new changes
This pull request has now been integrated.
Changeset:
On Wed, 26 Mar 2025 14:36:39 GMT, Andy Goryachev wrote:
>> Fixed several issues found in importing RTF text:
>>
>> - charset translation (brought back removed code)
>> - missing font size attribute
>> - missing strike-through attribute
>>
>> Also, HTML copy suffered from the following issues:
>
On Mon, 7 Apr 2025 22:48:44 GMT, Andy Goryachev wrote:
> @Ziad-Mid could you be the second reviewer?
I can't test on Linux , I will check same for macOS
-
PR Comment: https://git.openjdk.org/jfx/pull/1754#issuecomment-2786037078
On Fri, 28 Mar 2025 20:22:39 GMT, Kevin Rushforth wrote:
>> Option 1 is intentionally the status quo, and matches what Swing's
>> JComponent does, although @mstr2 is right that this isn't documented. An RFE
>> to treat `\r` or `\r\n` as a newline could be considered in the future. We
>> wouldn
> Added multi line prompt support for TextArea this will provide the ability to
> have multiple lines in textArea as expected,
> Also fixed tests to meet the new changes
Ziad El Midaoui has updated the pull request incrementally with one additional
commit since the last revision:
On Tue, 25 Mar 2025 22:24:51 GMT, Ziad El Midaoui
wrote:
> With the minimum JDK set to 22, the reflection calls is replaced with direct
> calls to enableNativeAccess
This pull request has now been integrated.
Changeset: ff777c7a
Author: Ziad El Midaoui
Committer: Kevin Rushfort
On Tue, 25 Mar 2025 22:41:59 GMT, Andy Goryachev wrote:
> looks good!
>
> please update the copyright year in the modified files. 1 reviewer is
> probably enough.
Done,
Can I integrate ?
-
PR Comment: https://git.openjdk.org/jfx/pull/1743#issuecomment-2761989807
> With the minimum JDK set to 22, the reflection calls is replaced with direct
> calls to enableNativeAccess
Ziad El Midaoui has updated the pull request incrementally with one additional
commit since the last revision:
updated copyright year
-
Changes:
- all:
On Wed, 26 Mar 2025 08:44:28 GMT, Michael Strauß wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed unused imports and code
>
> modules/javafx.controls/src/main/
With the minimum JDK set to 22, the reflection calls is replaced with direct
calls to enableNativeAccess
-
Commit messages:
- Replaced reflection with direct calls to enableNativeAccess.
Changes: https://git.openjdk.org/jfx/pull/1743/files
Webrev: https://webrevs.openjdk.org/?rep
On Fri, 14 Mar 2025 16:27:09 GMT, Andy Goryachev wrote:
>> With the new approach the `promptText` property is accepting any value so
>> it's expected to have prompt text with Linebreaks for `TextField` and
>> `PasswordField`, is this the test that I have to keep ?
>>
>> Else to have a test tha
> Added multi line prompt support for TextArea this will provide the ability to
> have multiple lines in textArea as expected,
> Also fixed tests to meet the new changes
Ziad El Midaoui has updated the pull request incrementally with one additional
commit since the last revision:
On Mon, 24 Mar 2025 16:59:43 GMT, Andy Goryachev wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor changes
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin
On Tue, 25 Mar 2025 14:37:14 GMT, Andy Goryachev wrote:
> please be more specific - maybe include a screenshot of the outlook message
> vs. rich text area?
The font and size are not applied
>> - missing font size attribute
>> - missing strike-through attribute
>>
>> The charset issue was caused by my removal of the charact
> Added multi line prompt support for TextArea this will provide the ability to
> have multiple lines in textArea as expected,
> Also fixed tests to meet the new changes
Ziad El Midaoui has updated the pull request incrementally with one additional
commit since the last revision:
On Fri, 21 Mar 2025 06:00:12 GMT, Michael Strauß wrote:
>> You should consider using a fluent binding here, which is a more modern
>> solution compared to the `Bindings` class. It is also simpler because you
>> don't need to check for `null`:
>>
>>
>> promptNode.textProperty().bind(getSkinnab
On Tue, 18 Mar 2025 15:41:00 GMT, Ziad El Midaoui
wrote:
>> Added multi line prompt support for TextArea this will provide the ability
>> to have multiple lines in textArea as expected,
>> Also fixed tests to meet the new changes
>
> I did test the mentioned line sepa
On Thu, 20 Mar 2025 20:03:54 GMT, Andy Goryachev wrote:
>> In tests, and especially for assertions, wildcard imports are usually
>> accepted. We use them all over the place. However, I would agree that
>> symbols other than assertions should usually be fully qualified.
>
> good point
I kept th
On Wed, 19 Feb 2025 16:50:02 GMT, Ziad El Midaoui
wrote:
> Added multi line prompt support for TextArea this will provide the ability to
> have multiple lines in textArea as expected,
> Also fixed tests to meet the new changes
I did test the mentioned line separators without filterin
On Mon, 17 Mar 2025 14:58:16 GMT, Andy Goryachev wrote:
> 3. cr \u000d ---
Yes , this approach do not handle all the line Seperators only "\n" , I will
change it to handle it all
-
PR Comment: https://git.openjdk.org/jfx/pull/1716#issuecomment-2730127082
On Tue, 4 Feb 2025 14:11:00 GMT, Ziad El Midaoui wrote:
> When binding the promptTextProperty of a TextInputControl (TextField or
> TextArea) to a text that contains linebreaks/newlines ("\n") the "bind" call
> causes a RuntimeException to be thrown, the solution
When binding the promptTextProperty of a TextInputControl (TextField or
TextArea) to a text that contains linebreaks/newlines ("\n") the "bind" call
causes a RuntimeException to be thrown, the solution to it is to unbind before
calling the set(txt) method to set the new value for the property.
A
On Fri, 24 Jan 2025 19:46:22 GMT, Ziad El Midaoui wrote:
> The USKeyboardTest tests were failing with
> IllegalFormatArgumentIndexException at index 0, in java.util.Formatter the
> first argument is referred to as 1$ not 0$ .
This pull request has now been integrated.
Changeset:
The USKeyboardTest tests were failing with IllegalFormatArgumentIndexException
at index 0, in java.util.Formatter the first argument is referred to as 1$ not
0$ .
-
Commit messages:
- Fixed USKeyboardTest Tests failing
Changes: https://git.openjdk.org/jfx/pull/1683/files
Webrev:
82 matches
Mail list logo
