On Thu, 7 Aug 2025 17:01:59 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> tests/system/src/test/java/test/robot/javafx/scene/MenuDoubleShortcutTest.java
>> line 108:
>>
>>> 106: // On platforms other than Mac the menu bar should process the
>>> event
>>> 107: // and the scene should not.
>>> 108: @Disabled("JDK-8364825")
>>
>> `@Disabled` must refer to the reason this test is skipped, in this case
>> JDK-8364405
>
> Also, this will skip the test on all platforms. That might be a reasonable
> thing to do, but if that's what you propose, then please change the title (in
> JBS and the PR) to drop the "on Linux" part.
The test is skipped on Mac by default with
`Assumptions.assumeFalse(PlatformUtil.isMac());` , and now it will be also on
Linux so skipping it on all platforms won't have critical impact I suppose
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1867#discussion_r2261010606
