On Mon, 24 Mar 2025 16:59:43 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor changes
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextFieldSkin.java
> line 33:
>
>> 31: import javafx.beans.binding.ObjectBinding;
>> 32: import javafx.beans.binding.StringBinding;
>> 33: import javafx.beans.binding.Bindings;
>
> unused import can be removed
removed thanks
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextFieldSkin.java
> line 737:
>
>> 735:
>> 736:
>> promptNode.textProperty().bind(getSkinnable().promptTextProperty());
>> 737:
>> promptNode.textProperty().bind(getSkinnable().promptTextProperty().map(s ->
>> s.replace("\n", "")));
>
> code in line 736 is not needed (we all missed that)
removed it also thanks
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1716#discussion_r2013038446
PR Review Comment: https://git.openjdk.org/jfx/pull/1716#discussion_r2013038870
