On Fri, 25 Jul 2025 21:14:48 GMT, Andy Goryachev wrote:
>> Oh, I thought you were saying that you didn't see that warning because of
>> the compiler configuration, not the project configuration.
>>
>> I manually added the source folders that are relevant to this PR and that
>> are not in the d
On Fri, 25 Jul 2025 21:02:26 GMT, Andy Goryachev wrote:
>> I commented on all the places where Eclipse gives a warning in this PR. Do
>> you want me to upload the compiler settings? I think we discussed at some
>> point the need to upload the formatter and other setting to the repo.
>
> We migh
On Fri, 25 Jul 2025 20:32:41 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/hw/MSLBackend.java
>> line 216:
>>
>>> 214: // For every user defined function, pass reference to
>>> 4 samplers and
>>> 215:
On Tue, 22 Jul 2025 17:00:25 GMT, Ambarish Rapte wrote:
>> ### Description
>> This is the implementation of new graphics rendering pipeline for JavaFX
>> using Metal APIs on MacOS.
>> We released two Early Access (EA) builds and have reached a stage where it
>> is ready to be integrated.
>> Def
On Tue, 22 Jul 2025 17:00:25 GMT, Ambarish Rapte wrote:
>> ### Description
>> This is the implementation of new graphics rendering pipeline for JavaFX
>> using Metal APIs on MacOS.
>> We released two Early Access (EA) builds and have reached a stage where it
>> is ready to be integrated.
>> Def
Yes, but I don't know much about the font area. Also, "Christmas shopping
lists" can be difficult to respond to. You'll need to wait for someone who
has input.
On Wed, Jul 23, 2025 at 8:41 PM Glavo wrote:
> Has anyone seen this email?
>
> Glavo
>
> On Mon, Jul 21, 2025 at 2:29 AM Glavo wrote:
>
On Fri, 10 Nov 2023 23:39:21 GMT, Nir Lisker wrote:
>> Moves the filter setting of the samplers from the device parameters
>> configuration to the use-site, allowing for dynamic changes in the sampler.
>> This PR does internal plumbing work only to bring it close to the E
On Sat, 19 Jul 2025 00:34:46 GMT, Xavier Pedraza wrote:
> Paying a visit here after writing [this SO
> answer](https://stackoverflow.com/a/79706844/10808904), any reason this PR
> died? Appreciate any and all responses.
The PR is not really dead, it's hibernating :) The reason is that there's
22H2 build 19045.
If I move HEAD to 1 commit before this one then there's no issue, but in
any commit that includes this one (master included) I get this issue.
On Thu, Jul 10, 2025 at 11:27 PM Michael Strauß
wrote:
> I can't reproduce this issue with the latest jfx/master running on Windows
> 1
Hi,
After 8313424: JavaFX controls in the title bar (Preview), on Win 10 I
found that the header bar is wrong:
[image: image.png]
The close button is disabled and the control buttons are on the wrong side.
The reproducer is trivial:
import javafx.application.Application;
import javafx.stage.Sta
On Wed, 2 Jul 2025 14:54:04 GMT, Andy Goryachev wrote:
> Is `mtl` a good name for the `prism.order` property? Should it be `metal`?
"mtl" is sometimes used a short for "material", which has overlapping context
here. I'd prefer the explicit "metal".
-
PR Comment: https://git.openjd
Sounds good.
Java 23 contains mostly preview features, but brings Markdown docs.
https://javaalmanac.io/jdk/23/
On Tue, Jun 17, 2025, 18:46 Kevin Rushforth
wrote:
> All,
>
> Even though we build JavaFX 25 binaries with JDK 23 (which is being
> updated to JDK 24 this week), as the boot JDK, the
On Fri, 6 Jun 2025 23:23:05 GMT, Michael Strauß wrote:
> JavaFX unnecessarily restricts interpolation in the following ways:
> 1. `Interpolatable` implementations often clamp intermediate values to the
> interpolation factor range [0,1].
> 2. `SplineInterpolator` doesn't accept Y coordinates out
On Wed, 11 Jun 2025 16:54:21 GMT, Kevin Rushforth wrote:
>> PR to replace the use of sun.misc.Unsafe memory access methods in the Marlin
>> rasterizer with FFM.
>>
>> I broke this up into the following commits. The bulk of the work is in the
>> first two:
>>
>> 1. Encapsulate all off-heap acc
On Wed, 11 Jun 2025 16:54:21 GMT, Kevin Rushforth wrote:
>> PR to replace the use of sun.misc.Unsafe memory access methods in the Marlin
>> rasterizer with FFM.
>>
>> I broke this up into the following commits. The bulk of the work is in the
>> first two:
>>
>> 1. Encapsulate all off-heap acc
On Wed, 11 Jun 2025 17:37:04 GMT, Kevin Rushforth wrote:
>> true
>
> Right. I could remove it if you like, although it isn't hurting anything
> leaving it there.
It doesn't really matter, but personally I try to use the built in
functionality.
-
PR Review Comment: https://git.ope
On Wed, 11 Jun 2025 14:16:19 GMT, Kevin Rushforth wrote:
> > > > If there is no performance penalty for accessing data from a memory
> > > > segment created using the global arena, then we could switch to that
> > > > for JavaFX as well.
> > >
> > >
> > > Using memory from the Global arena ca
On Wed, 11 Jun 2025 05:40:22 GMT, Per Minborg wrote:
> > If there is no performance penalty for accessing data from a memory segment
> > created using the global arena, then we could switch to that for JavaFX as
> > well.
>
> Using memory from the Global arena can actually be _faster_ as we do
On Fri, 6 Jun 2025 14:37:40 GMT, Kevin Rushforth wrote:
>> PR to replace the use of sun.misc.Unsafe memory access methods in the Marlin
>> rasterizer with FFM.
>>
>> I broke this up into the following commits. The bulk of the work is in the
>> first two:
>>
>> 1. Encapsulate all off-heap acce
On Wed, 12 Mar 2025 14:40:01 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> See also #837 for a previous attempt which instead of triggering nested
>> emissions immediately (like this PR
On Sat, 1 Feb 2025 14:51:18 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request incrementally with five
>> additional commits since the last revision:
>>
>> - Clean-up and add tests
>> - Pass in listener data directly for fireValueChanged calls
>> - Fix documentation in
On Wed, 12 Mar 2025 14:40:01 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> See also #837 for a previous attempt which instead of triggering nested
>> emissions immediately (like this PR
On Fri, 6 Jun 2025 23:23:05 GMT, Michael Strauß wrote:
> JavaFX unnecessarily restricts interpolation in the following ways:
> 1. `Interpolatable` implementations often clamp intermediate values to the
> interpolation factor range [0,1].
> 2. `SplineInterpolator` doesn't accept Y coordinates out
On Mon, 2 Jun 2025 20:22:28 GMT, Laurent Bourgès wrote:
>> PR to replace the use of sun.misc.Unsafe memory access methods in the Marlin
>> rasterizer with FFM.
>>
>> I broke this up into the following commits. The bulk of the work is in the
>> first two:
>>
>> 1. Encapsulate all off-heap acce
On Tue, 3 Jun 2025 16:44:17 GMT, Kevin Rushforth wrote:
> > > when the app devs create hundreds of windows and keep them hidden (I've
> > > seen those)
> >
> >
> > 😵
>
> Window and Scene are heavy-weight classes that are reasonably limited in
> quantity, so I'm not at all worried about this.
Sorry for the late reply, I was stuck abroad due to flight cancellations :)
This issue has been brought up before, including lengthy off-list
discussions. As a result, I created an umbrella issue that collects issues
regarding the Gradle file: https://bugs.openjdk.org/browse/JDK-8344728. The
linke
On Sun, 1 Jun 2025 21:42:17 GMT, Michael Strauß wrote:
> `EventHandler` property implementations in `Scene` and `Window` use anonymous
> classes derived from `ObjectPropertyBase`. We can remove about 650 lines of
> boilerplate code by using a common property class instead.
I've tried to do som
Vote: YES
On Fri, May 30, 2025, 09:46 José Pereda wrote:
> Vote: Yes
>
> Jose
>
> On Fri, May 30, 2025 at 9:11 AM Jayathirth Rao Daarapuram Venkatesh Murthy
> wrote:
>
>> Vote : Yes
>>
>>
>>
>> Thanks,
>>
>> Jay
>>
>>
>>
>> *From: *openjfx-dev on behalf of Kevin
>> Rushforth
>> *Date: *Thursd
The instructions could be outdated. They need another pass in any case.
On Tue, May 20, 2025, 09:03 Peter Hull wrote:
> On Mon, 19 May 2025 at 17:14, Kevin Rushforth wrote:
> >
> > This PR updates the compiler on Windows to Visual Studio 2022 17.13.2
> (from 17.6.5) to match JDK 25.
>
> Related
Just saw Kevin's JavaFX talk released on YT. Thanks Kevin!
https://www.youtube.com/watch?v=FxHbXY34iFQ
On Wed, 12 Mar 2025 14:40:01 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> See also #837 for a previous attempt which instead of triggering nested
>> emissions immediately (like this PR
John is replacing some of the ExpressionHelper uses (properties and
bindings) through https://github.com/openjdk/jfx/pull/1081. It's still
single threaded, but I think the new implementation there should be the
center point of this discussion.
On Wed, Apr 23, 2025 at 9:41 PM Kevin Rushforth
wrote
Sounds good. Have you tried a prototype implementation for a built-in
JavaFX control/Pane, just to see how well it works?
On Wed, Apr 16, 2025 at 5:50 PM Andy Goryachev
wrote:
> This might be a good idea from an API perspective, but please be careful -
> this optimization might break the behavio
On Sun, 13 Apr 2025 15:24:43 GMT, Thiago Milczarek Sayao
wrote:
> Improve StageStyle Documentation
>
> - Update `StageStyle.UTILITY`:
> Clarified that UTILITY stages may impose platform-specific restrictions on
> window states, such as preventing maximize, minimize (iconify), and
> fullscreen
On Mon, 14 Apr 2025 15:13:19 GMT, Thiago Milczarek Sayao
wrote:
>> Improve StageStyle Documentation
>>
>> - Update `StageStyle.UTILITY`:
>> Clarified that UTILITY stages may impose platform-specific restrictions on
>> window states, such as preventing maximize, minimize (iconify), and
>> full
I followed John's 'peek' addition. I have 2 monitors, the second one has a
125% magnification. Windows 10.
Rectangle2D [minX=0.0, minY=0.0, maxX=1920.0, maxY=1080.0, width=1920.0,
height=1080.0]
Rectangle2D [minX=1920.0, minY=0.0, maxX=3456.0, maxY=864.0, width=1536.0,
height=864.0]
The buttons
On Wed, 9 Apr 2025 07:06:29 GMT, Michael Strauß wrote:
> Fixes the bug that `BitSet.equals(null)` throws NPE.
>
> A single reviewer should be sufficient.
modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line 536:
> 534: return true;
> 535: }
> 536:
On Wed, 2 Apr 2025 08:36:22 GMT, John Hendrikx wrote:
>> 8351276: Prevent redundant computeValue calls when a chain of mappings
>> becomes observed
>
> John Hendrikx has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix review comments
Mark
On Thu, 13 Mar 2025 22:43:24 GMT, Kevin Rushforth wrote:
>> This PR adds the release notes for the JavaFX 24 release. This will first go
>> into master, and then be backported to the jfx24 branch so it will be
>> available in that branch when JavaFX 24 is published (and from there also
>> sync
On Wed, 12 Mar 2025 01:40:02 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/com/sun/javafx/binding/ListenerListBase.java
>> line 422:
>>
>>> 420:
>>> 421: private void assertInvalidationListenerIndex(int index) {
>>> 422: assert index < invalidationListenersCount :
On Fri, 21 Feb 2025 21:42:03 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/com/sun/javafx/binding/ListenerManagerBase.java
>> line 41:
>>
>>> 39: * @param the type of the instance providing listener data
>>> 40: */
>>> 41: public abstract class ListenerManagerBase>> Observab
On Tue, 11 Mar 2025 07:09:48 GMT, John Hendrikx wrote:
> I think the docs (in `OldValueCachingListenerManager`) are quite clear
> already though why you'd use one or the other.
Alright, no need to add a note about where it's used.
> The design flaw is the use of a protected `fireValueChangedEv
On Wed, 12 Mar 2025 01:29:26 GMT, John Hendrikx wrote:
>> Is a switch expression on `listenerData` not suitable here?
>
> This is a really hot code path, and the current version came out best in the
> benchmarks. I didn't try modify this one for that reason. I did try for the
> `removeListener
On Tue, 11 Mar 2025 06:45:58 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> See also #837 for a previous attempt which instead of triggering nested
>> emissions immediately (like this PR
On Sun, 9 Mar 2025 23:05:02 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix non-convergence logic one more time...
>
> modules/javafx.base/src/ma
On Tue, 11 Mar 2025 06:34:06 GMT, John Hendrikx wrote:
> I'm unsure what you are saying here. The common divisor example would not log
> a warning if I place the warning log in the same location as the SOE.
If you replace the thrown error/exception with logging then the code path will
continue
On Mon, 10 Mar 2025 08:48:53 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> See also #837 for a previous attempt which instead of triggering nested
>> emissions immediately (like this PR
On Mon, 10 Mar 2025 07:37:27 GMT, John Hendrikx wrote:
> > First part of the review.
> > There are several class (and their methods) that are `public`, but are only
> > used in their package and can just have package-access:
> > `OldValueCachingListenerList` `ListenerManagerBase` `ListenerListB
On Mon, 10 Mar 2025 08:42:07 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/com/sun/javafx/binding/OldValueCachingListenerManager.java
>> line 53:
>>
>>> 51: * within listener list. If possible use {@link ListenerManager}, as it
>>> has less
>>> 52: * storage requirements and
On Thu, 6 Mar 2025 16:21:33 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> See also #837 for a previous attempt which instead of triggering nested
>> emissions immediately (like this PR
On Sat, 8 Mar 2025 10:41:29 GMT, John Hendrikx wrote:
> Anything I should add as test-cases?
When I do the review of the tests I'll compare with my scenarios and see if
there's anything worth adding.
-
PR Comment: https://git.openjdk.org/jfx/pull/1081#issuecomment-2709090436
On Thu, 6 Mar 2025 16:21:33 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> # Behavior
>>
>> |Listener...|ExpressionHelper|ListenerManager|
>> |---|---|---|
>> |Invocation Order|In order
On Thu, 6 Mar 2025 15:22:58 GMT, John Hendrikx wrote:
> 8351276: Prevent redundant computeValue calls when a chain of mappings
> becomes observed
modules/javafx.base/src/main/java/com/sun/javafx/binding/LazyObjectBinding.java
line 62:
> 60: updateSubscriptionBeforeAdd();
> 61:
> 62:
On Wed, 5 Mar 2025 18:27:29 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> # Behavior
>>
>> |Listener...|ExpressionHelper|ListenerManager|
>> |---|---|---|
>> |Invocation Order|In order
On Mon, 2 Dec 2024 14:34:08 GMT, Alexander Zvegintsev
wrote:
>> Thanks @azvegint. If the `int`-based dimensions are coupled with
>> `com.sun.javafx.geom.Rectangle` (and from the code, that's the only place
>> they are used at), would you object to making `Dimension` an inner class of
>> `Rect
On Thu, 20 Feb 2025 14:08:26 GMT, John Hendrikx wrote:
> > Z 0->1
> > A 0->1; set 2
> > Z 1->2;
> > A 1->2; no change
> > B 0->2
> > C 0->2; sets 3
> > Z 2->3
> > A 2->3; if A sets 2 we will get a SOE because of recursive changes;
> > let's say A wants value>=2 and not ==2
> >
On Fri, 28 Feb 2025 15:56:19 GMT, Kevin Rushforth wrote:
>> This PR adds the release notes for the JavaFX 24 release. This will first go
>> into master, and then be backported to the jfx24 branch so it will be
>> available in that branch when JavaFX 24 is published (and from there also
>> sync
On Mon, 17 Feb 2025 15:37:56 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> # Behavior
>>
>> |Listener...|ExpressionHelper|ListenerManager|
>> |---|---|---|
>> |Invocation Order|In order
On Mon, 17 Feb 2025 15:37:56 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> # Behavior
>>
>> |Listener...|ExpressionHelper|ListenerManager|
>> |---|---|---|
>> |Invocation Order|In order
On Wed, 19 Feb 2025 01:09:59 GMT, John Hendrikx wrote:
> I'm going to assume that A and B are aware of each other, and are somehow
> working together, as this scenario makes little sense otherwise. The code
> that is using these two listeners is then likely coming from the same
> implementatio
On Mon, 17 Feb 2025 15:37:56 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> # Behavior
>>
>> |Listener...|ExpressionHelper|ListenerManager|
>> |---|---|---|
>> |Invocation Order|In order
On Tue, 18 Feb 2025 01:35:17 GMT, John Hendrikx wrote:
> I'm not sure what to think of this, and whether it needs a fix, and if so,
> what that fix should be...
Again I'm ill-equipped to answer this because I don't have experience using
these nested changes. I'd say that controls that do vetoi
On Mon, 17 Feb 2025 15:37:56 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> # Behavior
>>
>> |Listener...|ExpressionHelper|ListenerManager|
>> |---|---|---|
>> |Invocation Order|In order
On Mon, 17 Feb 2025 23:47:57 GMT, John Hendrikx wrote:
> With that I mean that when you add a listener to a property during its own
> notification, that listener will not be called until a change occurs after
> the notification completes (ie. the change must be triggered by some 3rd
> party, n
On Mon, 17 Feb 2025 04:53:41 GMT, John Hendrikx wrote:
> What part in the PR section? I found this:
>
> > Added listeners are only called when a new non-nested (top level)
> > notification starts
Maybe I misunderstood what that section says. When I look at the list of
differences it's written
On Sat, 1 Feb 2025 12:57:34 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> # Behavior
>>
>> |Listener...|ExpressionHelper|ListenerManager|
>> |---|---|---|
>> |Invocation Order|In order
On Sat, 1 Feb 2025 12:57:34 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> # Behavior
>>
>> |Listener...|ExpressionHelper|ListenerManager|
>> |---|---|---|
>> |Invocation Order|In order
On Mon, 10 Feb 2025 18:42:31 GMT, Nir Lisker wrote:
> 8344367: Fix mistakes in FX API docs
This pull request has now been integrated.
Changeset: 0424b8b1
Author: Nir Lisker
URL:
https://git.openjdk.org/jfx/commit/0424b8b1705252ded4ffc4a681a1ba67124ddb12
Stats: 78 lines in
8344367: Fix mistakes in FX API docs
-
Commit messages:
- Backport 8818ccf8ca883cda49c296ebf6d960c6929a9644
Changes: https://git.openjdk.org/jfx/pull/1704/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1704&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8344367
St
On Sat, 8 Feb 2025 19:19:56 GMT, Nir Lisker wrote:
>> A batch of typo and grammar fixes that were found by the spellchecker.
>>
>> Integration can wait until RDP 1/2.
>
> Nir Lisker has updated the pull request with a new target base due to a merge
> or a rebase. Th
On Sun, 17 Nov 2024 21:35:44 GMT, Nir Lisker wrote:
> A batch of typo and grammar fixes that were found by the spellchecker.
>
> Integration can wait until RDP 1/2.
This pull request has now been integrated.
Changeset: 8818ccf8
Author:Nir Lisker
URL:
https://git.openjd
> A batch of typo and grammar fixes that were found by the spellchecker.
>
> Integration can wait until RDP 1/2.
Nir Lisker has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains seven commits:
- Fixed javadoc for internal Nod
On Mon, 27 Jan 2025 17:28:14 GMT, Andy Goryachev wrote:
>> I'm not familiar with these methods, but I did wonder why we need extra
>> implementations in the initial comment.
>
> looks like dead code left over from the original implementation.
>
> I removed the class along with the two methods a
On Mon, 27 Jan 2025 16:36:28 GMT, Andy Goryachev wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/geo
> A batch of typo and grammar fixes that were found by the spellchecker.
>
> Integration can wait until RDP 1/2.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comment
-
Changes:
- a
On Fri, 6 Dec 2024 13:09:35 GMT, Michael Strauß wrote:
> cssref.html L2038: ` apples when the mnemonic affordance (typically an
> underscore)`
Didn't notice that this was fixed in a bigger patch.
-
PR Comment: https://git.openjdk.org/jfx/pull/1642#issuecomment-2613823400
On Sat, 25 Jan 2025 07:22:33 GMT, Nir Lisker wrote:
>> A batch of typo and grammar fixes that were found by the spellchecker.
>>
>> Integration can wait until RDP 1/2.
>
> Nir Lisker has updated the pull request incrementally with one additional
> com
> A batch of typo and grammar fixes that were found by the spellchecker.
>
> Integration can wait until RDP 1/2.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Revert "Addressed review comment"
On Mon, 2 Dec 2024 19:45:47 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/geom/Dimension2D.java
>> line 31:
>>
>>> 29: * A 2D dimension object that contains a width and a height.
>>> 30: */
>>> 31: public record Dimension2D(float width, float height) {}
>
On Mon, 2 Dec 2024 19:13:20 GMT, Andy Goryachev wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/gt
>
> I'm not sure we need the implementation class at all considering we are free
> to use the public one.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Address review comments
-
Changes:
- all: https
On Mon, 2 Dec 2024 14:34:08 GMT, Alexander Zvegintsev
wrote:
>> Thanks @azvegint. If the `int`-based dimensions are coupled with
>> `com.sun.javafx.geom.Rectangle` (and from the code, that's the only place
>> they are used at), would you object to making `Dimension` an inner class of
>> `Rect
On Sat, 14 Dec 2024 17:16:20 GMT, Michael Strauß wrote:
>> The `Paint` and `Material` classes can't be extended by user code, because
>> their implementations require special support in internal JavaFX code. The
>> classes should be sealed.
>
> Michael Strauß has updated the pull request increm
On Fri, 29 Nov 2024 17:00:42 GMT, Nir Lisker wrote:
> A small refactoring of the Dimension classes.
>
> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
> `com.sun.javafx.geom.Dimension2D`.
> * `com.sun.javafx.geom.Dimension2D`
On Fri, 29 Nov 2024 17:00:42 GMT, Nir Lisker wrote:
> A small refactoring of the Dimension classes.
>
> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
> `com.sun.javafx.geom.Dimension2D`.
> * `com.sun.javafx.geom.Dimension2D`
On Mon, 2 Dec 2024 02:19:46 GMT, Alexander Zvegintsev
wrote:
>> A small refactoring of the Dimension classes.
>>
>> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
>> `com.sun.javafx.geom.Dimension2D`.
>> * `com.sun.javafx.geom.Dimension2D` became a record.
>> * `ja
7;numedges' check. I wonder why they kept Vector
though.
On Sat, Nov 30, 2024 at 7:43 PM Laurent Bourgès
wrote:
> Probably derived from java.awt.Area:
>
> https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/java/awt/geom/Area.java
>
> Le sam. 30 nov. 20
ssume that it is writable and
> doesn't need copying. The ugly double cast of edges is relatively
> contained -- it is only casted when empty (to avoid creating another vector
> instance), and it was created by this class so its under control. Always
> returning `new
On Fri, 29 Nov 2024 17:00:42 GMT, Nir Lisker wrote:
> A small refactoring of the Dimension classes.
>
> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
> `com.sun.javafx.geom.Dimension2D`.
> * `com.sun.javafx.geom.Dimension2D`
I came across a potential mistake in the class com.sun.javafx.geom.AreaOp.
It uses raw Vector types and while trying to add generic parameters there
for type safety, I got some conflicts.
In the method AreaOp::calculate, the arguments should be Vector and
the return type should also be Vector, but
A small refactoring of the Dimension classes.
* `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
`com.sun.javafx.geom.Dimension2D`.
* `com.sun.javafx.geom.Dimension2D` became a record.
* `javafx.geometry.Dimension2D`: fields became `final`.
I'm not sure we need the imple
On Tue, 26 Nov 2024 16:03:38 GMT, Nir Lisker wrote:
> Centralizes version numbers in a single place. This is not the best way of
> doing it in Gradle, but it's an improvement that will simplify other changes.
> I used the `build.properties` file because other versions are a
On Fri, 22 Nov 2024 16:36:02 GMT, Kevin Rushforth wrote:
>> This PR add the necessary support for [JavaFX Incubator
>> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md).
>> It includes the following:
>>
>> 1. Changes to the build scripts `build.gradle` and
On Sat, 23 Nov 2024 09:22:36 GMT, Nir Lisker wrote:
> Replaces the manual versions handling with
> [Version](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/Runtime.Version.html).
>
> Changes:
> * Removed the methods `parseJavaVersion(String)`, `parseJd
hole build JDK manual
> invocation hack should be replaced with the Java Toolchain.
> * Simplified the `verifyJava` task, which could also be replaced with
> built-in Gradle tools.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
on numbers in the build file, but they are not attached
> directly to a dependency. Mostly libav ones. I decided not to touch them.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Added EOF line
-
Changes:
- all: h
Centralizes version numbers in a single place. This is not the best way of
doing it in Gradle, but it's an improvement that will simplify other changes. I
used the `build.properties` file because other versions are already written
there.
There are other version numbers in the build file, but th
On Sat, 23 Nov 2024 09:22:36 GMT, Nir Lisker wrote:
> Replaces the manual versions handling with
> [Version](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/Runtime.Version.html).
>
> Changes:
> * Removed the methods `parseJavaVersion(String)`, `parseJd
Replaces the manual versions handling with
[Version](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/Runtime.Version.html).
Changes:
* Removed the methods `parseJavaVersion(String)`, `parseJdkVersion(String)` and
`compareJdkVersion(String, String)`, and replaced them with
On Sat, 23 Nov 2024 09:22:36 GMT, Nir Lisker wrote:
> Replaces the manual versions handling with
> [Version](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/Runtime.Version.html).
>
> Changes:
> * Removed the methods `parseJavaVersion(String)`, `parseJd
1 - 100 of 845 matches
Mail list logo
