Re: RFR: 8359599: Calling refresh() for all virtualized controls recreates all cells instead of refreshing the cells

2025-08-01 Thread Johan Vos
On Sun, 15 Jun 2025 14:23:27 GMT, Marius Hanl wrote: > When calling `refresh()` on virtualized Controls (`ListView`, `TreeView`, > `TableView`, `TreeTableView`), all cells will be recreated completely, > instead of just refreshing them. > > This is because `recreateCells()` of the `VirtualFlow

Integrated: 8364203: Ignore native mac tests on headless

2025-07-29 Thread Johan Vos
On Mon, 28 Jul 2025 20:41:46 GMT, Johan Vos wrote: > Add PlatformUtil.isHeadless() method. > Use that in tests to conditionally skip tests. > > Fix JDK-8364203 This pull request has now been integrated. Changeset: 9ba9ec6a Author: Johan Vos URL: https://git.openjdk.or

Re: RFR: 8364203: Ignore native mac tests on headless [v2]

2025-07-29 Thread Johan Vos
> Add PlatformUtil.isHeadless() method. > Use that in tests to conditionally skip tests. > > Fix JDK-8364203 Johan Vos has updated the pull request incrementally with one additional commit since the last revision: Exclude setup/teardown in case of headless platform --

RFR: 8364203: ignore native mac tests on headless

2025-07-28 Thread Johan Vos
Add PlatformUtil.isHeadless() method. Use that in tests to conditionally skip tests. Fix JDK-8364203 - Commit messages: - Add PlatformUtil.isHeadless() method. Changes: https://git.openjdk.org/jfx/pull/1859/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1859&range=00 Is

Integrated: 8324941: POC for Headless platform for JavaFX

2025-07-28 Thread Johan Vos
On Thu, 19 Jun 2025 08:33:52 GMT, Johan Vos wrote: > After spending a year in the sandbox repository, the Headless Platform is now > ready to be reviewed in the main repository. > > ### the Headless Platform > The Headless Platform is a top-level com.sun.glass.ui platform that

Re: RFR: 8324941: POC for Headless platform for JavaFX [v11]

2025-07-28 Thread Johan Vos
On Fri, 25 Jul 2025 13:42:28 GMT, Kevin Rushforth wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add copyright sections > > I'll review the code soon. I ran a full set of tests, ex

Re: RFR: 8324941: POC for Headless platform for JavaFX [v14]

2025-07-28 Thread Johan Vos
Tests:cleanTest > :systemTests:test` > runs all the system tests, apart from the robot tests. There are 2 failing > tests, but there are valid reasons for those to fail. > > ### robot tests > Most of the robot tests are working on headless as well. add `-PUSE_ROBOT` to >

Re: RFR: 8324941: POC for Headless platform for JavaFX [v13]

2025-07-28 Thread Johan Vos
Tests:cleanTest > :systemTests:test` > runs all the system tests, apart from the robot tests. There are 2 failing > tests, but there are valid reasons for those to fail. > > ### robot tests > Most of the robot tests are working on headless as well. add `-PUSE_ROBOT` to >

Re: RFR: 8324941: POC for Headless platform for JavaFX [v12]

2025-07-28 Thread Johan Vos
Tests:cleanTest > :systemTests:test` > runs all the system tests, apart from the robot tests. There are 2 failing > tests, but there are valid reasons for those to fail. > > ### robot tests > Most of the robot tests are working on headless as well. add `-PUSE_ROBOT` to > te

Re: RFR: 8363813: Missing null check in GlassScreen

2025-07-23 Thread Johan Vos
On Tue, 22 Jul 2025 17:28:22 GMT, Ambarish Rapte wrote: > The JNI method NewObjectArray may return null, so a null check should be > added as a precaution in methods that creates an array of Screens. Marked as reviewed by jvos (Reviewer). - PR Review: https://git.openjdk.org/jfx/p

Re: RFR: 8363813: Missing null check in GlassScreen

2025-07-23 Thread Johan Vos
On Tue, 22 Jul 2025 17:31:01 GMT, Kevin Rushforth wrote: > Johan: can you take a look at the/ios/ changes? At first sight, those changes are not causing regression on ios. I'll do a deeper end-to-end test, but will already approve this since I don't want to stop this PR from being integrated.

Re: RFR: 8324941: POC for Headless platform for JavaFX [v11]

2025-07-22 Thread Johan Vos
Tests:cleanTest > :systemTests:test` > runs all the system tests, apart from the robot tests. There are 2 failing > tests, but there are valid reasons for those to fail. > > ### robot tests > Most of the robot tests are working on headless as well. add `-PUSE_ROBOT` to >

Re: [jfx25u] RFR: 8304008: Update README.md and CONTRIBUTING.md for jfx update repos

2025-07-21 Thread Johan Vos
On Mon, 21 Jul 2025 21:00:57 GMT, Kevin Rushforth wrote: > This is a copy of the jfx24u README and CONTRIBUTING docs, changing 24 to 25. The result of the PR looks very similar to the README.md and CONTRIBUTING.md in jfx21u, as expected. - Marked as reviewed by jvos (Reviewer). P

Re: RFR: 8324941: POC for Headless platform for JavaFX [v9]

2025-07-18 Thread Johan Vos
On Tue, 15 Jul 2025 01:11:14 GMT, Kevin Rushforth wrote: > Even if this remains a testing feature, how should it eventually be > configured? Using system properties? Some sort of config file? Something else? This was discussed in a number of comments as well, and the suggested approach is to l

Re: RFR: 8324941: POC for Headless platform for JavaFX [v9]

2025-07-18 Thread Johan Vos
On Wed, 16 Jul 2025 01:56:21 GMT, John Hendrikx wrote: > > > The first question is: Does this have any use case beyond testing? > > > > > > Good question, and the answer is "Yes, absolutely". One of the main drivers > > for this was a project where PDF prints need to be generated server-side,

Re: RFR: 8324941: POC for Headless platform for JavaFX [v10]

2025-07-18 Thread Johan Vos
Tests:cleanTest > :systemTests:test` > runs all the system tests, apart from the robot tests. There are 2 failing > tests, but there are valid reasons for those to fail. > > ### robot tests > Most of the robot tests are working on headless as well. add `-PUSE_ROBOT` to >

Re: RFR: 8324941: POC for Headless platform for JavaFX [v9]

2025-07-18 Thread Johan Vos
On Mon, 14 Jul 2025 22:17:56 GMT, Kevin Rushforth wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Specify A as a double. > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/hea

Re: RFR: 8324941: POC for Headless platform for JavaFX [v4]

2025-07-18 Thread Johan Vos
On Fri, 27 Jun 2025 20:38:56 GMT, Andy Goryachev wrote: > Question: While the screen size is limited in this version to 1000x1000, the > size of the snapshot exceeds that. Is that expected? Good question. Do you refer to the Node.snapshot()? The definition of "screen size" is a bit vague on hea

Re: RFR: 8324941: POC for Headless platform for JavaFX [v4]

2025-07-18 Thread Johan Vos
On Fri, 27 Jun 2025 19:12:32 GMT, Andy Goryachev wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process reviewer comments > > modules/javafx.graphics/src/main/java/com/sun/glass/

Re: RFR: 8324941: POC for Headless platform for JavaFX [v4]

2025-07-18 Thread Johan Vos
On Fri, 27 Jun 2025 19:08:48 GMT, Andy Goryachev wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process reviewer comments > > modules/javafx.graphics/src/main/java/com/sun/glass/

Re: RFR: 8324941: POC for Headless platform for JavaFX [v9]

2025-07-15 Thread Johan Vos
On Tue, 15 Jul 2025 01:11:14 GMT, Kevin Rushforth wrote: > The first question is: Does this have any use case beyond testing? Good question, and the answer is "Yes, absolutely". One of the main drivers for this was a project where PDF prints need to be generated server-side, starting from `Nod

Integrated: 8357714: AudioClip.play crash on macOS when loading resource from jar

2025-07-11 Thread Johan Vos
On Wed, 2 Jul 2025 21:47:05 GMT, Johan Vos wrote: > After JDK-8287822 (https://bugs.openjdk.org/browse/JDK-8287822), mpeg file > content is no longer played via GSTPlatform but via OSXPlatform. > We need to correctly handle data in case the source is a file inside a jar, > i

Re: RFR: 8361713: JavaFX API docs overview is missing an intro section [v3]

2025-07-11 Thread Johan Vos
On Fri, 11 Jul 2025 15:11:27 GMT, Kevin Rushforth wrote: >> This PR adds an introductory section to the JavaFX API docs similar to that >> of the JDK docs. >> >> Compare the [JavaFX 24 API >> docs](https://download.java.net/java/GA/javafx24/docs/api/index.html) with >> the [JDK 24 API >> doc

Re: RFR: 8357714: AudioClip.play crash on macOS when loading resource from jar

2025-07-10 Thread Johan Vos
On Thu, 3 Jul 2025 14:56:18 GMT, Andy Goryachev wrote: > Would it be possible to come up with a system test? It would be great to have a system test, but we currently have no framework for testing media in the system tests. It would be good to create this, but I expect it to be lots of work (d

Re: RFR: 8357714: AudioClip.play crash on macOS when loading resource from jar [v2]

2025-07-10 Thread Johan Vos
On Tue, 8 Jul 2025 20:55:05 GMT, Alexander Matveev wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process reviewer comments >> Add null checks >> Fix errors in position

Re: RFR: 8357714: AudioClip.play crash on macOS when loading resource from jar [v3]

2025-07-10 Thread Johan Vos
t; The 2 changes I made are: > 1. Use ConnectionHolder instead of Locator for CJavaInputStreamCallbacks in > case a jar resource is used. > 2. In case of random access datasource, use readBlock instead of > readNextBlock in AVMediaPlayer Johan Vos has updated the pull request incrementa

Re: RFR: 8357714: AudioClip.play crash on macOS when loading resource from jar

2025-07-08 Thread Johan Vos
On Tue, 8 Jul 2025 02:55:37 GMT, Alexander Matveev wrote: >> After JDK-8287822 (https://bugs.openjdk.org/browse/JDK-8287822), mpeg file >> content is no longer played via GSTPlatform but via OSXPlatform. >> We need to correctly handle data in case the source is a file inside a jar, >> in which

Re: RFR: 8357714: AudioClip.play crash on macOS when loading resource from jar [v2]

2025-07-08 Thread Johan Vos
t; The 2 changes I made are: > 1. Use ConnectionHolder instead of Locator for CJavaInputStreamCallbacks in > case a jar resource is used. > 2. In case of random access datasource, use readBlock instead of > readNextBlock in AVMediaPlayer Johan Vos has updated the pull request incrementa

Re: RFR: 8324941: POC for Headless platform for JavaFX [v7]

2025-07-07 Thread Johan Vos
On Mon, 7 Jul 2025 17:15:12 GMT, Jose Pereda wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process more reviewer comments > > modules/javafx.graphics/src/main/java/com/sun/glass/u

Re: RFR: 8324941: POC for Headless platform for JavaFX [v9]

2025-07-07 Thread Johan Vos
Tests:cleanTest > :systemTests:test` > runs all the system tests, apart from the robot tests. There are 2 failing > tests, but there are valid reasons for those to fail. > > ### robot tests > Most of the robot tests are working on headless as well. add `-PUSE_ROBOT` to >

Re: RFR: 8324941: POC for Headless platform for JavaFX [v4]

2025-07-07 Thread Johan Vos
On Fri, 27 Jun 2025 20:24:57 GMT, Andy Goryachev wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process reviewer comments > > modules/javafx.graphics/src/main/

Re: RFR: 8324941: POC for Headless platform for JavaFX [v7]

2025-07-07 Thread Johan Vos
On Mon, 7 Jul 2025 14:17:37 GMT, Jose Pereda wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process more reviewer comments > > modules/javafx.graphics/src/main/java/com/sun/glass/

Re: RFR: 8324941: POC for Headless platform for JavaFX [v8]

2025-07-07 Thread Johan Vos
Tests:cleanTest > :systemTests:test` > runs all the system tests, apart from the robot tests. There are 2 failing > tests, but there are valid reasons for those to fail. > > ### robot tests > Most of the robot tests are working on headless as well. add `-PUSE_ROBOT` to >

Re: RFR: 8324941: POC for Headless platform for JavaFX [v4]

2025-07-07 Thread Johan Vos
On Fri, 27 Jun 2025 20:19:24 GMT, Andy Goryachev wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process reviewer comments > > modules/javafx.graphics/src/main/java/com/sun/glass/u

Re: RFR: 8324941: POC for Headless platform for JavaFX [v7]

2025-07-07 Thread Johan Vos
Tests:cleanTest > :systemTests:test` > runs all the system tests, apart from the robot tests. There are 2 failing > tests, but there are valid reasons for those to fail. > > ### robot tests > Most of the robot tests are working on headless as well. add `-PUSE_ROBOT` to >

Re: RFR: 8324941: POC for Headless platform for JavaFX [v4]

2025-07-07 Thread Johan Vos
On Fri, 27 Jun 2025 20:00:48 GMT, Andy Goryachev wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process reviewer comments > > modules/javafx.graphics/src/main/java/com/sun/glass/u

Re: RFR: 8324941: POC for Headless platform for JavaFX [v2]

2025-07-07 Thread Johan Vos
On Thu, 19 Jun 2025 22:45:45 GMT, Michael Strauß wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix missing ; > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/Nested

Re: RFR: 8324941: POC for Headless platform for JavaFX [v4]

2025-07-07 Thread Johan Vos
On Fri, 27 Jun 2025 19:31:43 GMT, Andy Goryachev wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process reviewer comments > > modules/javafx.graphics/src/main/java/com/sun/glass/

Re: RFR: 8324941: POC for Headless platform for JavaFX [v4]

2025-07-07 Thread Johan Vos
On Fri, 27 Jun 2025 16:54:39 GMT, Andy Goryachev wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process reviewer comments > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/hea

Re: RFR: 8324941: POC for Headless platform for JavaFX [v6]

2025-07-07 Thread Johan Vos
Tests:cleanTest > :systemTests:test` > runs all the system tests, apart from the robot tests. There are 2 failing > tests, but there are valid reasons for those to fail. > > ### robot tests > Most of the robot tests are working on headless as well. add `-PUSE_ROBOT` to >

Re: RFR: 8324941: POC for Headless platform for JavaFX [v2]

2025-07-07 Thread Johan Vos
On Fri, 27 Jun 2025 19:59:16 GMT, Andy Goryachev wrote: >> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessView.java >> line 16: >> >>> 14: private Pixels pixels; >>> 15: >>> 16: private boolean imeEnabled; >> >> The following fields are not read, but only assi

Re: RFR: 8324941: POC for Headless platform for JavaFX [v2]

2025-07-07 Thread Johan Vos
On Thu, 19 Jun 2025 22:37:11 GMT, Michael Strauß wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix missing ; > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/Headl

Re: RFR: 8324941: POC for Headless platform for JavaFX [v2]

2025-07-07 Thread Johan Vos
On Mon, 7 Jul 2025 07:34:14 GMT, Johan Vos wrote: >> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessWindow.java >> line 36: >> >>> 34: private float alpha; >>> 35: private Pixels icon; >>> 36: private Cursor

Re: RFR: 8324941: POC for Headless platform for JavaFX [v2]

2025-07-07 Thread Johan Vos
On Thu, 19 Jun 2025 22:13:09 GMT, Michael Strauß wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix missing ; > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/

Re: RFR: 8324941: POC for Headless platform for JavaFX [v5]

2025-07-07 Thread Johan Vos
Tests:cleanTest > :systemTests:test` > runs all the system tests, apart from the robot tests. There are 2 failing > tests, but there are valid reasons for those to fail. > > ### robot tests > Most of the robot tests are working on headless as well. add `-PUSE_ROBOT` to >

Re: RFR: 8324941: POC for Headless platform for JavaFX [v2]

2025-07-07 Thread Johan Vos
On Thu, 19 Jun 2025 22:33:10 GMT, Michael Strauß wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix missing ; > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/

Re: RFR: 8324941: POC for Headless platform for JavaFX [v2]

2025-07-07 Thread Johan Vos
On Fri, 27 Jun 2025 20:15:52 GMT, Andy Goryachev wrote: >> There was a failing test, so it turns out there is an implicit contract that >> even if a resize is requested without different w/h parameters, at least the >> even should still be generated. > > should we either add a comment or clean

Re: RFR: 8357714: AudioClip.play crash on macOS when loading resource from jar

2025-07-04 Thread Johan Vos
On Thu, 3 Jul 2025 21:23:47 GMT, Alexander Matveev wrote: >> After JDK-8287822 (https://bugs.openjdk.org/browse/JDK-8287822), mpeg file >> content is no longer played via GSTPlatform but via OSXPlatform. >> We need to correctly handle data in case the source is a file inside a jar, >> in which

Re: RFR: 8357714: AudioClip.play crash on macOS when loading resource from jar

2025-07-03 Thread Johan Vos
On Wed, 2 Jul 2025 21:47:05 GMT, Johan Vos wrote: > After JDK-8287822 (https://bugs.openjdk.org/browse/JDK-8287822), mpeg file > content is no longer played via GSTPlatform but via OSXPlatform. > We need to correctly handle data in case the source is a file inside a jar, > i

RFR: 8357714: AudioClip.play crash on macOS when loading resource from jar

2025-07-02 Thread Johan Vos
After JDK-8287822 (https://bugs.openjdk.org/browse/JDK-8287822), mpeg file content is no longer played via GSTPlatform but via OSXPlatform. We need to correctly handle data in case the source is a file inside a jar, in which case CJavaInputStreamCallbacks is used. The 2 changes I made are: 1. U

Re: RFR: 8324941: POC for Headless platform for JavaFX [v4]

2025-06-26 Thread Johan Vos
On Tue, 24 Jun 2025 16:38:48 GMT, Marius Hanl wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process reviewer comments > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/hea

Re: RFR: 8324941: POC for Headless platform for JavaFX [v2]

2025-06-23 Thread Johan Vos
On Thu, 19 Jun 2025 22:18:48 GMT, Michael Strauß wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix missing ; > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/Headle

Re: RFR: 8324941: POC for Headless platform for JavaFX [v2]

2025-06-23 Thread Johan Vos
On Thu, 19 Jun 2025 22:36:14 GMT, Michael Strauß wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix missing ; > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/Headl

Re: RFR: 8324941: POC for Headless platform for JavaFX [v2]

2025-06-23 Thread Johan Vos
On Thu, 19 Jun 2025 22:13:37 GMT, Michael Strauß wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix missing ; > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/

Re: RFR: 8324941: POC for Headless platform for JavaFX [v3]

2025-06-23 Thread Johan Vos
Tests:cleanTest > :systemTests:test` > runs all the system tests, apart from the robot tests. There are 2 failing > tests, but there are valid reasons for those to fail. > > ### robot tests > Most of the robot tests are working on headless as well. add `-PUSE_ROBOT` to > t

Re: RFR: 8324941: POC for Headless platform for JavaFX [v4]

2025-06-23 Thread Johan Vos
Tests:cleanTest > :systemTests:test` > runs all the system tests, apart from the robot tests. There are 2 failing > tests, but there are valid reasons for those to fail. > > ### robot tests > Most of the robot tests are working on headless as well. add `-PUSE_ROBOT` to >

Re: RFR: 8324941: POC for Headless platform for JavaFX [v2]

2025-06-23 Thread Johan Vos
On Thu, 19 Jun 2025 22:49:58 GMT, Michael Strauß wrote: > My testing shows that the headless platform works as expected. > > Some general comments: > > 1. All files need a copyright header. > 2. Very long lines can benefit from a few line breaks. Thanks for the comments, those make the PR much

Re: RFR: 8324941: POC for Headless platform for JavaFX [v2]

2025-06-19 Thread Johan Vos
Tests:cleanTest > :systemTests:test` > runs all the system tests, apart from the robot tests. There are 2 failing > tests, but there are valid reasons for those to fail. > > ### robot tests > Most of the robot tests are working on headless as well. add `-PUSE_ROBOT` to >

RFR: 8324941: POC for Headless platform for JavaFX

2025-06-19 Thread Johan Vos
After spending a year in the sandbox repository, the Headless Platform is now ready to be reviewed in the main repository. ### the Headless Platform The Headless Platform is a top-level com.sun.glass.ui platform that replaces the second-level Monocle-Headless subplatform, that is part of the top

[jfx21u] Integrated: 8351038: ConcurrentModificationException in EventType constructor

2025-06-17 Thread Johan Vos
On Tue, 17 Jun 2025 08:11:51 GMT, Johan Vos wrote: > Hi all, > > This pull request contains an almost-clean backport of commit 0e509616 from > the openjdk/jfx repository. Only the (c) date had to be manually modified. > > The commit being backported was authored by Andy G

[jfx21u] RFR: 8351038: ConcurrentModificationException in EventType constructor

2025-06-17 Thread Johan Vos
Hi all, This pull request contains an almost-clean backport of commit 0e509616 from the openjdk/jfx repository. Only the (c) date had to be manually modified. The commit being backported was authored by Andy Goryachev on 19 Mar 2025 and was reviewed by Ambarish Rapte and Michael Strauß. Thanks

Re: RFR: 8359396: [Linux] Require Gtk3 >= 3.20 for glass-gtk [v2]

2025-06-17 Thread Johan Vos
On Sun, 15 Jun 2025 21:12:45 GMT, Thiago Milczarek Sayao wrote: >> Upgrade the minimum required GTK version for JavaFX to GTK 3.20 to enable >> modern features and better Linux desktop integration. >> >> JavaFX currently depends on GTK 3.8, >> [released](https://mail.gnome.org/archives/gtk-de

Re: RFR: 8359599: Calling refresh() for all virtualized controls recreates all cells instead of refreshing the cells

2025-06-17 Thread Johan Vos
On Sun, 15 Jun 2025 14:23:27 GMT, Marius Hanl wrote: > When calling `refresh()` on virtualized Controls (`ListView`, `TreeView`, > `TableView`, `TreeTableView`), all cells will be recreated completely, > instead of just refreshing them. > > This is because `recreateCells()` of the `VirtualFlow

Headless Platform, status update

2025-06-04 Thread Johan Vos
Hi, After the previous discussion on this list about the Headless Platform requiring its own module or not [1], I continued working on it without creating a new module for it. I updated the code in my fork of the jfx-sandbox repository [2] and builds of it are available in the Gluon JavaFX downloa

[jfx21u] Integrated: 8354940: Fail to sign in to Microsoft sites with WebView

2025-06-03 Thread Johan Vos
On Mon, 2 Jun 2025 09:58:32 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit ac12979b from the openjdk/jfx > repository. > > The commit being backported was authored by Gopal Pattnaik on 22 May 2025 and > was reviewed by Kevin Rush

[jfx17u] Integrated: 8354940: Fail to sign in to Microsoft sites with WebView

2025-06-03 Thread Johan Vos
On Mon, 2 Jun 2025 09:58:58 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit ac12979b from the openjdk/jfx > repository. > > The commit being backported was authored by Gopal Pattnaik on 22 May 2025 and > was reviewed by Kevin Rush

[jfx21u] RFR: 8354940: Fail to sign in to Microsoft sites with WebView

2025-06-02 Thread Johan Vos
Hi all, This pull request contains a backport of commit ac12979b from the openjdk/jfx repository. The commit being backported was authored by Gopal Pattnaik on 22 May 2025 and was reviewed by Kevin Rushforth and Jay Bhaskar. Thanks! - Commit messages: - Backport ac12979bc3100cf4

[jfx17u] RFR: 8354940: Fail to sign in to Microsoft sites with WebView

2025-06-02 Thread Johan Vos
Hi all, This pull request contains a backport of commit ac12979b from the openjdk/jfx repository. The commit being backported was authored by Gopal Pattnaik on 22 May 2025 and was reviewed by Kevin Rushforth and Jay Bhaskar. Thanks! - Commit messages: - Backport ac12979bc3100cf4

Re: CFV: New OpenJFX Committer: Alexander Zuev

2025-05-28 Thread Johan Vos
Vote: YES - Johan Op wo 28 mei 2025 om 21:51 schreef Kevin Rushforth < kevin.rushfo...@oracle.com>: > I hereby nominate Alexander Zuev [1] to OpenJFX Committer. > > Alexander is a member of the JavaFX team at Oracle who has contributed > 10 commits [2] to OpenJFX. > > Votes are due by June 11, 2

[jfx17u] Integrated: 8354876: Update SQLite to 3.49.1

2025-05-22 Thread Johan Vos
Hi all, This pull request contains a backport of commit 46b36fe4 from the openjdk/jfx repository. The commit being backported was authored by Jay Bhaskar on 23 Apr 2025 and was reviewed by Kevin Rushforth and Joeri Sykora. Thanks! - Commit messages: - Backport 46b36fe432aab81468

[jfx17u] Integrated: 8354876: Update SQLite to 3.49.1

2025-05-22 Thread Johan Vos
On Thu, 22 May 2025 10:12:04 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit 46b36fe4 from the openjdk/jfx > repository. > > The commit being backported was authored by Jay Bhaskar on 23 Apr 2025 and > was reviewed by Kevin Rushf

[jfx21u] Integrated: 8354876: Update SQLite to 3.49.1

2025-05-22 Thread Johan Vos
Hi all, This pull request contains a backport of commit 46b36fe4 from the openjdk/jfx repository. The commit being backported was authored by Jay Bhaskar on 23 Apr 2025 and was reviewed by Kevin Rushforth and Joeri Sykora. Thanks! - Commit messages: - Backport 46b36fe432aab81468

[jfx21u] Integrated: 8354876: Update SQLite to 3.49.1

2025-05-22 Thread Johan Vos
On Thu, 22 May 2025 10:13:22 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit 46b36fe4 from the openjdk/jfx > repository. > > The commit being backported was authored by Jay Bhaskar on 23 Apr 2025 and > was reviewed by Kevin Rushf

[jfx17u] Integrated: 8352162: Update libxml2 to 2.13.8

2025-05-22 Thread Johan Vos
On Thu, 22 May 2025 09:46:37 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit 4df23263 from the openjdk/jfx > repository. > > The commit being backported was authored by Jay Bhaskar on 23 Apr 2025 and > was reviewed by Kevin Rushf

[jfx17u] RFR: 8352162: Update libxml2 to 2.13.8

2025-05-22 Thread Johan Vos
Hi all, This pull request contains a backport of commit 4df23263 from the openjdk/jfx repository. The commit being backported was authored by Jay Bhaskar on 23 Apr 2025 and was reviewed by Kevin Rushforth and Joeri Sykora. Thanks! - Commit messages: - Backport 4df2326391b3528c48

[jfx21u] Integrated: 8352162: Update libxml2 to 2.13.8

2025-05-22 Thread Johan Vos
On Thu, 22 May 2025 09:38:48 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit 4df23263 from the openjdk/jfx > repository. > > The commit being backported was authored by Jay Bhaskar on 23 Apr 2025 and > was reviewed by Kevin Rushf

[jfx21u] RFR: 8352162: Update libxml2 to 2.13.8

2025-05-22 Thread Johan Vos
Hi all, This pull request contains a backport of commit 4df23263 from the openjdk/jfx repository. The commit being backported was authored by Jay Bhaskar on 23 Apr 2025 and was reviewed by Kevin Rushforth and Joeri Sykora. Thanks! - Commit messages: - Backport 4df2326391b3528c48

Re: Headless Platform module?

2025-05-19 Thread Johan Vos
of Monocle to a different module, this sounds > like a lot of work and also would raise some issues that would have to > be solved. Would we need to define an SPI? Formalize the Monocle back > end interfaces? Hmm. > > Anyway, this is just food for thought at this point. > >

Headless Platform module?

2025-05-16 Thread Johan Vos
Hi, The Headless Glass Platform has been in the jfx sandbox repository [1] for some time now, and we have provided a number of builds allowing users to test the headless platform. The reactions were very positive. It's mainly being used in 2 areas: testing is obviously a major usecase, especially

[jfx21u] Integrated: 8355642: Change JavaFX release version to 21.0.8 in jfx21u

2025-04-26 Thread Johan Vos
On Sat, 26 Apr 2025 12:45:22 GMT, Johan Vos wrote: > Bump version to 21.0.8 This pull request has now been integrated. Changeset: 838a544f Author: Johan Vos URL: https://git.openjdk.org/jfx21u/commit/838a544fe8609d42e5dacea8f1aab118f8fac13c Stats: 2 lines in 2 files changed

[jfx17u] Integrated: 8355641: Change JavaFX release version to 17.0.16 in jfx17u

2025-04-26 Thread Johan Vos
On Sat, 26 Apr 2025 07:20:23 GMT, Johan Vos wrote: > Start work for 17.0.16 This pull request has now been integrated. Changeset: 3ee40373 Author: Johan Vos URL: https://git.openjdk.org/jfx17u/commit/3ee40373f1099b6ffb6eba16fe34bbd16ebb90ba Stats: 2 lines in 2 files changed

[jfx21u] RFR: 8355642: Change JavaFX release version to 21.0.8 in jfx21u

2025-04-26 Thread Johan Vos
Bump version to 21.0.8 - Commit messages: - Bump version to 21.0.8 Changes: https://git.openjdk.org/jfx21u/pull/96/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=96&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8355642 Stats: 2 lines in 2 files changed: 0 ins;

[jfx17u] RFR: 8355641: Change JavaFX release version to 17.0.16 in jfx17u

2025-04-26 Thread Johan Vos
Start work for 17.0.16 - Commit messages: - Bump version to 17.0.16 Changes: https://git.openjdk.org/jfx17u/pull/233/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=233&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8355641 Stats: 2 lines in 2 files changed: 0 i

Re: RFR: 8353632: [Linux] Undefined reference to PlatformSupport::OBSERVED_SETTINGS with C++14 [v2]

2025-04-24 Thread Johan Vos
On Mon, 14 Apr 2025 21:04:30 GMT, Kevin Rushforth wrote: >> Fixes a link error that occurs when using C++14 to compile and link JavaFX >> on Linux. >> >> >> in function `PlatformSupport::PlatformSupport(JNIEnv_*, _jobject*)': >> PlatformSupport.cpp:90: undefined reference to >> `PlatformSuppo

Re: Proposal: A new common Image API

2025-04-17 Thread Johan Vos
I started replying to this a couple of times, but I never finished it, because 1) there are many different angles to look at the question 2) I believe it is indeed pretty hard. However, I absolutely understand the original question, and I support the idea. The fragmentation of "image" handling is

Re: RFR: 8353163: [XWayland] Disable SwingNodePlatformExitCrashTest on wayland

2025-03-29 Thread Johan Vos
On Fri, 28 Mar 2025 08:56:36 GMT, Jayathirth D V wrote: > SwingNodePlatformExitCrashTest hangs while running on wayland, we need to > skip this test on wayland until https://bugs.openjdk.org/browse/JDK-8350009 > is fixed. I'm a bit worried with disabling the test, as there is no guarantee the

Re: Building OpenJFX with the JDK build system

2025-03-28 Thread Johan Vos
; effort would be valuable on its own. > Until we actually transitioned the build, we'd probably have to add to > the gradle system > a way to disable specific warnings, like the JDK does, because it isn't > practical to eliminate all warnings, > since they some times come fr

Re: Building OpenJFX with the JDK build system

2025-03-28 Thread Johan Vos
-March/053076.html [2] https://johanvos.wordpress.com/2025/03/27/building-a-jdk-including-openjfx-part-2/ On Wed, Mar 12, 2025 at 8:11 PM John Neffenger wrote: > On 2/27/25 7:15 AM, Johan Vos wrote: > > The POC I have for this (linux-only at the moment) is at > > https://github.com/j

Re: [jfx24u] RFR: 8351602: Change JavaFX release version to 24.0.2 in jfx24u

2025-03-11 Thread Johan Vos
On Mon, 10 Mar 2025 22:35:36 GMT, Kevin Rushforth wrote: > Bump version number to 24.0.2. > > I plan to integrate this some time tomorrow morning (Pacific). Marked as reviewed by jvos (Reviewer). - PR Review: https://git.openjdk.org/jfx24u/pull/12#pullrequestreview-2673168449

[jfx17u] Integrated: 8315873: [GHA] Update checkout and cache action to use v4

2025-03-05 Thread Johan Vos
On Wed, 5 Mar 2025 07:41:50 GMT, Johan Vos wrote: > mainly clean backport of > https://github.com/openjdk/jfx/commit/6ec588c5635964769b354bce37e68d7a6c00985a > (JDK-8315873) > > Reason for being non-clean: > * we already applied 8350437 > * we don't have aar

[jfx17u] Integrated: 8349924: Additional WebKit 620.1 fixes from WebKitGTK 2.46.6

2025-03-05 Thread Johan Vos
On Wed, 5 Mar 2025 09:19:01 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit f38ab33b from the openjdk/jfx > repository. > > The commit being backported was authored by Jay Bhaskar on 25 Feb 2025 and > was reviewed by Kevin Rushf

[jfx17u] Integrated: 8349924: Additional WebKit 620.1 fixes from WebKitGTK 2.46.6

2025-03-05 Thread Johan Vos
Hi all, This pull request contains a backport of commit f38ab33b from the openjdk/jfx repository. The commit being backported was authored by Jay Bhaskar on 25 Feb 2025 and was reviewed by Kevin Rushforth and Joeri Sykora. Thanks! - Commit messages: - Backport f38ab33b296de7b0bf

[jfx17u] Integrated: 8349891: Not implemented function should have printf

2025-03-05 Thread Johan Vos
On Wed, 5 Mar 2025 08:42:31 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit 065548d0 from the openjdk/jfx > repository. > > The commit being backported was authored by Jay Bhaskar on 18 Feb 2025 and > was reviewed by Kevin Rushfort

[jfx17u] Integrated: 8349891: Not implemented function should have printf

2025-03-05 Thread Johan Vos
Hi all, This pull request contains a backport of commit 065548d0 from the openjdk/jfx repository. The commit being backported was authored by Jay Bhaskar on 18 Feb 2025 and was reviewed by Kevin Rushforth. Thanks! - Commit messages: - Backport 065548d09dd4909137343e7e9eb2d25a336

[jfx17u] Integrated: 8340322: Update WebKit to 620.1

2025-03-05 Thread Johan Vos
On Wed, 5 Mar 2025 08:17:16 GMT, Johan Vos wrote: > Almost clean backport of JDK-8340322 > Manually changed: > > * build.gradle minor change > * > modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLElementStack.cpp > because JDK-8344899 is not backported &

[jfx17u] RFR: 8340322: Update WebKit to 620.1

2025-03-05 Thread Johan Vos
Almost clean backport of JDK-8340322 Manually changed: * build.gradle minor change * modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLElementStack.cpp because JDK-8344899 is not backported * modules/javafx.web/src/test/java/test/javafx/scene/web/CanvasTest.java because JDK-8339

[jfx17u] RFR: 8315873: [GHA] Update checkout and cache action to use v4

2025-03-04 Thread Johan Vos
mainly clean backport of https://github.com/openjdk/jfx/commit/6ec588c5635964769b354bce37e68d7a6c00985a (JDK-8315873) Reason for being non-clean: * we already applied 8350437 * we don't have aarch64-mac * we don't have TEST_ONLY in build.gradle - Commit messages: - Backport 6ec588

[jfx17u] Integrated: 8323880: Caret rendered at wrong position in case of a click event on RTL text

2025-03-04 Thread Johan Vos
On Wed, 5 Mar 2025 07:00:00 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit > [1fb56e33](https://github.com/openjdk/jfx/commit/1fb56e333bc65860cc1abeebd1cbb01cd8b8e5f3) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. >

[jfx17u] Integrated: 8350437: [GHA] Update gradle wrapper-validation action to v3

2025-03-04 Thread Johan Vos
On Tue, 4 Mar 2025 21:02:19 GMT, Johan Vos wrote: > Use latest action and gradle wrapper This pull request has now been integrated. Changeset: 1cacfdbb Author: Johan Vos URL: https://git.openjdk.org/jfx17u/commit/1cacfdbb0fe19d4874d43f28223647e6b9287f99 Stats: 2 lines in 1 f

[jfx17u] RFR: 8323880: Caret rendered at wrong position in case of a click event on RTL text

2025-03-04 Thread Johan Vos
Hi all, This pull request contains a backport of commit [1fb56e33](https://github.com/openjdk/jfx/commit/1fb56e333bc65860cc1abeebd1cbb01cd8b8e5f3) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The commit being backported was authored by Jay Bhaskar on 16 Feb 2024 and was revi

  1   2   3   4   5   6   7   8   9   >