On Thu, 19 Jun 2025 22:33:10 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix missing ; > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessWindow.java > line 36: > >> 34: private float alpha; >> 35: private Pixels icon; >> 36: private Cursor cursor; > > The following fields are never used, other than assigning a value: > * `ptr` > * `resizable` > * `visible` > * `isFocusable` > * `enabled` > * `closed` > * `bg_r`, `bg_g`, `bg_b` > * `alpha` > * `icon` > * `cursor` I had those since I think they might be useful "later", when we add more configuration options, or in case there are tests that rely on them. But I believe it is better indeed to remove them, and re-introduce them when needed. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1836#discussion_r2189230076
