On Tue, 8 Jul 2025 20:55:05 GMT, Alexander Matveev <almat...@openjdk.org> wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Process reviewer comments
>> Add null checks
>> Fix errors in position and length calculations
>
> modules/javafx.media/src/main/native/jfxmedia/platform/osx/OSXMediaPlayer.mm
> line 331:
>
>> 329: CJavaInputStreamCallbacks *callbacks = new (nothrow)
>> CJavaInputStreamCallbacks();
>> 330: jobject jConnectionHolder =
>> CLocator::CreateConnectionHolder(env, jLocator);
>> 331: if (callbacks == NULL || jConnectionHolder == NULL) {
>
> Extra space after `callbacks == NULL`.
fixed
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1839#discussion_r2196876883
