On Wed, 2 Apr 2025 14:06:58 GMT, Pabulaner IV wrote:
> When trying to register an open URI handler when using JavaFX with a native
> menu, this task fails on Mac.
> Either the native menu is not shown or the URIs are not received.
>
> This pull request fixes this issue if AWT is registered afte
On Tue, 15 Apr 2025 16:27:49 GMT, Michael Strauß wrote:
>>> A bigger question is why are we using `int` coordinates? Wouldn't it make
>>> the test depend on the scale (and also on the screen resolution and window
>>> position)?
>>
>> I run this frequently on my Windows laptop with 125% and hav
On Sat, 12 Apr 2025 00:23:07 GMT, Marius Hanl wrote:
>> These are the remaining bits and pieces in order to completely remove the
>> JUnit Vintage Engine, and therefore JUnit 4 from JavaFX.
>> After that, we should either document, that JUnit5 is used (just as
>> information) or close
>> [JDK-
On Tue, 15 Apr 2025 20:35:57 GMT, Andy Goryachev wrote:
> Looks good.
>
> Unrelated note: the last three tests should not be parameterized since they
> seem to be testing specific conditions (we missed this during the review).
>
> Since this is a test, we could fix it as a part of this PR, tho
On Sat, 12 Apr 2025 00:23:07 GMT, Marius Hanl wrote:
>> These are the remaining bits and pieces in order to completely remove the
>> JUnit Vintage Engine, and therefore JUnit 4 from JavaFX.
>> After that, we should either document, that JUnit5 is used (just as
>> information) or close
>> [JDK-
On Tue, 15 Apr 2025 19:51:53 GMT, Andy Goryachev wrote:
> Re-ran the tests on windows:
>
> * enable swt in build.gradle:3085
> * using command `gradlew :swt:test -PSWT_TEST=true`
> all three swt tests pass.
I did the same, and all three pass for me, too.
Btw, there is already a follow-up bug
On Tue, 15 Apr 2025 20:16:04 GMT, Marius Hanl wrote:
> [JDK-8297316](https://bugs.openjdk.org/browse/JDK-8297316) added a Workaround
> for the Japanese Date Converter, which is different on JDK20 and newer. Since
> our Boot JDK is Java 22 as of April 2025, we can remove the workaround.
>
> We
[JDK-8297316](https://bugs.openjdk.org/browse/JDK-8297316) added a Workaround
for the Japanese Date Converter, which is different on JDK20 and newer. Since
our Boot JDK is Java 22 as of April 2025, we can remove the workaround.
We should also consider testing and closing:
[JDK-8265727](https://
On Sat, 12 Apr 2025 00:23:07 GMT, Marius Hanl wrote:
>> These are the remaining bits and pieces in order to completely remove the
>> JUnit Vintage Engine, and therefore JUnit 4 from JavaFX.
>> After that, we should either document, that JUnit5 is used (just as
>> information) or close
>> [JDK-
On Mon, 14 Apr 2025 20:29:32 GMT, Andy Goryachev wrote:
> SWT tests are disabled on MAC, because Gradle test runner does not handle
> -XstartOnFirstThread properly (https://issues.gradle.org/browse/GRADLE-3290).
Yeah I saw this as well and looked it up, may worth to do as follow-up, as
Kevin a
On Tue, 15 Apr 2025 14:52:10 GMT, Andy Goryachev wrote:
>> I restored it, I think it's a Linux glass specific bug.
>
> If it's a bug, could you please create a JBS ticket?
Sure. I'll look into it.
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1776#discussion_r2045115036
On Sat, 12 Apr 2025 00:23:07 GMT, Marius Hanl wrote:
>> These are the remaining bits and pieces in order to completely remove the
>> JUnit Vintage Engine, and therefore JUnit 4 from JavaFX.
>> After that, we should either document, that JUnit5 is used (just as
>> information) or close
>> [JDK-
On Mon, 14 Apr 2025 13:10:05 GMT, Gopal Pattnaik wrote:
>> There was a Assertion fail issue in mouse location test case JDK-8296554,
>> Reason: We felt the one mili second delay time for the Robot test may be
>> insufficient in few OS.
>> Solution: We Changed the delay time to three mili second.
On Mon, 14 Apr 2025 15:07:52 GMT, Andy Goryachev wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Missed one change
>
> modules/javafx.graphics/src/main/java/com/sun/glass/events/WindowEvent.java
> line 7
On Tue, 15 Apr 2025 15:36:52 GMT, Kevin Rushforth wrote:
>> Good idea. As a (minor) suggestion, I might loop "5" times before calling it
>> a failure.
>
>> A bigger question is why are we using `int` coordinates? Wouldn't it make
>> the test depend on the scale (and also on the screen resolutio
Clean merge of January CPU content into `jfx24u:master`. Note that this is a
no-op merge, since there is no security content for this release. The only
content is some identity merge commits and two duplicate commits of bug fixes
that were pulled into the `jfx24.0.1` release after the version bu
On Tue, 15 Apr 2025 13:53:59 GMT, Kevin Rushforth wrote:
> Clean merge of January CPU content into `jfx24u:master`. Note that this is a
> no-op merge, since there is no security content for this release. The only
> content is some identity merge commits and two duplicate commits of bug fixes
>
On Tue, 15 Apr 2025 15:35:44 GMT, Kevin Rushforth wrote:
>> I would recommend to use a for loop as below.
>>
>> private static int VALIDATE_COUNT = 3;
>> static void validate(Robot robot, int x, int y) {
>> for (int i = 0; i < VALIDATE_COUNT; i++) {
>> Util.sleep(DEL
On Mon, 14 Apr 2025 23:39:46 GMT, Thiago Milczarek Sayao
wrote:
>> modules/javafx.graphics/src/main/java/javafx/stage/StageStyle.java line 35:
>>
>>> 33:
>>> 34: /**
>>> 35: * Defines a normal {@code Stage} style with a solid background and
>>> platform decorations.
>>
>> Should we
On Mon, 14 Apr 2025 13:29:08 GMT, John Hendrikx wrote:
>> Improve StageStyle Documentation
>>
>> - Update `StageStyle.UTILITY`:
>> Clarified that UTILITY stages may impose platform-specific restrictions on
>> window states, such as preventing maximize, minimize (iconify), and
>> fullscreen ope
On Thu, 10 Apr 2025 22:41:02 GMT, Kevin Rushforth wrote:
> This PR fixes a bug where a local variable was declared to be the wrong type,
> causing an error at compilation time when compiling with gcc 14. gcc 14
> rejects assignments of incompatible pointer types without an explicit cast.
> In
On Wed, 9 Apr 2025 23:17:49 GMT, Kevin Rushforth wrote:
> Release notes for JavaFX 24.0.1.
>
> Notes to reviewers:
>
> I used the following filter to pick the issues:
>
> https://bugs.openjdk.org/issues/?filter=47358
>
> The original filter, with the backport IDs, is here:
>
> https://bugs.o
On Tue, 15 Apr 2025 07:18:44 GMT, Ambarish Rapte wrote:
>> tests/system/src/test/java/test/robot/javafx/scene/MouseLocationOnScreenTest.java
>> line 123:
>>
>>> 121: try {
>>> 122: Util.sleep(DELAY_TIME);
>>> 123: Assertions.assertEquals(x, (int) robot.getMouseX(
On Mon, 14 Apr 2025 23:25:57 GMT, Thiago Milczarek Sayao
wrote:
>> Improve StageStyle Documentation
>>
>> - Update `StageStyle.UTILITY`:
>> Clarified that UTILITY stages may impose platform-specific restrictions on
>> window states, such as preventing maximize, minimize (iconify), and
>> full
> Implementation of
> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
Michael Strauß has updated the pull request incrementally with one additional
commit since the last revision:
documentation
-
Changes:
- all: https://git.openjdk.org/
On Tue, 15 Apr 2025 13:55:43 GMT, Kevin Rushforth wrote:
>> Release notes for JavaFX 24.0.1.
>>
>> Notes to reviewers:
>>
>> I used the following filter to pick the issues:
>>
>> https://bugs.openjdk.org/issues/?filter=47358
>>
>> The original filter, with the backport IDs, is here:
>>
>> ht
On Tue, 15 Apr 2025 13:53:59 GMT, Kevin Rushforth wrote:
> Clean merge of January CPU content into `jfx24u:master`. Note that this is a
> no-op merge, since there is no security content for this release. The only
> content is some identity merge commits and two duplicate commits of bug fixes
>
On Tue, 15 Apr 2025 13:55:43 GMT, Kevin Rushforth wrote:
>> Release notes for JavaFX 24.0.1.
>>
>> Notes to reviewers:
>>
>> I used the following filter to pick the issues:
>>
>> https://bugs.openjdk.org/issues/?filter=47358
>>
>> The original filter, with the backport IDs, is here:
>>
>> ht
On Tue, 15 Apr 2025 13:53:59 GMT, Kevin Rushforth wrote:
> Clean merge of January CPU content into `jfx24u:master`. Note that this is a
> no-op merge, since there is no security content for this release. The only
> content is some identity merge commits and two duplicate commits of bug fixes
>
> Release notes for JavaFX 24.0.1.
>
> Notes to reviewers:
>
> I used the following filter to pick the issues:
>
> https://bugs.openjdk.org/issues/?filter=47358
>
> The original filter, with the backport IDs, is here:
>
> https://bugs.openjdk.org/issues/?filter=47357
>
> As usual, I excluded
On Wed, 2 Apr 2025 14:06:58 GMT, Pabulaner IV wrote:
> When trying to register an open URI handler when using JavaFX with a native
> menu, this task fails on Mac.
> Either the native menu is not shown or the URIs are not received.
>
> This pull request fixes this issue if AWT is registered afte
On Mon, 14 Apr 2025 16:48:51 GMT, Andy Goryachev wrote:
>> Gopal Pattnaik has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Addressed Review comments
>
> tests/system/src/test/java/test/robot/javafx/scene/MouseLocationOnScreenTest.java
>
32 matches
Mail list logo
