On Mon, 14 Apr 2025 15:07:52 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

>> Thiago Milczarek Sayao has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Missed one change
>
> modules/javafx.graphics/src/main/java/com/sun/glass/events/WindowEvent.java 
> line 76:
> 
>> 74:             case WindowEvent.FOCUS_DISABLED -> "FOCUS_DISABLED";
>> 75:             case WindowEvent.FOCUS_UNGRAB -> "FOCUS_UNGRAB";
>> 76:             default -> "UNKNOWN";
> 
> Just wanted to share, I usually do `"?" + eventType`, or in this case it 
> might be `"UNKNOWN?" + eventType`.

Makes sense, but I think most reviewers would say it's an unrelated change as 
ask to rollback :)

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1777#discussion_r2042402111

Reply via email to