On Sat, 12 Apr 2025 00:23:07 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> These are the remaining bits and pieces in order to completely remove the >> JUnit Vintage Engine, and therefore JUnit 4 from JavaFX. >> After that, we should either document, that JUnit5 is used (just as >> information) or close >> [JDK-8296284](https://bugs.openjdk.org/browse/JDK-8296284) (Since you can >> not use JUnit4 anymore). >> >> This also removes the `org.hamcrest` dependency, which is actually only used >> in one test where it can easily be replaced by a `Predicate` (instead of >> `Matcher`). I'm not convinced that we should keep that dependency for just >> one test. >> >> ~Note: I could not get the `:swt` tests to compile/test, in order to run the >> tests. >> I need some guidance here how to instruct `Gradle` to compile this module >> (and if I need anything else? like swt?).~ >> >> ~Also, this probably needs an extra ticket in the JBS?~ > > Marius Hanl has updated the pull request incrementally with one additional > commit since the last revision: > > Fix SWT Tests Re-tested on windows, using the same command: (git reflog -1; gradle --continue -PFULL_TEST=true -PUSE_ROBOT=true -PSWT_TEST=true cleanTest test --no-daemon -x :web:test --info 2>&1) | tee ~/`date +"test-%Y-%m%d-%H%M%S"`.log I don't see swt tests being run, here is relevant grep: > Task :swt:testClasses Skipping task ':swt:testClasses' as it has no actions. Resolve mutations for :swt:test (Thread[#88,Execution worker Thread 7,5,main]) started. :swt:test (Thread[#88,Execution worker Thread 7,5,main]) started. > Task :swt:test SKIPPED Skipping task ':swt:test' as task onlyIf 'Task is enabled' is false. what am I doing wrong? ------------- PR Comment: https://git.openjdk.org/jfx/pull/1774#issuecomment-2806850799
