Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v6]

2025-04-04 Thread Jay Bhaskar
On Fri, 4 Apr 2025 17:09:20 GMT, Andy Goryachev wrote: >> Jay Bhaskar has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - remove whitespace >> - change according to review > > modules/javafx.base/src/test/java/test/javafx/util/converter/D

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v5]

2025-04-04 Thread Jay Bhaskar
On Fri, 4 Apr 2025 17:08:25 GMT, Andy Goryachev wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> re-order imports > > modules/javafx.base/src/test/java/test/javafx/util/converter/DateTimeStringConverterTest.java > l

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v4]

2025-04-04 Thread Jay Bhaskar
On Fri, 4 Apr 2025 17:04:26 GMT, Andy Goryachev wrote: >> Jay Bhaskar has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v6]

2025-04-04 Thread Jay Bhaskar
> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. Jay Bhaskar has updated the pull request incrementally with two additional commits since the last revision

RFR: 8245602: Ensemble8: HTMLEditor Toolbar gets scrolled out of view.

2025-04-04 Thread Gopal Pattnaik
There was a scrolling issue with multiline edit control with text controls at the top of the edit box [JDK-8245602](https://bugs.openjdk.org/browse/JDK-8245602), We replaced the ScrollPane with VBox control as the parent of the html edit control. Verification: This makes the controls on the to

RFR: 8352982: gradle TEST_SDK_PATH param doesn't work with relative paths

2025-04-04 Thread Ambarish Rapte
Issue: The test execution fails when a relative path is specified a relative path for `TEST_SDK_PATH`. For example: 1. gradle -PTEST_ONLY=true -PTEST_SDK_PATH=**..**/jfx1/build test 2. gradle -PTEST_ONLY=true -PTEST_SDK_PATH=**~**/jfx1/build test Solution: Convert the relative path to an absolut

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v3]

2025-04-04 Thread Kevin Rushforth
On Tue, 1 Apr 2025 22:42:25 GMT, Kevin Rushforth wrote: >> Turns out one can't intercept assertion exceptions with >> `Thread.setDefaultUncaughtExceptionHandler()` (duh!), so this is likely to >> be a known limitation. >> >> We might still provide general purpose methods in `ScreenCapture` (ne

TabPane overflow menu showing blanks

2025-04-04 Thread Cormac Redmond
Hi, TabPane tabs allow you to set graphic nodes as the header and there appears to be no documented limitations or best-practises on this. You might assume it's perfectly reasonable to not set a Tab's text value, and instead set the header as a HBox, consisting of a graphic node (left) and a Labe

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v3]

2025-04-04 Thread Andy Goryachev
On Tue, 1 Apr 2025 20:11:46 GMT, Kevin Rushforth wrote: >> There is more than one way to sk^H^H pet the cat. >> >> We could use a property to disable (or rather, enable) the screenshots, and >> only enable the capture during the debugging session. This will prevent us >> from catching those h

Re: RFR: 8351276: Prevent redundant computeValue calls when a chain of mappings becomes observed [v2]

2025-04-04 Thread John Hendrikx
> 8351276: Prevent redundant computeValue calls when a chain of mappings > becomes observed John Hendrikx has updated the pull request incrementally with one additional commit since the last revision: Fix review comments - Changes: - all: https://git.openjdk.org/jfx/pull/1730/

Re: RFR: 8351867: No UI changes while iconified

2025-04-04 Thread Martin Fox
On Fri, 4 Apr 2025 21:20:15 GMT, Andy Goryachev wrote: > I can help with the testing: I have 15.3.2 with one or two external monitors. > What might help is to enumerate scenarios we want to be tested. Thanks for the offer. I'm also running 15.3.2. I suspect I'll have to try test on an older ve

Integrated: 8328716: [TestBug] Screen capturing utility for failed tests

2025-04-04 Thread Andy Goryachev
On Fri, 28 Mar 2025 18:22:56 GMT, Andy Goryachev wrote: > Introduce a facility, in the form of JUnit5 annotation, to allow for > capturing a desktop screenshot of a failed test. > > The primary intent is to be able to debug an intermittent test case, rather > than wholesale addition of the new

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v8]

2025-04-04 Thread Kevin Rushforth
On Fri, 4 Apr 2025 21:55:09 GMT, Andy Goryachev wrote: >> Introduce a facility, in the form of JUnit5 annotation, to allow for >> capturing a desktop screenshot of a failed test. >> >> The primary intent is to be able to debug an intermittent test case, rather >> than wholesale addition of the

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v8]

2025-04-04 Thread Kevin Rushforth
On Fri, 4 Apr 2025 22:09:46 GMT, Andy Goryachev wrote: >> Actually, Safari is the browser which will show the complete screenshot. >> Chrome will only show a truncated screenshot, and I don't have Firefox to >> test. > > I was planning to add a decoding tool to the MonkeyTester anyway. > Actu

Re: RFR: 8351733: Crash when creating too many nested event loops [v3]

2025-04-04 Thread Kevin Rushforth
On Fri, 28 Mar 2025 05:58:19 GMT, Michael Strauß wrote: > > The docs on `canStartNestedEventLoop` describe its behavior already. I'm > > not sure what further information would be useful. Would it be enough to > > add a see also link? > > The exception being thrown is a behavior of `enterNeste

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v8]

2025-04-04 Thread Andy Goryachev
On Fri, 4 Apr 2025 22:08:09 GMT, Andy Goryachev wrote: >> Although apparently not Chrome. :) > > Actually, Safari is the browser which will show the complete screenshot. > Chrome will only show a truncated screenshot, and I don't have Firefox to > test. I was planning to add a decoding tool t

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v8]

2025-04-04 Thread Kevin Rushforth
On Fri, 4 Apr 2025 21:55:09 GMT, Andy Goryachev wrote: >> Introduce a facility, in the form of JUnit5 annotation, to allow for >> capturing a desktop screenshot of a failed test. >> >> The primary intent is to be able to debug an intermittent test case, rather >> than wholesale addition of the

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v8]

2025-04-04 Thread Andy Goryachev
On Fri, 4 Apr 2025 22:07:22 GMT, Kevin Rushforth wrote: >> tests/system/src/test/java/test/util/ScreenCaptureTestWatcher.java line 45: >> >>> 43: @Override >>> 44: public void testFailed(ExtensionContext extensionContext, Throwable >>> err) { >>> 45: // the data url can be paste

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v8]

2025-04-04 Thread Kevin Rushforth
On Fri, 4 Apr 2025 21:51:34 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> stderr > > tests/system/src/test/java/test/util/ScreenCaptureTestWatcher.java line 45: > >> 43: @Override >> 4

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v6]

2025-04-04 Thread Andy Goryachev
On Fri, 4 Apr 2025 21:43:41 GMT, Kevin Rushforth wrote: > in a JSON image, you wouldn't have the `""data:image/png;base64,"` prefix? correct, the prefix would be something else, like `takeScreenshotBase64("{screenshot:","}");` - PR Review Comment: https://git.openjdk.org/jfx/pull/1

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v6]

2025-04-04 Thread Kevin Rushforth
On Fri, 4 Apr 2025 21:46:02 GMT, Andy Goryachev wrote: >>> We are not ready for JSON logs, I admit, but this was the rationale behind >>> the design of this class: >>> >>> * a low-level method that returns byte[] >>> * a base-64 encoding method that allows for custom prefix/suffix to be able >

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v8]

2025-04-04 Thread Andy Goryachev
> Introduce a facility, in the form of JUnit5 annotation, to allow for > capturing a desktop screenshot of a failed test. > > The primary intent is to be able to debug an intermittent test case, rather > than wholesale addition of the new annotation to all the tests. > > The log contains a base

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v7]

2025-04-04 Thread Andy Goryachev
On Fri, 4 Apr 2025 21:15:37 GMT, Andy Goryachev wrote: >> Introduce a facility, in the form of JUnit5 annotation, to allow for >> capturing a desktop screenshot of a failed test. >> >> The primary intent is to be able to debug an intermittent test case, rather >> than wholesale addition of the

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v7]

2025-04-04 Thread Kevin Rushforth
On Fri, 4 Apr 2025 21:15:37 GMT, Andy Goryachev wrote: >> Introduce a facility, in the form of JUnit5 annotation, to allow for >> capturing a desktop screenshot of a failed test. >> >> The primary intent is to be able to debug an intermittent test case, rather >> than wholesale addition of the

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v6]

2025-04-04 Thread Kevin Rushforth
On Fri, 4 Apr 2025 21:42:39 GMT, Andy Goryachev wrote: >> One thing that happened recently (in the past 10 years or so) is that JSON >> became a frequently used format for logs. It's not perfect, but it's easy >> to parse. With that, json-oriented log viewers came. >> >> We don't have a cons

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v6]

2025-04-04 Thread Andy Goryachev
On Fri, 4 Apr 2025 21:39:32 GMT, Andy Goryachev wrote: >>> hmm, not sure if I share the concern (did I understand the concern?) >>> >>> the idea is to have a low-level method `takeScreenshotBase64(prefix, >>> postfix)` that can be used in non-standard situations, but also provide the >>> conve

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v6]

2025-04-04 Thread Andy Goryachev
On Fri, 4 Apr 2025 21:28:59 GMT, Kevin Rushforth wrote: >> hmm, not sure if I share the concern (did I understand the concern?) >> >> the idea is to have a low-level method `takeScreenshotBase64(prefix, >> postfix)` that can be used in non-standard situations, but also provide the >> convenien

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v6]

2025-04-04 Thread Kevin Rushforth
On Fri, 4 Apr 2025 21:11:19 GMT, Andy Goryachev wrote: > hmm, not sure if I share the concern (did I understand the concern?) > > the idea is to have a low-level method `takeScreenshotBase64(prefix, > postfix)` that can be used in non-standard situations, but also provide the > convenience met

Re: RFR: 8351867: No UI changes while iconified

2025-04-04 Thread Andy Goryachev
On Thu, 13 Mar 2025 10:36:40 GMT, John Hendrikx wrote: > Adds code to trigger a scene update when a Window is restored > > This seems to solve https://bugs.openjdk.org/browse/JDK-8351867 and > https://bugs.openjdk.org/browse/JDK-8146479 I can help with the testing: I have 15.3.2 with one or tw

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v6]

2025-04-04 Thread Andy Goryachev
On Fri, 4 Apr 2025 21:05:52 GMT, Kevin Rushforth wrote: >> The reason I have prefix and postfix instead of what you are proposing is >> that in my case only one event is written to the output. This might be >> important when both stderr and stdout are redirected to the same log file, >> in wh

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v7]

2025-04-04 Thread Andy Goryachev
> Introduce a facility, in the form of JUnit5 annotation, to allow for > capturing a desktop screenshot of a failed test. > > The primary intent is to be able to debug an intermittent test case, rather > than wholesale addition of the new annotation to all the tests. > > The log contains a base

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v6]

2025-04-04 Thread Kevin Rushforth
On Fri, 4 Apr 2025 20:44:23 GMT, Andy Goryachev wrote: > > Maybe add class docs in the utility class > > both classes have code samples to illustrate the usage - maybe insufficient. > any suggestions? No, I just failed to notice it. My fault. - PR Comment: https://git.openjdk.org

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v6]

2025-04-04 Thread Kevin Rushforth
On Fri, 4 Apr 2025 20:57:06 GMT, Andy Goryachev wrote: >> tests/system/src/test/java/test/util/ScreenshotCapture.java line 93: >> >>> 91: */ >>> 92: public static void writeScreenshot(PrintStream out) { >>> 93: >>> out.println(ScreenshotCapture.takeScreenshotBase64("Screenshot:

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v6]

2025-04-04 Thread Kevin Rushforth
On Fri, 4 Apr 2025 20:42:03 GMT, Andy Goryachev wrote: >> tests/system/src/test/java/test/util/ScreenshotCapture.java line 60: >> >>> 58: * @throws IOException when an I/O error occurs >>> 59: */ >>> 60: public static byte[] takeScreenshot() throws IOException { >> >> I have no id

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v6]

2025-04-04 Thread Andy Goryachev
On Fri, 4 Apr 2025 20:30:55 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> javadoc > > tests/system/src/test/java/test/util/ScreenshotCapture.java line 93: > >> 91: */ >> 92: publi

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v6]

2025-04-04 Thread Andy Goryachev
On Fri, 4 Apr 2025 20:28:43 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> javadoc > > tests/system/src/test/java/test/util/ScreenshotCapture.java line 107: > >> 105: * @return the scr

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v6]

2025-04-04 Thread Andy Goryachev
On Fri, 4 Apr 2025 20:24:16 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> javadoc > > tests/system/src/test/java/test/util/ScreenshotCapture.java line 60: > >> 58: * @throws IOExcepti

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v6]

2025-04-04 Thread Andy Goryachev
On Fri, 4 Apr 2025 20:38:08 GMT, Kevin Rushforth wrote: > Maybe add class docs in the utility class both classes have code samples to illustrate the usage - maybe insufficient. any suggestions? - PR Comment: https://git.openjdk.org/jfx/pull/1746#issuecomment-2779696634

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v6]

2025-04-04 Thread Kevin Rushforth
On Fri, 4 Apr 2025 20:36:32 GMT, Kevin Rushforth wrote: > One other thing that might be helpful is class docs that describe the two > different ways of using it (the watcher annotation and the direct call to the > utility method). Scratch the first part of this suggestion: the annotation alrea

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v6]

2025-04-04 Thread Kevin Rushforth
On Wed, 2 Apr 2025 15:04:54 GMT, Andy Goryachev wrote: >> Introduce a facility, in the form of JUnit5 annotation, to allow for >> capturing a desktop screenshot of a failed test. >> >> The primary intent is to be able to debug an intermittent test case, rather >> than wholesale addition of the

Re: RFR: 8351867: No UI changes while iconified

2025-04-04 Thread Martin Fox
On Thu, 13 Mar 2025 10:36:40 GMT, John Hendrikx wrote: > Adds code to trigger a scene update when a Window is restored > > This seems to solve https://bugs.openjdk.org/browse/JDK-8351867 and > https://bugs.openjdk.org/browse/JDK-8146479 I think this PR is the correct fix on Windows and Linux.

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests

2025-04-04 Thread Kevin Rushforth
On Fri, 28 Mar 2025 18:22:56 GMT, Andy Goryachev wrote: > Introduce a facility, in the form of JUnit5 annotation, to allow for > capturing a desktop screenshot of a failed test. > > The primary intent is to be able to debug an intermittent test case, rather > than wholesale addition of the new

Re: RFR: 8347937: Canvas pattern test fails and crashes on WebKit 620.1

2025-04-04 Thread Kevin Rushforth
On Fri, 21 Mar 2025 10:54:58 GMT, Sergey Nazarkin wrote: > I see CanvasTest failure. But I guess it is unrelated > > ``` > CanvasTest > testCanvasPattern() FAILED > org.opentest4j.AssertionFailedError: First rect top-left ==> expected: > <255> but was: <0> > ``` @snazarkin This failure is

Integrated: 8350009: [XWayland] SwingNodePlatformExitCrashTest hangs on Ubuntu 24.04

2025-04-04 Thread Jayathirth D V
On Tue, 1 Apr 2025 15:51:07 GMT, Jayathirth D V wrote: > SwingNodePlatformExitCrashTest hangs on Ubuntu 24.04 and wayland when we use > < JDK 24. > > This is happening because of issue identified in > https://bugs.openjdk.org/browse/JDK-8335468 and it is fixed in JDK 24. > So we need to run th

Re: RFR: 8351733: Crash when creating too many nested event loops [v3]

2025-04-04 Thread Kevin Rushforth
On Thu, 27 Mar 2025 22:19:29 GMT, Martin Fox wrote: >> In any case, this PR should at least add the following bits of information >> to `Platform.enterNestedEventLoop()`: >> 1. There is some limit to the number of nested event loops. >> 2. Applications should always check `Platform.canStartNeste

Re: RFR: 8350976: MenuBarSkin: exception initializing in a background thread [v2]

2025-04-04 Thread Jayathirth D V
On Wed, 5 Mar 2025 18:19:53 GMT, Andy Goryachev wrote: >> Allows MenuBar to be created in a background thread by delaying >> MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the >> scene graph. > > Andy Goryachev has updated the pull request with a new target base due to

Re: RFR: 8352982: gradle TEST_SDK_PATH param doesn't work with relative paths [v3]

2025-04-04 Thread Ambarish Rapte
> Issue: > The test execution fails when a relative path is specified a relative path > for `TEST_SDK_PATH`. > For example: > 1. gradle -PTEST_ONLY=true -PTEST_SDK_PATH=**..**/jfx1/build test > 2. gradle -PTEST_ONLY=true -PTEST_SDK_PATH=**~**/jfx1/build test > > Solution: > Convert the relative

Re: RFR: 8351878: RichTextArea: copy/paste issues [v5]

2025-04-04 Thread Lukasz Kostyra
On Wed, 26 Mar 2025 14:36:39 GMT, Andy Goryachev wrote: >> Fixed several issues found in importing RTF text: >> >> - charset translation (brought back removed code) >> - missing font size attribute >> - missing strike-through attribute >> >> Also, HTML copy suffered from the following issues: >

Re: RFR: 8352999: [macOS] Conditional behavior by directly querying the Objective-C call stack

2025-04-04 Thread Martin Fox
On Mon, 31 Mar 2025 20:41:10 GMT, Andy Goryachev wrote: > just curious: could this have any relevance to > https://bugs.openjdk.org/browse/JDK-8353314 ? No, I can still reproduce that bug with this PR. Something else is going on. - PR Comment: https://git.openjdk.org/jfx/pull/1749

Re: RFR: 8342565: [TestBug] StubTextLayout [v9]

2025-04-04 Thread Kevin Rushforth
On Tue, 25 Mar 2025 21:46:51 GMT, Andy Goryachev wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/text/TextRun.java line >> 45: >> >>> 43: int script; >>> 44: TextSpan span; >>> 45: com.sun.javafx.scene.text.TextLine line; >> >> I recommend an import rather than listi

Re: RFR: 8234153: [TEST_BUG] Rewrite Popup_parentWindow_Test

2025-04-04 Thread Andy Goryachev
On Fri, 4 Apr 2025 11:30:04 GMT, Lukasz Kostyra wrote: > This change rewrites `Popup_parentWindow_Test` after a-long-time-ago-done > changes to Popup public API. > > Popup used to have an `owner` and `parentWindow` properties. I couldn't track > how far back that change happened so I can't ful

Re: RFR: 8347937: Canvas pattern test fails and crashes on WebKit 620.1

2025-04-04 Thread Kevin Rushforth
On Fri, 21 Mar 2025 08:17:39 GMT, Jay Bhaskar wrote: > Issue: > Ref: Webkit 619.1 > javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageSource.cpp > refactoring in 620.1 > In the case of the canvas pattern using a transform property filled with an > SVGMatrix() > created by an SV

Re: RFR: 8351733: [macos] Crash when creating too many nested event loops [v3]

2025-04-04 Thread Martin Fox
On Mon, 24 Mar 2025 17:48:00 GMT, Kevin Rushforth wrote: >> I added a comment explaining where the number comes from. Since it's only >> used in this one spot putting it in a static const variable seemed redundant. >> >> I'm not sure that 250 is a safe limit. I know that the JUnit test crashes

Re: RFR: 8319555: [TestBug] Utility for creating instruction window for manual tests

2025-04-04 Thread Kevin Rushforth
On Fri, 28 Mar 2025 18:43:34 GMT, Andy Goryachev wrote: > Provides the base class for manual tests which displays the test > instructions, the UI under test, and the Pass/Fail buttons. > > Uses `EmojiTest` to illustrate the use of the new class. > > Example: > > > public class ManualTestExam

RFR: 8234153: [TEST_BUG] Rewrite Popup_parentWindow_Test

2025-04-04 Thread Lukasz Kostyra
This change rewrites `Popup_parentWindow_Test` after a-long-time-ago-done changes to Popup public API. Popup used to have an `owner` and `parentWindow` properties. I couldn't track how far back that change happened so I can't fully say what these Properties actually were, but to my knowledge bo

Re: RFR: 8245602: Ensemble8: HTMLEditor Toolbar gets scrolled out of view

2025-04-04 Thread duke
On Tue, 1 Apr 2025 06:47:59 GMT, Gopal Pattnaik wrote: > There was a scrolling issue with multiline edit control with text controls at > the top of the edit box > [JDK-8245602](https://bugs.openjdk.org/browse/JDK-8245602), > > We replaced the ScrollPane with VBox control as the parent of the h

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v2]

2025-04-04 Thread Andy Goryachev
> Introduce a facility, in the form of JUnit5 annotation, to allow for > capturing a desktop screenshot of a failed test. > > The primary intent is to be able to debug an intermittent test case, rather > than wholesale addition of the new annotation to all the tests. > > A possible improvement

Re: RFR: 8352746: [TestBug] Monkey Tester Application Update 5

2025-04-04 Thread Lukasz Kostyra
On Mon, 31 Mar 2025 23:11:42 GMT, Andy Goryachev wrote: > Further additions to the MonkeyTester application: > > - platform preferences monitor > - improved pages: hbox, vbox > - improved css playground > - mouse listener option in some context menus > - additional choices: background > - additi

Re: Feature Request: Support for Transparent Title Bars in JavaFX Stages

2025-04-04 Thread Michael Strauß
Already under way: https://github.com/openjdk/jfx/pull/1605

Reporting a JavaFx bug

2025-04-04 Thread Dahlberg, Magnus
Hi, I'm trying to report a bug with JavaFx 21.0.5 (and later versions) The only place I've seen where that would be possible is https://bugreport.java.com/bugreport/, but that page reports an error when I try to submit. Is there anywhere else it can be done? Many thanks, Magnus Dahlberg

Re: RFR: 8319555: [TestBug] Utility for creating instruction window for manual tests

2025-04-04 Thread Kevin Rushforth
On Fri, 28 Mar 2025 23:16:18 GMT, Andy Goryachev wrote: > On a related note, where is it documented how to run manual tests? It isn't documented anywhere. Nor are the tests wired up to the build. We have the following test sprint bug filed: [JDK-8296441](https://bugs.openjdk.org/browse/JDK-829

Re: RFR: 8350976: MenuBarSkin: exception initializing in a background thread [v2]

2025-04-04 Thread Andy Goryachev
On Wed, 2 Apr 2025 06:06:58 GMT, Jayathirth D V wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commi

Integrated: 8352746: [TestBug] Monkey Tester Application Update 5

2025-04-04 Thread Andy Goryachev
On Mon, 31 Mar 2025 23:11:42 GMT, Andy Goryachev wrote: > Further additions to the MonkeyTester application: > > - platform preferences monitor > - improved pages: hbox, vbox > - improved css playground > - mouse listener option in some context menus > - additional choices: background > - additi

Re: RFR: 8352746: [TestBug] Monkey Tester Application Update 5

2025-04-04 Thread Andy Goryachev
On Fri, 4 Apr 2025 16:26:22 GMT, Jayathirth D V wrote: >> Further additions to the MonkeyTester application: >> >> - platform preferences monitor >> - improved pages: hbox, vbox >> - improved css playground >> - mouse listener option in some context menus >> - additional choices: background >> -

Re: RFR: 8351867: No UI changes while iconified

2025-04-04 Thread Martin Fox
On Thu, 13 Mar 2025 10:36:40 GMT, John Hendrikx wrote: > Adds code to trigger a scene update when a Window is restored > > This seems to solve https://bugs.openjdk.org/browse/JDK-8351867 and > https://bugs.openjdk.org/browse/JDK-8146479 First an errata: I wrote earlier that notifyRepaint is on

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v5]

2025-04-04 Thread Andy Goryachev
On Fri, 4 Apr 2025 06:08:28 GMT, Jay Bhaskar wrote: >> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing >> deprecated APIs, updating assertions, and refactoring test structures to >> align with JUnit 5's improved features. > > Jay Bhaskar has updated the pull request increm

Integrated: 8353587: Spelling errors and dead code

2025-04-04 Thread Andy Goryachev
On Wed, 2 Apr 2025 22:03:27 GMT, Andy Goryachev wrote: > Corrects annoying spelling errors in the code: > > - propogated > - Hueristic2D > > Also fixes unnecessary field in MenuBar:171 This pull request has now been integrated. Changeset: 76282bcf Author:Andy Goryachev URL: https:

Integrated: 8353668: Rename internal c.s.javafx.text.TextLine class

2025-04-04 Thread Andy Goryachev
On Thu, 3 Apr 2025 18:01:07 GMT, Andy Goryachev wrote: > This minor change renames an internal `com.sun.javafx.text.TextLine` to > `PrismTextLine`. > This class implements `com.sun.javafx.scene.text.TextLine` interface, also > internal, for the purpose of reducing confusion and avoiding FQCN. >

Re: RFR: 8345348: CSS Media Queries [v6]

2025-04-04 Thread Michael Strauß
> Implementation of [CSS media > queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: make media-query types internal - Changes: - all: https://gi

Re: RFR: 8352746: [TestBug] Monkey Tester Application Update 5

2025-04-04 Thread Jayathirth D V
On Mon, 31 Mar 2025 23:11:42 GMT, Andy Goryachev wrote: > Further additions to the MonkeyTester application: > > - platform preferences monitor > - improved pages: hbox, vbox > - improved css playground > - mouse listener option in some context menus > - additional choices: background > - additi

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5

2025-04-04 Thread Andy Goryachev
On Thu, 3 Apr 2025 12:34:37 GMT, Jay Bhaskar wrote: > Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. First batch of comments (up until `ObservableArrayTes

Re: RFR: 8352982: gradle TEST_SDK_PATH param doesn't work with relative paths [v2]

2025-04-04 Thread Ambarish Rapte
On Wed, 2 Apr 2025 11:41:23 GMT, Kevin Rushforth wrote: > always use file(testSdkPath).absolutePath? This sounds better, changed accordingly. > build.gradle line 745: > >> 743: ext.TEST_SDK_DIR = "${rootProject.buildDir}" >> 744: } >> 745: println "TEST_SDK_PATH: " + TEST_SDK_DIR > > Mino

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v23]

2025-04-04 Thread Andy Goryachev
> Please refer to > > https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md > > The RichTextArea control > ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom > control that needs non-trivial navigation within complex or wrapped text > needs a p

Integrated: 8353557: Skip some system tests on Linux

2025-04-04 Thread Jayathirth D V
On Fri, 4 Apr 2025 10:16:18 GMT, Jayathirth D V wrote: > Under https://bugs.openjdk.org/browse/JDK-8339679 task, we are running full > tests and identifying issues for Ubuntu 24.04. > > As part of above task 6 test failures were identified and looks like these > test failures are happening bec

RFR: 8353557: Skip some system tests on Linux

2025-04-04 Thread Jayathirth D V
Under https://bugs.openjdk.org/browse/JDK-8339679 task, we are running full tests and identifying issues for Ubuntu 24.04. As part of above task 6 test failures were identified and looks like these test failures are happening because of product issues in Ubuntu24.04. Test failures are: 1) Resto

Re: RFR: 8351878: RichTextArea: copy/paste issues [v5]

2025-04-04 Thread Andy Goryachev
On Fri, 4 Apr 2025 12:43:54 GMT, Lukasz Kostyra wrote: > LGTM than you! > some fonts don't support those special characters (ex. Arial Rounded MT Bold > on Windows) so as a fallback they are drawn with a different font that > supports them. It's quite normal behavior to do so I've seen often,

Re: RFR: 8353557: Skip some system tests on Linux

2025-04-04 Thread Kevin Rushforth
On Fri, 4 Apr 2025 10:16:18 GMT, Jayathirth D V wrote: > Under https://bugs.openjdk.org/browse/JDK-8339679 task, we are running full > tests and identifying issues for Ubuntu 24.04. > > As part of above task 6 test failures were identified and looks like these > test failures are happening bec

Re: RFR: 8353557: Skip some system tests on Linux

2025-04-04 Thread Jayathirth D V
On Fri, 4 Apr 2025 11:55:34 GMT, Kevin Rushforth wrote: > The changes look good. I'll do a quick test as well and then approve. Please > make sure you've done a full automated test run before integrating. I have run full automated test run and all updated tests behave as expected on all test p

Re: RFR: 8345348: CSS Media Queries [v5]

2025-04-04 Thread John Hendrikx
On Fri, 4 Apr 2025 11:13:43 GMT, Michael Strauß wrote: >> Implementation of [CSS media >> queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > add docu

Re: RFR: 8353557: Skip some system tests on Linux

2025-04-04 Thread Kevin Rushforth
On Fri, 4 Apr 2025 10:16:18 GMT, Jayathirth D V wrote: > Under https://bugs.openjdk.org/browse/JDK-8339679 task, we are running full > tests and identifying issues for Ubuntu 24.04. > > As part of above task 6 test failures were identified and looks like these > test failures are happening bec

Re: RFR: 8345348: CSS Media Queries [v5]

2025-04-04 Thread Michael Strauß
> Implementation of [CSS media > queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: add documentation - Changes: - all: https://git.openjdk.org/

Re: RFR: 8345348: CSS Media Queries [v4]

2025-04-04 Thread Michael Strauß
> Implementation of [CSS media > queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: add missing javadoc tag - Changes: - all: https://git.openjd

Re: RFR: 8345348: CSS Media Queries [v3]

2025-04-04 Thread Michael Strauß
> Implementation of [CSS media > queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). Michael Strauß has updated the pull request incrementally with two additional commits since the last revision: - revert import - move scene preferences to Scene.Preferences interface --