On Wed, 2 Apr 2025 06:06:58 GMT, Jayathirth D V <j...@openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a 
>> merge or a rebase. The incremental webrev excludes the unrelated changes 
>> brought in by the merge/rebase. The pull request contains six additional 
>> commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin/master' into 
>> 8350976.menubarskin.thread.safety
>>  - spelling
>>  - use system menu
>>  - cleanup
>>  - possible fix
>>  - test
>
> For test verification i was following what i do in JDK of checking out the 
> branch in the PR and without build verify that the test fails and then build 
> the branch(which will build source code change also) and then make sure test 
> passes.
> 
> Got to know that we need to use -PTEST_ONLY=true in FX to make sure that 
> source code changes are not built when i use gradle to run the test. With 
> this approach i can see that the test fails without product change and passes 
> with it :)

The mystery solved!  Thank you @jayathirthrao !

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1727#issuecomment-2772754855

Reply via email to