> Fixed several issues found in importing RTF text:
>
> - charset translation (brought back removed code)
> - missing font size attribute
> - missing strike-through attribute
>
> Also, HTML copy suffered from the following issues:
>
> - incorrect font size
> - incorrect handling of boolean chara
On Tue, 25 Mar 2025 18:36:51 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert "fixed bad merge"
>>
>> This reverts commit 0e9e8ee63895bd1d976398587add5b96958d38aa.
>
> modules/java
On Tue, 25 Mar 2025 21:55:54 GMT, Andy Goryachev wrote:
>> Changed the StubTextLayout to use product PrismTextLayout with much
>> simplified glyph layout (via stubbed fonts). The new layout assumes all the
>> glyphs are squares of font size, while the bold type face produces wider
>> glyphs (
On Tue, 25 Mar 2025 22:53:55 GMT, Ziad El Midaoui
wrote:
>> Added multi line prompt support for TextArea this will provide the ability
>> to have multiple lines in textArea as expected,
>> Also fixed tests to meet the new changes
>
> Ziad El Midaoui has updated the pull request incrementally wi
On Tue, 25 Mar 2025 14:53:25 GMT, Ziad El Midaoui
wrote:
> The font and size are not applied
Thank you, the screenshot helped!
The problem was in the way HTML text was copied to Outlook (for some reason,
Outlook prioritizes HTML over RTF when pasting). The font sizes in HTML were
using poin
On Mon, 24 Mar 2025 18:30:56 GMT, Martin Fox wrote:
>> There is an undocumented limit on nesting calls to CFRunLoopRun (or the
>> equivalent wrapper NSRunLoop methods). When the limit is hit the OS
>> terminates the Java app. The situation arises when a JavaFX app creates too
>> many nested ev
With the minimum JDK set to 22, the reflection calls is replaced with direct
calls to enableNativeAccess
-
Commit messages:
- Replaced reflection with direct calls to enableNativeAccess.
Changes: https://git.openjdk.org/jfx/pull/1743/files
Webrev: https://webrevs.openjdk.org/?rep
On Tue, 25 Mar 2025 17:43:43 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert "fixed bad merge"
>>
>> This reverts commit 0e9e8ee63895bd1d976398587add5b96958d38aa.
>
> modules/java
On Fri, 14 Mar 2025 16:27:09 GMT, Andy Goryachev wrote:
>> With the new approach the `promptText` property is accepting any value so
>> it's expected to have prompt text with Linebreaks for `TextField` and
>> `PasswordField`, is this the test that I have to keep ?
>>
>> Else to have a test tha
> Added multi line prompt support for TextArea this will provide the ability to
> have multiple lines in textArea as expected,
> Also fixed tests to meet the new changes
Ziad El Midaoui has updated the pull request incrementally with one additional
commit since the last revision:
Removed unus
On Mon, 24 Mar 2025 16:59:43 GMT, Andy Goryachev wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor changes
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextFieldSkin.java
> line 33:
>
On Tue, 25 Mar 2025 22:24:51 GMT, Ziad El Midaoui
wrote:
> With the minimum JDK set to 22, the reflection calls is replaced with direct
> calls to enableNativeAccess
looks good!
please update the copyright year in the modified files.
1 reviewer is probably enough.
-
PR Review: h
On Tue, 25 Mar 2025 21:41:14 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ListViewTest.java
>> line 100:
>>
>>> 98: import test.com.sun.javafx.scene.control.test.RT_22463_Person;
>>> 99:
>>> 100: /**
>>
>> Minor: We don't typically use javadoc-
> Changed the StubTextLayout to use product PrismTextLayout with much
> simplified glyph layout (via stubbed fonts). The new layout assumes all the
> glyphs are squares of font size, while the bold type face produces wider
> glyphs (by 1 pixel). The default font size has changed from 10 to 12
On Mon, 24 Mar 2025 18:30:56 GMT, Martin Fox wrote:
>> There is an undocumented limit on nesting calls to CFRunLoopRun (or the
>> equivalent wrapper NSRunLoop methods). When the limit is hit the OS
>> terminates the Java app. The situation arises when a JavaFX app creates too
>> many nested ev
Thank you, Christopher, for clarification!
Personally, I would consider this to be a problem with the application design:
the code should limit the number of alerts shown to the user. Do you really
want the user to click through hundreds of alerts?
Nevertheless, you are right about the need fo
On Thu, 6 Mar 2025 16:21:52 GMT, Andy Goryachev wrote:
>> Changed the StubTextLayout to use product PrismTextLayout with much
>> simplified glyph layout (via stubbed fonts). The new layout assumes all the
>> glyphs are squares of font size, while the bold type face produces wider
>> glyphs (b
> Windows programs may reuse a clipboard buffer that is larger than the new
> content. In this case de NUL terminator is not at the end of the buffer, but
> within it.
> The current implementation copys the whole buffer into a text field,
> including the NUL terminator and the remaining chars.
On Sat, 22 Mar 2025 12:20:17 GMT, John Hendrikx wrote:
> This PR will forward more Label calculations to LabeledSkinBase, as they are
> quite complex, especially when a Graphic is involved which is a full-fledged
> `Node`. More specifically, this solves issues with TitledPane when the
> graphi
On Tue, 25 Mar 2025 09:53:10 GMT, Lukasz Kostyra wrote:
>> As @mstr2 said, I think the data is always converted to CF_UNICODETEXT. If
>> it wasn't there should have been more visible problems, as the current code
>> always assumes wide chars.
>>
>> So I just need to know how much we should cha
On Mon, 24 Mar 2025 21:00:38 GMT, Martin Fox wrote:
> A centralized solution will probably lose that distinction but I'm not sure
> that's important. Exceeding 240+ nested events loops is problematic either
> way.
Agreed.
-
PR Comment: https://git.openjdk.org/jfx/pull/1741#issuec
On Mon, 24 Mar 2025 18:30:56 GMT, Martin Fox wrote:
>> There is an undocumented limit on nesting calls to CFRunLoopRun (or the
>> equivalent wrapper NSRunLoop methods). When the limit is hit the OS
>> terminates the Java app. The situation arises when a JavaFX app creates too
>> many nested ev
On Mon, 24 Mar 2025 18:30:56 GMT, Martin Fox wrote:
>> There is an undocumented limit on nesting calls to CFRunLoopRun (or the
>> equivalent wrapper NSRunLoop methods). When the limit is hit the OS
>> terminates the Java app. The situation arises when a JavaFX app creates too
>> many nested ev
On Tue, 25 Mar 2025 14:37:14 GMT, Andy Goryachev wrote:
> please be more specific - maybe include a screenshot of the outlook message
> vs. rich text area?
The font and size are not applied
 bias of a child
>> when its fill width property is set to `false`. This manifests itself with
>> labels that have their wrap text property set to `true`, and the container
>> is
On Mon, 24 Mar 2025 21:06:54 GMT, Andy Goryachev wrote:
> 2. RTL/LTR attributes are not yet supported by the demo due to many bugs in
> RTL.
By RTL and LTR I just meant normal text orientation and arabic one , when
writing a text in outlook and copying it then pasting it doesn't keep the
forma
On Tue, 25 Mar 2025 09:36:46 GMT, Oliver Schmidtmer
wrote:
>> Could be, but in any case, the way it's impemented right now doesn't seem to
>> be right. We should only assume 2-byte characters if what's being pulled
>> from the clipboard is actually `CF_UNICODETEXT`.
>
> As @mstr2 said, I think
On Fri, 28 Feb 2025 16:48:39 GMT, Michael Strauß wrote:
>> As the existing code was already pretty optimistic about 2 byte chars, is it
>> possible that is already handled somewhere else?
>> I'm not sure whether this is done explicitly somewhere or if CF_UNICODETEXT
>> is just tried first.
>
>
29 matches
Mail list logo
