On Thu, 6 Mar 2025 16:21:33 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> # Behavior
>>
>> |Listener...|ExpressionHelper|ListenerManager|
>> |---|---|---|
>> |Invocation Order|In order
On Fri, 7 Mar 2025 20:38:38 GMT, Nir Lisker wrote:
>> 8351276: Prevent redundant computeValue calls when a chain of mappings
>> becomes observed
>
> modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java
> line 378:
>
>> 376: * can first become observed (allowing ca
On Fri, 7 Mar 2025 21:59:10 GMT, Michael Strauß wrote:
> @threadAccess JavaFX application thread
Out of scope for this PR, but it might be a good idea.
-
PR Comment: https://git.openjdk.org/jfx/pull/1728#issuecomment-2707661783
On Fri, 7 Mar 2025 21:46:03 GMT, Nir Lisker wrote:
>> 8351276: Prevent redundant computeValue calls when a chain of mappings
>> becomes observed
>
> modules/javafx.base/src/main/java/com/sun/javafx/binding/LazyObjectBinding.java
> line 62:
>
>> 60: updateSubscriptionBeforeAdd();
>> 61:
On Thu, 6 Mar 2025 15:22:58 GMT, John Hendrikx wrote:
> 8351276: Prevent redundant computeValue calls when a chain of mappings
> becomes observed
modules/javafx.base/src/main/java/com/sun/javafx/binding/LazyObjectBinding.java
line 62:
> 60: updateSubscriptionBeforeAdd();
> 61:
> 62:
On Fri, 7 Mar 2025 21:39:24 GMT, Andy Goryachev wrote:
> what custom tags? could you elaborate?
Maybe a custom tag like `@threadAccess JavaFX application thread`. This would
then show up in the generated property list instead of the summary text. We
already do this for `@interpolationType`.
-
On Fri, 7 Mar 2025 21:34:14 GMT, Michael Strauß wrote:
> move to a more structured form of documentation, for example with custom
> javadoc tags.
what custom tags? could you elaborate?
-
PR Comment: https://git.openjdk.org/jfx/pull/1728#issuecomment-2707510227
On Fri, 7 Mar 2025 21:11:52 GMT, Andy Goryachev wrote:
> We are not addressing the misuse of APIs by the applications, only providing
> a mechanism to fail early in the narrow case when controls/skins/nodes try
> access the Platform globals.
Then I diagree with the problem statement. Calling o
> - enforced fx application thread
> - clarify doc where an `IllegalStateException` can get thrown, such as hide()
> and show()
> - clarified `ComboBoxBase::show`
> - added a headful test `TestThreadingRestrictions`
Andy Goryachev has updated the pull request incrementally with two additional
co
On Fri, 7 Mar 2025 18:42:36 GMT, Andy Goryachev wrote:
>> Adding a listener or a binding to the global/static properties outside of
>> the JavaFX application thread will likely cause concurrent access issues
>> when the caller, still being executing in the background thread, receives an
>> eve
On Fri, 7 Mar 2025 18:43:29 GMT, Andy Goryachev wrote:
> @mstr2 : should we also enforce the access rules in
> `Platform::getPreferences()` ?
In principle, yes. But just checking at the point of calling
`Platform.getPreferences()` doesn't seem to be sufficient. An application could
easily cal
On Fri, 7 Mar 2025 18:42:36 GMT, Andy Goryachev wrote:
>> Adding a listener or a binding to the global/static properties outside of
>> the JavaFX application thread will likely cause concurrent access issues
>> when the caller, still being executing in the background thread, receives an
>> eve
> Changed the spec to require access only from the FX application thread.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains four additional
On Fri, 7 Mar 2025 17:56:42 GMT, Andy Goryachev wrote:
>> - enforced fx application thread
>> - clarify doc where an `IllegalStateException` can get thrown, such as
>> hide() and show()
>> - clarified `ComboBoxBase::show`
>> - added a headful test `TestThreadingRestrictions`
>
> Andy Goryachev h
On Fri, 7 Mar 2025 17:04:41 GMT, Michael Strauß wrote:
>> The general policy is to avoid unrelated changes and expanding the scope.
>>
>> A proper way to address that would be to create a JBS and do a wholesale
>> bulk edit, not sure if it's worth it though.
>
> You've added the same javadoc ta
On Fri, 7 Mar 2025 16:57:05 GMT, Andy Goryachev wrote:
>> Can you do it for the other changed docs also?
>
> The general policy is to avoid unrelated changes and expanding the scope.
>
> A proper way to address that would be to create a JBS and do a wholesale bulk
> edit, not sure if it's worth
On Fri, 7 Mar 2025 16:45:18 GMT, Michael Strauß wrote:
>> it is not required, and the code is inconsistent (Stage:472) ... but ok.
>
> Can you do it for the other changed docs also?
The general policy is to avoid unrelated changes and expanding the scope.
A proper way to address that would be t
On Fri, 7 Mar 2025 15:45:03 GMT, Andy Goryachev wrote:
>>> will do next time, to avoid re-setting the approvals ;-)
>>
>> I'll re-approve if you decide to do the changes anyway.
>
> it is not required, and the code is inconsistent (Stage:472) ... but ok.
Can you do it for the other changed docs
On Fri, 7 Mar 2025 15:38:39 GMT, Michael Strauß wrote:
>> good idea, even though it does not affect generated javadoc.
>> will do next time, to avoid re-setting the approvals ;-)
>
>> will do next time, to avoid re-setting the approvals ;-)
>
> I'll re-approve if you decide to do the changes any
> - enforced fx application thread
> - clarify doc where an `IllegalStateException` can get thrown, such as hide()
> and show()
> - clarified `ComboBoxBase::show`
> - added a headful test `TestThreadingRestrictions`
Andy Goryachev has updated the pull request with a new target base due to a
merg
On Fri, 7 Mar 2025 13:54:45 GMT, Michael Strauß wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains seven commits:
>>
>> - Merge remote-tracking branch 'origin/master' into 8350048.enforce
>> - review commen
On Fri, 7 Mar 2025 15:30:46 GMT, Andy Goryachev wrote:
> will do next time, to avoid re-setting the approvals ;-)
I'll re-approve if you decide to do the changes anyway.
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1717#discussion_r1985279553
> The original code used String attribute keys.
>
> I'd like to backport this fix to jfx24u.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
==
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1731/files
- new:
On Thu, 6 Mar 2025 15:22:58 GMT, John Hendrikx wrote:
> 8351276: Prevent redundant computeValue calls when a chain of mappings
> becomes observed
That's a good fix!
-
Marked as reviewed by mstrauss (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1730#pullrequestreview-266
On Wed, 5 Mar 2025 18:20:51 GMT, Andy Goryachev wrote:
>> - enforced fx application thread
>> - clarify doc where an `IllegalStateException` can get thrown, such as
>> hide() and show()
>> - clarified `ComboBoxBase::show`
>> - added a headful test `TestThreadingRestrictions`
>
> Andy Goryachev h
On Fri, 21 Feb 2025 06:59:52 GMT, Gopal Pattnaik wrote:
> There was no test included with the fix for
> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
>
> Hence we are adding a system test now.
>
> Test is written as
> 1. Load html content in web view.
> 2. pick the color of mous
26 matches
Mail list logo
