On Fri, 7 Mar 2025 13:54:45 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains seven commits:
>>
>> - Merge remote-tracking branch 'origin/master' into 8350048.enforce
>> - review comments
>> - review comments
>> - Merge remote-tracking branch 'origin/master' into 8350048.enforce
>> - fixed node init test
>> - all tests
>> - initial test
>
> modules/javafx.graphics/src/main/java/javafx/stage/Stage.java line 1187:
>
>> 1185: * This call is equivalent to {@code hide()}.
>> 1186: * @throws IllegalStateException if this method is called on a
>> thread
>> 1187: * other than the JavaFX Application Thread.
>
> Minor: add a blank line before `@throws`. I also think it's easier to read
> docs when multi-line text for a javadoc tag is indented, either by four
> spaces or lined up with the beginning of the first line of text (i.e. with
> the beginning of `IllegalStateException`).
good idea, even though it does not affect generated javadoc.
will do next time, to avoid re-setting the approvals ;-)
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1717#discussion_r1985268281
