> Implementation of
> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09)
> and `EXTENDED_UTILITY` stage style.
Michael Strauß has updated the pull request incrementally with one additional
commit since the last revision:
small MonkeyTester refactor
-
C
> Implementation of
> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09)
> and `EXTENDED_UTILITY` stage style.
Michael Strauß has updated the pull request incrementally with two additional
commits since the last revision:
- add samples in MonkeyTester
- typo
--
On Mon, 2 Dec 2024 16:19:46 GMT, Michael Strauß wrote:
> Implementation of [CSS media
> queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7).
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jfx/pull/1655
On Mon, 27 Jan 2025 22:10:18 GMT, Andy Goryachev wrote:
> Fixes minor issues uncovered while writing API tests #1677:
>
> - StyledTextModel::clamp L559 is incorrect at the end of paragraph
> - CodeArea.getText() adds extra newline at the end
>
> This change should be back-ported to jfx24.
I'll
Fixes minor issues uncovered while writing API tests #1677:
- StyledTextModel::clamp L559 is incorrect at the end of paragraph
- CodeArea.getText() adds extra newline at the end
This change should be back-ported to jfx24.
-
Commit messages:
- newlines
- check
- cleanup
- clamp
On Mon, 27 Jan 2025 22:57:37 GMT, Michael Strauß wrote:
>> Implementation of
>> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09)
>> and `EXTENDED_UTILITY` stage style.
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since t
On Mon, 27 Jan 2025 22:57:37 GMT, Michael Strauß wrote:
>> Implementation of
>> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09)
>> and `EXTENDED_UTILITY` stage style.
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since t
> Implementation of
> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09)
> and `EXTENDED_UTILITY` stage style.
Michael Strauß has updated the pull request incrementally with one additional
commit since the last revision:
hide default window buttons on macOS
---
On Fri, 20 Dec 2024 22:23:11 GMT, Andy Goryachev wrote:
> Changed the StubTextLayout to use product PrismTextLayout with much
> simplified glyph layout (via stubbed fonts). The new layout assumes all the
> glyphs are squares of font size, while the bold type face produces wider
> glyphs (by 1
On Fri, 20 Dec 2024 22:23:11 GMT, Andy Goryachev wrote:
> Changed the StubTextLayout to use product PrismTextLayout with much
> simplified glyph layout (via stubbed fonts). The new layout assumes all the
> glyphs are squares of font size, while the bold type face produces wider
> glyphs (by 1
On Mon, 27 Jan 2025 21:15:44 GMT, Kevin Rushforth wrote:
> This pull request has been inactive for more than 4 weeks
I doubt that.
-
PR Comment: https://git.openjdk.org/jfx/pull/1667#issuecomment-2616913729
On Wed, 22 Jan 2025 20:01:43 GMT, Johan Vos wrote:
> Bump version to 21.0.7
This pull request has now been integrated.
Changeset: 10bafe7d
Author:Johan Vos
URL:
https://git.openjdk.org/jfx21u/commit/10bafe7dd8b7bf5fea05c1dcb2760694537ccd47
Stats: 2 lines in 2 files changed: 0 in
> Modified the resize algorithm to work well with fractional scale, thanks for
> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>
> Removed earlier manual tester in favor of the monkey tester.
>
> It is important to note that even though the constraints are given by the
> us
On Wed, 15 Jan 2025 15:41:23 GMT, Andy Goryachev wrote:
>> Modified the resize algorithm to work well with fractional scale, thanks for
>> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>>
>> Removed earlier manual tester in favor of the monkey tester.
>>
>> It is important
On Wed, 22 Jan 2025 19:58:09 GMT, Johan Vos wrote:
> Bump version to 17.0.15
This pull request has now been integrated.
Changeset: 9c234e4c
Author:Johan Vos
URL:
https://git.openjdk.org/jfx17u/commit/9c234e4c31932b1f3ddb84122ba892db22e0bb92
Stats: 2 lines in 2 files changed: 0 i
On Mon, 27 Jan 2025 18:34:30 GMT, Michael Strauß wrote:
>> Passing a `VetoableListDecorator.subList()` to any of its bulk operations
>> (`addAll`, `setAll`, `removeAll`, `retainAll`) throws
>> `ConcurrentModificationException`. The reason is that the
>> `VetoableListDecorator.modCount` field i
On Mon, 27 Jan 2025 18:55:11 GMT, Michael Strauß wrote:
> We can't do that, because a sublist is specified to be a live view onto the
> source list.
good point, thanks for pointing this out.
-
PR Comment: https://git.openjdk.org/jfx/pull/1679#issuecomment-2616657340
On Mon, 27 Jan 2025 18:47:41 GMT, Andy Goryachev wrote:
> > Can you elaborate?
> > what does "save one extra pointer" mean?
>
> What I mean is simply get rid of the extra pointer like
> `VetoableListIteratorDecorator.parent` and the related logic, and simply
> create a copy of List/Collection
On Mon, 27 Jan 2025 18:34:30 GMT, Michael Strauß wrote:
>> Passing a `VetoableListDecorator.subList()` to any of its bulk operations
>> (`addAll`, `setAll`, `removeAll`, `retainAll`) throws
>> `ConcurrentModificationException`. The reason is that the
>> `VetoableListDecorator.modCount` field i
On Mon, 2 Dec 2024 14:34:08 GMT, Alexander Zvegintsev
wrote:
>> Thanks @azvegint. If the `int`-based dimensions are coupled with
>> `com.sun.javafx.geom.Rectangle` (and from the code, that's the only place
>> they are used at), would you object to making `Dimension` an inner class of
>> `Rect
> Passing a `VetoableListDecorator.subList()` to any of its bulk operations
> (`addAll`, `setAll`, `removeAll`, `retainAll`) throws
> `ConcurrentModificationException`. The reason is that the
> `VetoableListDecorator.modCount` field is incremented before the underlying
> list's bulk operation i
On Thu, 16 Jan 2025 18:26:37 GMT, Andy Goryachev wrote:
> One possible alternative is to create the defensive copy each time, this will
> save one extra pointer every time an iterator or a sublist gets created
> (these objects might be long lived). The code in this PR creates a copy in
> many
Changed the StubTextLayout to use product PrismTextLayout with much simplified
glyph layout (via stubbed fonts). The new layout assumes all the glyphs are
squares of font size, while the bold type face produces wider glyphs (by 1
pixel). The default font size has changed from 10 to 12 to make
On Mon, 27 Jan 2025 17:28:14 GMT, Andy Goryachev wrote:
>> I'm not familiar with these methods, but I did wonder why we need extra
>> implementations in the initial comment.
>
> looks like dead code left over from the original implementation.
>
> I removed the class along with the two methods a
On Mon, 27 Jan 2025 16:56:21 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/geom/Dimension2Df.java
>> line 34:
>>
>>> 32: * @see javafx.geometry.Dimension2D Dimension2D - doubles
>>> 33: */
>>> 34: public record Dimension2Df(float width, float height) {}
>>
>>
On Mon, 27 Jan 2025 16:36:28 GMT, Andy Goryachev wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/geom/Dimension2Df.java
> line 34:
>
On Sat, 25 Jan 2025 07:04:41 GMT, Nir Lisker wrote:
>> A small refactoring of the Dimension classes.
>>
>> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
>> `com.sun.javafx.geom.Dimension2D`.
>> * `com.sun.javafx.geom.Dimension2D` became a record.
>> * `javafx.geome
On Wed, 15 Jan 2025 15:41:23 GMT, Andy Goryachev wrote:
>> Modified the resize algorithm to work well with fractional scale, thanks for
>> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>>
>> Removed earlier manual tester in favor of the monkey tester.
>>
>> It is important
On Sat, 25 Jan 2025 00:37:28 GMT, Kevin Rushforth wrote:
>> we will violate the max constraint if we snap to a larger value.
>>
>> so for the max constraint, we should `snapInnerSpace()` which calls the
>> private (?) `Region.snapPortionX()`.
>
>> we will violate the max constraint if we snap
29 matches
Mail list logo
