> A batch of typo and grammar fixes that were found by the spellchecker.
>
> Integration can wait until RDP 1/2.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comment
-
Changes:
- all: https://git.ope
On Fri, 6 Dec 2024 13:09:35 GMT, Michael Strauß wrote:
> cssref.html L2038: ` apples when the mnemonic affordance (typically an
> underscore)`
Didn't notice that this was fixed in a bigger patch.
-
PR Comment: https://git.openjdk.org/jfx/pull/1642#issuecomment-2613823400
On Sat, 25 Jan 2025 07:22:33 GMT, Nir Lisker wrote:
>> A batch of typo and grammar fixes that were found by the spellchecker.
>>
>> Integration can wait until RDP 1/2.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addresse
> A batch of typo and grammar fixes that were found by the spellchecker.
>
> Integration can wait until RDP 1/2.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Revert "Addressed review comment"
This reverts commit 60d4ba92b997be9
On Mon, 2 Dec 2024 19:45:47 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/geom/Dimension2D.java
>> line 31:
>>
>>> 29: * A 2D dimension object that contains a width and a height.
>>> 30: */
>>> 31: public record Dimension2D(float width, float height) {}
>
On Mon, 2 Dec 2024 19:13:20 GMT, Andy Goryachev wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/screencast/TokenStorage.java
> l
> A small refactoring of the Dimension classes.
>
> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
> `com.sun.javafx.geom.Dimension2D`.
> * `com.sun.javafx.geom.Dimension2D` became a record.
> * `javafx.geometry.Dimension2D`: fields became `final`.
>
> I'm not sure w
On Mon, 2 Dec 2024 14:34:08 GMT, Alexander Zvegintsev
wrote:
>> Thanks @azvegint. If the `int`-based dimensions are coupled with
>> `com.sun.javafx.geom.Rectangle` (and from the code, that's the only place
>> they are used at), would you object to making `Dimension` an inner class of
>> `Rect
On Sat, 25 Jan 2025 00:07:55 GMT, Andy Goryachev wrote:
> we will violate the max constraint if we snap to a larger value.
Well, it's inherently an over-constrained problem. Conceptually, though, this
does not violate the constraint. When snap-to-pixel is enabled, all values,
including min and
On Fri, 24 Jan 2025 19:38:24 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 39 commits:
>>
>> - Merge branch 'master' into 8299753.resize
>> - Merge remote-tracking branch 'origin/m
On Tue, 14 Jan 2025 01:56:10 GMT, Michael Strauß wrote:
> `VetoableListDecorator` does not correctly report removed indices. Instead of
> reporting ranges like `[0, 3)`, it always reports a pairwise list of single
> removals like `[0, 1, 1, 2, 2, 3)`.
>
> The reason is a off-by-one error, and
On Tue, 14 Jan 2025 01:56:10 GMT, Michael Strauß wrote:
> `VetoableListDecorator` does not correctly report removed indices. Instead of
> reporting ranges like `[0, 3)`, it always reports a pairwise list of single
> removals like `[0, 1, 1, 2, 2, 3)`.
>
> The reason is a off-by-one error, and
On Wed, 15 Jan 2025 15:41:23 GMT, Andy Goryachev wrote:
>> Modified the resize algorithm to work well with fractional scale, thanks for
>> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>>
>> Removed earlier manual tester in favor of the monkey tester.
>>
>> It is important
That's great, thank you Pascal!
-andy
From: Pascal
Date: Friday, January 24, 2025 at 11:00
To: Andy Goryachev
Cc: openjfx-dev@openjdk.org
Subject: [External] : Re: MacOS: Title bar flickering when animation is playing
Hello Andy,
I tried to reproduce the issue with the latest JavaFX build, b
Hello Andy,
I tried to reproduce the issue with the latest JavaFX build, but
accidentally downloaded an older one, openjfx-24-ea+19. With this, the
flickering is still happening.
However, today I noticed my mistake and downloaded the latest,
openjfx-24-ea+25, and with that version I cannot reprod
On Tue, 14 Jan 2025 01:56:10 GMT, Michael Strauß wrote:
> `VetoableListDecorator` does not correctly report removed indices. Instead of
> reporting ranges like `[0, 3)`, it always reports a pairwise list of single
> removals like `[0, 1, 1, 2, 2, 3)`.
>
> The reason is a off-by-one error, and
16 matches
Mail list logo
