This PR adds another accessibility preference that is available on all
supported desktop platforms:
1. **Windows**: Settings -> Accessibility -> Visual Effects -> Always show
scroll bars
2. **macOS**: System Settings -> Appearance -> Show scroll bars
3. **Ubuntu**: Settings -> Accessibility -> S
On Sun, 20 Oct 2024 21:55:54 GMT, John Hendrikx wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add information about how ScrollPane acts on key presses.
>
> For users to get back to old behavior, some calculation
On Wed, 30 Oct 2024 22:51:30 GMT, Kevin Rushforth wrote:
>> This looks useful.
>> I wonder if it would make sense to create a utility method in some common
>> Util class?
>>
>>
>> public static boolean initBoolean(BooleanSupplier c) { return
>> c.getAsBoolean(); }
>>
>>
>> edit:
>> maybe in
On Wed, 30 Oct 2024 20:43:07 GMT, Kevin Rushforth wrote:
>> This PR removes all doPrivileged calls from `com.sun.javafx.tk**` in the
>> `javafx.graphics` module.
>>
>> Here is a quick overview of what I did for this fix:
>>
>> 1. Changed all simple cases of `doPrivileged((PrivilegedAction) ()
On Wed, 30 Oct 2024 20:44:39 GMT, Andy Goryachev wrote:
>> I decided to make this change. Thanks for the suggestion.
>
> This looks useful.
> I wonder if it would make sense to create a utility method in some common
> Util class?
>
>
> public static boolean initBoolean(BooleanSupplier c) { ret
On Wed, 30 Oct 2024 20:43:07 GMT, Kevin Rushforth wrote:
>> This PR removes all doPrivileged calls from `com.sun.javafx.tk**` in the
>> `javafx.graphics` module.
>>
>> Here is a quick overview of what I did for this fix:
>>
>> 1. Changed all simple cases of `doPrivileged((PrivilegedAction) ()
On Tue, 29 Oct 2024 05:16:54 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of eff
On Wed, 30 Oct 2024 18:24:26 GMT, Andy Goryachev wrote:
>> Removes doPrivileged in the following module:
>>
>> - javafx.media
>>
>> See JDK-8342441 for details.
>>
>> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
>> whitespace" option.
>
> Andy Goryachev has upda
On Tue, 29 Oct 2024 05:16:54 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of eff
On Wed, 30 Oct 2024 20:23:19 GMT, Michael Strauß wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 10447:
>
>> 10445: *
>
> Public focus traversal API for use in custom controls
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>
> This work is loosely based on the patch
> https://cr.openjdk.org/~jgiles/8061673/
>
> And is a scaled down version (with the public trav
On Wed, 30 Oct 2024 20:40:01 GMT, Kevin Rushforth wrote:
>> That's an interesting suggestion: trading a new method for a lambda (the
>> prior code used a lambda to pass to the doPrivileged, so it's also less of a
>> delta). I'll take a look at it and see if it looks better to me.
>
> I decided
> This PR removes all doPrivileged calls from `com.sun.javafx.tk**` in the
> `javafx.graphics` module.
>
> Here is a quick overview of what I did for this fix:
>
> 1. Changed all simple cases of `doPrivileged((PrivilegedAction) () ->
> LAMBDA)` to `LAMBDA`, removing the `@SuppressWarnings("rem
On Wed, 30 Oct 2024 15:02:30 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This work is loosely based on the patch
>> https://cr.openjdk.org/~jgiles/
On Tue, 29 Oct 2024 22:46:30 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/QuantumToolkit.java
>> line 142:
>>
>>> 140:
>>> 141: private static final boolean multithreaded = initMultithreaded();
>>> 142: private static boolean initMultit
> Incubating a new feature - rich text control, **RichTextArea**, intended to
> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The
> main design goal is to provide a control that is complete enough to be useful
> out-of-the box, as well as open to extension by the appl
On Wed, 30 Oct 2024 18:35:26 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/iio/javax/XImageLoader.java
>> line 126:
>>
>>> 124: int imageHeight = reader.getHeight(imageIndex);
>>> 125: int[] widthHeight = ImageTools.computeDimensions(
On Wed, 30 Oct 2024 18:24:26 GMT, Andy Goryachev wrote:
>> Removes doPrivileged in the following module:
>>
>> - javafx.media
>>
>> See JDK-8342441 for details.
>>
>> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
>> whitespace" option.
>
> Andy Goryachev has upda
On Wed, 30 Oct 2024 18:21:27 GMT, Andy Goryachev wrote:
>> Removes doPrivileged in the following module:
>>
>> - javafx.swing
>>
>> See JDK-8342441 for details.
>>
>> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
>> whitespace" option.
>
> Andy Goryachev has upda
On Tue, 29 Oct 2024 22:12:47 GMT, Andy Goryachev wrote:
>> Incubating a new feature - rich text control, **RichTextArea**, intended to
>> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane.
>> The main design goal is to provide a control that is complete enough to be
>> u
On Wed, 30 Oct 2024 18:16:26 GMT, Andy Goryachev wrote:
>> Removes doPrivileged in the following module:
>>
>> - javafx.swt
>>
>> See JDK-8342441 for details.
>>
>> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
>> whitespace" option.
>
> Andy Goryachev has update
On Wed, 30 Oct 2024 18:08:45 GMT, Andy Goryachev wrote:
>> modules/javafx.swt/src/main/java/javafx/embed/swt/FXCanvas.java line 359:
>>
>>> 357: });
>>> 358: return null;
>>> 359: }, null, FXCANVAS_PERMISSION);
>>
>> I think `FXCANVAS_PERMISSION` is unused after
On Wed, 30 Oct 2024 18:13:48 GMT, Andy Goryachev wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> com
On Tue, 29 Oct 2024 10:26:26 GMT, Jayathirth D V wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 21 additional
>> commi
On Fri, 25 Oct 2024 17:59:31 GMT, Kevin Rushforth wrote:
> we need to figure out the best way to constrain the `model` property of the
> RTA superclass.
Are you saying that the mechanism in CodeArea:92 is not suitable?
-
PR Comment: https://git.openjdk.org/jfx/pull/1524#issuecomme
On Wed, 30 Oct 2024 08:02:19 GMT, Jayathirth D V wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 21 additional
>> commi
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
> Removes doPrivileged in the following module:
>
> - javafx.media
>
> See JDK-8342441 for details.
>
> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
> whitespace" option.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a reba
> Removes doPrivileged in the following module:
>
> - javafx.swing
>
> See JDK-8342441 for details.
>
> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
> whitespace" option.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a reba
> Removes doPrivileged in the following module:
>
> - javafx.swt
>
> See JDK-8342441 for details.
>
> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
> whitespace" option.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase
On Wed, 30 Oct 2024 18:13:48 GMT, Andy Goryachev wrote:
>> Removes doPrivileged in the following module:
>>
>> - javafx.swt
>>
>> See JDK-8342441 for details.
>>
>> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
>> whitespace" option.
>
> Andy Goryachev has update
On Mon, 28 Oct 2024 15:18:45 GMT, Kevin Rushforth wrote:
>> Removes doPrivileged in the following module:
>>
>> - javafx.swt
>>
>> See JDK-8342441 for details.
>>
>> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
>> whitespace" option.
>
> modules/javafx.swt/src/m
On Mon, 28 Oct 2024 14:48:42 GMT, Andy Goryachev wrote:
> Removes `doPrivileged` in the following module:
>
> * javafx.fxml
>
> See JDK-8342441 for details.
>
> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
> whitespace" option.
@lukostyra Can you be the secon
On Mon, 28 Oct 2024 14:52:06 GMT, Andy Goryachev wrote:
> Removes doPrivileged in the following module:
>
> - javafx.swt
>
> See JDK-8342441 for details.
>
> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
> whitespace" option.
I left one comment inline about an u
On Mon, 28 Oct 2024 14:59:12 GMT, Andy Goryachev wrote:
> Removes doPrivileged in the following module:
>
> - javafx.swing
>
> See JDK-8342441 for details.
>
> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
> whitespace" option.
Looks good other than the one left
On Mon, 28 Oct 2024 14:57:17 GMT, Andy Goryachev wrote:
> Removes doPrivileged in the following module:
>
> - javafx.media
>
> See JDK-8342441 for details.
>
> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
> whitespace" option.
I see a few now-unneeded `@Suppres
On Fri, 25 Oct 2024 17:34:32 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> break iterator
>
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/TextPos.java
On Mon, 28 Oct 2024 14:57:17 GMT, Andy Goryachev wrote:
> Removes doPrivileged in the following module:
>
> - javafx.media
>
> See JDK-8342441 for details.
>
> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
> whitespace" option.
@sashamatveev could you take a loo
On Tue, 29 Oct 2024 22:12:47 GMT, Andy Goryachev wrote:
>> Incubating a new feature - rich text control, **RichTextArea**, intended to
>> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane.
>> The main design goal is to provide a control that is complete enough to be
>> u
> Public focus traversal API for use in custom controls
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>
> This work is loosely based on the patch
> https://cr.openjdk.org/~jgiles/8061673/
>
> And is a scaled down version (with the public trav
On Tue, 29 Oct 2024 19:56:39 GMT, Andy Goryachev wrote:
>> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/CodeTextModel.java
>> line 95:
>>
>>> 93: protected void invalidated() {
>>> 94: TextPos end = getDocumentEnd();
> Removes doPrivileged in the following module:
>
> - javafx.controls
>
> See JDK-8342441 for details.
>
> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
> whitespace" option.
Andy Goryachev has updated the pull request incrementally with one additional
commit sin
On Wed, 30 Oct 2024 14:36:44 GMT, Andy Goryachev wrote:
>> Removes doPrivileged in the following module:
>>
>> - javafx.controls
>>
>> See JDK-8342441 for details.
>>
>> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
>> whitespace" option.
>
> Andy Goryachev has u
On Mon, 28 Oct 2024 15:01:20 GMT, Prasanta Sadhukhan
wrote:
> When AWT toolkit is started first for it to own the "NSApplication" and then
> FX toolkit is started and shutdown by calling `Platform.exit` and then Swing
> Dialog is tried to be created, then it is seen that the application crashe
On Mon, 28 Oct 2024 15:01:20 GMT, Prasanta Sadhukhan
wrote:
> When AWT toolkit is started first for it to own the "NSApplication" and then
> FX toolkit is started and shutdown by calling `Platform.exit` and then Swing
> Dialog is tried to be created, then it is seen that the application crashe
On Mon, 28 Oct 2024 17:36:56 GMT, Michael Strauß wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) S
46 matches
Mail list logo
