On Wed, 30 Oct 2024 18:08:45 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

>> modules/javafx.swt/src/main/java/javafx/embed/swt/FXCanvas.java line 359:
>> 
>>> 357:             });
>>> 358:             return null;
>>> 359:         }, null, FXCANVAS_PERMISSION);
>> 
>> I think `FXCANVAS_PERMISSION` is unused after this and can be removed (along 
>> with the related import).
>
> there is a duplicate FXCANVAS_PERMISSION in PlatformImpl which should also be 
> removed.

I think that one could have waited, since the code in question would never be 
executed, but it does seem cleaner to remove it now.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1611#discussion_r1823199171

Reply via email to