Re: RFR: 8341440: ScrollPane: no immediate effect changing fitWidth/fitHeight [v2]

2024-10-10 Thread Kevin Rushforth
On Thu, 10 Oct 2024 23:29:29 GMT, Andy Goryachev wrote: >> - fixed the issue >> - added unit tests >> - clarified default value of `ScrollPane.fitWidth` and >> `ScrollPane.fitHeight` properties >> >> No CSR is needed as it is a minor clarification. > > Andy Goryachev has updated the pull reques

Re: RFR: 8341440: ScrollPane: no immediate effect changing fitWidth/fitHeight [v2]

2024-10-10 Thread John Hendrikx
On Thu, 10 Oct 2024 23:29:29 GMT, Andy Goryachev wrote: >> - fixed the issue >> - added unit tests >> - clarified default value of `ScrollPane.fitWidth` and >> `ScrollPane.fitHeight` properties >> >> No CSR is needed as it is a minor clarification. > > Andy Goryachev has updated the pull reques

Re: RFR: 8090456: Focus Management [v8]

2024-10-10 Thread John Hendrikx
On Thu, 10 Oct 2024 22:48:42 GMT, John Hendrikx wrote: >>> I did my best to actually find some use cases... >> >> Allow me to refer to some of the linked tickets in RFE >> https://bugs.openjdk.org/browse/JDK-8090456: >> >> [JDK-8091524](https://bugs.openjdk.org/browse/JDK-8091524) >> Introduce

Re: RFR: 8341440: ScrollPane: no immediate effect changing fitWidth/fitHeight [v2]

2024-10-10 Thread Andy Goryachev
> - fixed the issue > - added unit tests > - clarified default value of `ScrollPane.fitWidth` and `ScrollPane.fitHeight` > properties > > No CSR is needed as it is a minor clarification. Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision

Re: RFR: 8341440: ScrollPane: no immediate effect changing fitWidth/fitHeight

2024-10-10 Thread Andy Goryachev
On Thu, 10 Oct 2024 22:58:23 GMT, Andy Goryachev wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/ScrollPane.java >> line 358: >> >>> 356: * contained node is not a Resizable, this value is ignored. >>> 357: * >>> 358: * @defaultValue false >> >> This is unre

Re: RFR: 8090456: Focus Management [v8]

2024-10-10 Thread Andy Goryachev
On Thu, 10 Oct 2024 22:48:42 GMT, John Hendrikx wrote: >>> I did my best to actually find some use cases... >> >> Allow me to refer to some of the linked tickets in RFE >> https://bugs.openjdk.org/browse/JDK-8090456: >> >> [JDK-8091524](https://bugs.openjdk.org/browse/JDK-8091524) >> Introduce

Re: RFR: 8341440: ScrollPane: no immediate effect changing fitWidth/fitHeight

2024-10-10 Thread Andy Goryachev
On Thu, 10 Oct 2024 22:51:20 GMT, Kevin Rushforth wrote: >> - fixed the issue >> - added unit tests >> - clarified default value of `ScrollPane.fitWidth` and >> `ScrollPane.fitHeight` properties >> >> No CSR is needed as it is a minor clarification. > > modules/javafx.controls/src/main/java/jav

Re: RFR: 8341440: ScrollPane: no immediate effect changing fitWidth/fitHeight

2024-10-10 Thread Kevin Rushforth
On Thu, 10 Oct 2024 17:52:29 GMT, Andy Goryachev wrote: > - fixed the issue > - added unit tests > - clarified default value of `ScrollPane.fitWidth` and `ScrollPane.fitHeight` > properties > > No CSR is needed as it is a minor clarification. Fix and test both look good. I confirm that the new

Re: RFR: 8090456: Focus Management [v8]

2024-10-10 Thread John Hendrikx
On Thu, 10 Oct 2024 21:32:29 GMT, Andy Goryachev wrote: > > I did my best to actually find some use cases... > > Allow me to refer to some of the linked tickets in RFE > https://bugs.openjdk.org/browse/JDK-8090456: > > [JDK-8091524](https://bugs.openjdk.org/browse/JDK-8091524) Introduce a "foc

Re: RFR: 8090456: Focus Management [v8]

2024-10-10 Thread Andy Goryachev
On Thu, 10 Oct 2024 20:12:25 GMT, John Hendrikx wrote: > I did my best to actually find some use cases... Allow me to refer to some of the linked tickets in RFE https://bugs.openjdk.org/browse/JDK-8090456: [JDK-8091524](https://bugs.openjdk.org/browse/JDK-8091524) Introduce a "focus container"

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v26]

2024-10-10 Thread Martin Fox
On Thu, 3 Oct 2024 14:23:24 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> positioning on `InputMethodRequest`. >>

Re: RFR: 8090456: Focus Management [v8]

2024-10-10 Thread John Hendrikx
On Thu, 10 Oct 2024 16:56:42 GMT, Andy Goryachev wrote: > > I struggle to see what problem this will be solving that isn't already > > solved with the above. > > Let me try to explain this (again). ... > At high level, there might be _application-level requirements_ for > conditional travers

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v5]

2024-10-10 Thread Andy Goryachev
On Wed, 9 Oct 2024 22:41:29 GMT, Andy Goryachev wrote: >> The RichTextArea control >> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom >> control that needs non-trivial navigation within complex or wrapped text >> needs a public API to get information about text layo

Re: Proposing new API: [Text,TextFlow].getLayoutInfo()

2024-10-10 Thread Andy Goryachev
Additional questions: There is a need to extract a few more data points from the text layout in addition to the text lines, specifically: * bounds of the (selection) range, as rectangles * strikethrough range shape (as PathElement[] and/or rectangles) * underline range shape (as Path

RFR: 8341440: ScrollPane: no immediate effect changing fitWidth/fitHeight

2024-10-10 Thread Andy Goryachev
- fixed the issue - added unit tests - clarified default value of ScrollPane.fitWidth and .fitHeight properties No CSR is needed as it is a minor clarification. - Commit messages: - 8341440: ScrollPane: no immediate effect changing fitWidth/fitHeight Changes: https://git.openjdk.or

Re: RFR: 8337280: Include jdk.jsobject module with JavaFX [v5]

2024-10-10 Thread Jay Bhaskar
On Thu, 10 Oct 2024 12:31:53 GMT, Kevin Rushforth wrote: >> Add the `jdk.jsobject` module to JavaFX. This module is currently delivered >> by the JDK, but will be terminally-deprecated in JDK 24 by >> [JDK-8311530](https://bugs.openjdk.org/browse/JDK-8311530), which is out for >> review at op

Re: [jfx23u] RFR: 8341911: Create release notes for JavaFX 23.0.1

2024-10-10 Thread Kevin Rushforth
On Thu, 10 Oct 2024 17:14:50 GMT, Kevin Rushforth wrote: > Release notes for JavaFX 23.0.1. > > Notes to reviewers: > > I used the following filter to pick the issues: > > https://bugs.openjdk.org/issues/?filter=46412 > > The original filter, with the backport IDs, is here: > > https://bugs.

[jfx23u] RFR: 8341911: Create release notes for JavaFX 23.0.1

2024-10-10 Thread Kevin Rushforth
Release notes for JavaFX 23.0.1. Notes to reviewers: I used the following filter to pick the issues: https://bugs.openjdk.org/issues/?filter=46412 The original filter, with the backport IDs, is here: https://bugs.openjdk.org/issues/?filter=46411 As usual, I excluded test bugs, cleanup bugs, e

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v5]

2024-10-10 Thread Andy Goryachev
On Wed, 9 Oct 2024 22:41:29 GMT, Andy Goryachev wrote: >> The RichTextArea control >> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom >> control that needs non-trivial navigation within complex or wrapped text >> needs a public API to get information about text layo

Re: RFR: 8090456: Focus Management [v8]

2024-10-10 Thread Andy Goryachev
On Wed, 9 Oct 2024 23:49:24 GMT, John Hendrikx wrote: > I struggle to see what problem this will be solving that isn't already solved > with the above. Let me try to explain this (again). At high level, there might be _application-level requirements_ for conditional traversal, which should b

Re: RFR: 8090456: Focus Management [v9]

2024-10-10 Thread Andy Goryachev
On Wed, 9 Oct 2024 22:46:32 GMT, Andy Goryachev wrote: >> Public APIs for focus traversal and the focus traversal policy: >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal.md >> >> This work is loosely based on the patch >> https://cr.openjdk.org/~j

Re: RFR: 8090456: Focus Management [v8]

2024-10-10 Thread Martin Fox
On Thu, 10 Oct 2024 08:46:25 GMT, Michael Strauß wrote: >>> My suggestion for a better API is: have two separate knobs to configure >>> directional and logical focus traversal, and provide a very small set of >>> curated policies. We should only consider opening up the API to allow more >>> cu

Re: RFR: 8337280: Include jdk.jsobject module with JavaFX [v5]

2024-10-10 Thread Ambarish Rapte
On Thu, 10 Oct 2024 12:31:53 GMT, Kevin Rushforth wrote: >> Add the `jdk.jsobject` module to JavaFX. This module is currently delivered >> by the JDK, but will be terminally-deprecated in JDK 24 by >> [JDK-8311530](https://bugs.openjdk.org/browse/JDK-8311530), which is out for >> review at op

Re: RFR: 8337280: Include jdk.jsobject module with JavaFX [v5]

2024-10-10 Thread Kevin Rushforth
> Add the `jdk.jsobject` module to JavaFX. This module is currently delivered > by the JDK, but will be terminally-deprecated in JDK 24 by > [JDK-8311530](https://bugs.openjdk.org/browse/JDK-8311530), which is out for > review at openjdk/jdk#20555. We therefore plan to start delivering it with

Re: Proposal: Remove support for running JavaFX with the security manager

2024-10-10 Thread Kevin Rushforth
Yes. I will file the follow-up bugs listed in the PR soon, and the first of these will be to remove all calls to doPrivileged. My plan is to file an umbrella task with separate bugs for each module that can then be split and done in parallel by different developers. -- Kevin On 10/9/2024 5:1

Withdrawn: 8337656 iOS WebView Position

2024-10-10 Thread duke
On Thu, 1 Aug 2024 11:40:06 GMT, Florian Kirmaier wrote: > Fixing WebView on iOS > (I couldn't compile it because I don't know how to build it for iOS, but the > code should be correct.) > > @johanvos > If this looks reasonable to you, can you provide a test build for > @dlemmermann ? > Then

Re: RFR: 8090456: Focus Management [v8]

2024-10-10 Thread Michael Strauß
On Thu, 10 Oct 2024 00:12:54 GMT, Martin Fox wrote: > > My suggestion for a better API is: have two separate knobs to configure > > directional and logical focus traversal, and provide a very small set of > > curated policies. We should only consider opening up the API to allow more > > custom