On Thu, 10 Oct 2024 17:52:29 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
> - fixed the issue > - added unit tests > - clarified default value of `ScrollPane.fitWidth` and `ScrollPane.fitHeight` > properties > > No CSR is needed as it is a minor clarification. Fix and test both look good. I confirm that the newly added test and the program attached to the JBS issue pass with the fix and faill without it. Not sure why you modified the docs, though. It seems unrelated. modules/javafx.controls/src/main/java/javafx/scene/control/ScrollPane.java line 358: > 356: * contained node is not a Resizable, this value is ignored. > 357: * > 358: * @defaultValue false This is unrelated to the fix, and you were otherwise not touching this file. Why change it? ------------- PR Review: https://git.openjdk.org/jfx/pull/1597#pullrequestreview-2361555920 PR Review Comment: https://git.openjdk.org/jfx/pull/1597#discussion_r1796189703
