On Thu, 10 Oct 2024 22:51:20 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> - fixed the issue >> - added unit tests >> - clarified default value of `ScrollPane.fitWidth` and >> `ScrollPane.fitHeight` properties >> >> No CSR is needed as it is a minor clarification. > > modules/javafx.controls/src/main/java/javafx/scene/control/ScrollPane.java > line 358: > >> 356: * contained node is not a Resizable, this value is ignored. >> 357: * >> 358: * @defaultValue false > > This is unrelated to the fix, and you were otherwise not touching this file. > Why change it? it is related to the fix, may be we differ in the _degree_ of relation. I did not want to create a separate ticket for such a minor clarification... but maybe I should, and fix all the missing `@defaultValue`s across the controls. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1597#discussion_r1796194948
