Re: RFR: 8332895: Support interpolation for backgrounds and borders [v40]

2024-09-24 Thread Michael Strauß
> This PR completes the CSS Transitions story (see #870) by adding > interpolation support for backgrounds and borders, making them targetable by > transitions. > > `Background` and `Border` objects are deeply immutable, but not > interpolatable. Consider the following `Background`, which descr

Re: [External] : Re: Proposal: Focus Traversal API

2024-09-24 Thread John Hendrikx
On 24/09/2024 22:29, Martin Fox wrote: This proposal should give some quick background on how traversal key events are handled, specifically that controls should let the key events bubble up to the Scene to invoke traversal. And if the traversal keys are always going to be consumed by the Sce

Re: [External] : Re: Proposal: Focus Traversal API

2024-09-24 Thread Martin Fox
Andy, Glad to finally see a proposal for opening up traversal. Long overdue. There’s a case in the current control set that this API doesn’t cover. ToggleButtons intercept the arrow keys so they can implement a cyclic traversal policy among buttons in the ToggleGroup. They don’t assume that the

Re: RFR: 8090456: Focus Management [v4]

2024-09-24 Thread Andy Goryachev
> Public APIs for focus traversal and the focus traversal policy: > > https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal.md > > This work is loosely based on the patch > https://cr.openjdk.org/~jgiles/8061673/ Andy Goryachev has updated the pull request inc

Re: RFR: 8090456: Focus Management [v3]

2024-09-24 Thread Andy Goryachev
> Public APIs for focus traversal and the focus traversal policy: > > https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal.md > > This work is loosely based on the patch > https://cr.openjdk.org/~jgiles/8061673/ Andy Goryachev has updated the pull request wit

Re: RFR: 8301121: RichTextArea Control (Incubator) [v13]

2024-09-24 Thread Andy Goryachev
> Incubating a new feature - rich text control, **RichTextArea**, intended to > bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The > main design goal is to provide a control that is complete enough to be useful > out-of-the box, as well as open to extension by the appl

Withdrawn: 8314683: TextArea: scroll bar size and content padding

2024-09-24 Thread Andy Goryachev
On Fri, 31 May 2024 21:50:08 GMT, Andy Goryachev wrote: > Changing certain ScrollBar, ScrollPane, and TextArea sizes from `em` to `px` > in modena.css to make them independent of the font size *in that control*. > > After the change, the UI still looks good which can be tested by scaling > def

Re: How navigation currently works in FX, and an enhancement proposal

2024-09-24 Thread Andy Goryachev
Chuck: Does it mean you agree in principle with necessity for adding focus traversal methods and ability to install custom traversal policy? Do you think APIs described in the proposal are sufficient to implement the requirements in your app(s)? -andy From: openjfx-dev on behalf of Chuck D

Re: [External] : Re: Proposal: Focus Traversal API

2024-09-24 Thread Andy Goryachev
I fully agree with Martin here. -andy From: Martin Fox Date: Wednesday, September 18, 2024 at 11:49 To: John Hendrikx Cc: Andy Goryachev , OpenJFX Subject: Re: [External] : Re: Proposal: Focus Traversal API John, Sorry I didn’t respond to this thread earlier. I’ve been looking at the code a

Re: [External] : Re: Proposal: Focus Traversal API

2024-09-24 Thread Andy Goryachev
Dear John: Now with the test sprint over, let me try to respond to your earlier questions (sorry for the delay!). > What is the point of TraversalEvent.NODE_TRAVERSED? My understanding it's an alternative to adding a TraversalEngine.TraverseListener in the original implementation. The main purp

Re: RFR: 8337280: Include jdk.jsobject module with JavaFX [v3]

2024-09-24 Thread Kevin Rushforth
> Add the `jdk.jsobject` module to JavaFX. This module is currently delivered > by the JDK, but will be terminally-deprecated in JDK 24 by > [JDK-8311530](https://bugs.openjdk.org/browse/JDK-8311530), which is out for > review at openjdk/jdk#20555. We therefore plan to start delivering it with

[jfx23u] Integrated: 8340208: Additional WebKit 619.1 fixes from WebKitGTK 2.44.4

2024-09-24 Thread Hima Bindu Meda
On Tue, 24 Sep 2024 17:11:55 GMT, Hima Bindu Meda wrote: > Clean Backport This pull request has now been integrated. Changeset: fa41f904 Author:Hima Bindu Meda URL: https://git.openjdk.org/jfx23u/commit/fa41f904fc9e0034d3af4d7b4b4cc5d7ddde3300 Stats: 596 lines in 103 files chang

[jfx23u] RFR: 8340208: Additional WebKit 619.1 fixes from WebKitGTK 2.44.4

2024-09-24 Thread Hima Bindu Meda
Clean Backport - Commit messages: - Backport bc5adfa9b6f9180eb32930f61e59fdc46a83cb73 Changes: https://git.openjdk.org/jfx23u/pull/22/files Webrev: https://webrevs.openjdk.org/?repo=jfx23u&pr=22&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340208 Stats: 596 lines in 10

Re: Possible leak on prism es2

2024-09-24 Thread Thiago Milczarek Sayão
I might be mistaken, but it seems deleteDrawableInfo is never called. I think it should be called when the platform View is replaced or when the window is closed. Github search for deleteDrawableInfo https://github.com/search?q=repo%3Aopenjdk%2Fjfx%20deleteDrawableInfo&type=code Em ter., 24 de s

Integrated: 8328629: JUnit test without a timeout value can hang indefinitely

2024-09-24 Thread Kevin Rushforth
On Thu, 19 Sep 2024 14:15:23 GMT, Kevin Rushforth wrote: > This PR adds a default timeout of 120 seconds for JUnit 5 tests that do not > have an explicit `@Timeout` on either the methods or the class, and a default > timeout of 20 seconds for lifecycle methods (e.g., `@BeforeEach`, > `@BeforeA

Re: RFR: 8328629: JUnit test without a timeout value can hang indefinitely [v4]

2024-09-24 Thread Andy Goryachev
On Tue, 24 Sep 2024 16:34:21 GMT, Kevin Rushforth wrote: >> This PR adds a default timeout of 120 seconds for JUnit 5 tests that do not >> have an explicit `@Timeout` on either the methods or the class, and a >> default timeout of 20 seconds for lifecycle methods (e.g., `@BeforeEach`, >> `@Bef

Re: RFR: 8328629: JUnit test without a timeout value can hang indefinitely [v3]

2024-09-24 Thread Kevin Rushforth
On Tue, 24 Sep 2024 15:47:12 GMT, Andy Goryachev wrote: >> Kevin Rushforth has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> co

Re: RFR: 8328629: JUnit test without a timeout value can hang indefinitely [v4]

2024-09-24 Thread Kevin Rushforth
> This PR adds a default timeout of 120 seconds for JUnit 5 tests that do not > have an explicit `@Timeout` on either the methods or the class, and a default > timeout of 20 seconds for lifecycle methods (e.g., `@BeforeEach`, > `@BeforeAll`, `@AfterEach`, `@AfterAll`). > > JUnit 5 effects its t

Re: RFR: 8328629: JUnit test without a timeout value can hang indefinitely [v3]

2024-09-24 Thread Andy Goryachev
On Tue, 24 Sep 2024 15:31:02 GMT, Kevin Rushforth wrote: >> This PR adds a default timeout of 120 seconds for JUnit 5 tests that do not >> have an explicit `@Timeout` on either the methods or the class, and a >> default timeout of 20 seconds for lifecycle methods (e.g., `@BeforeEach`, >> `@Bef

Re: RFR: 8328629: JUnit test without a timeout value can hang indefinitely [v3]

2024-09-24 Thread Andy Goryachev
On Tue, 24 Sep 2024 15:31:02 GMT, Kevin Rushforth wrote: >> This PR adds a default timeout of 120 seconds for JUnit 5 tests that do not >> have an explicit `@Timeout` on either the methods or the class, and a >> default timeout of 20 seconds for lifecycle methods (e.g., `@BeforeEach`, >> `@Bef

Re: RFR: 8328629: JUnit test without a timeout value can hang indefinitely [v3]

2024-09-24 Thread Kevin Rushforth
> This PR adds a default timeout of 120 seconds for JUnit 5 tests that do not > have an explicit `@Timeout` on either the methods or the class, and a default > timeout of 20 seconds for lifecycle methods (e.g., `@BeforeEach`, > `@BeforeAll`, `@AfterEach`, `@AfterAll`). > > JUnit 5 effects its t

Re: RFR: 8328629: JUnit test without a timeout value can hang indefinitely [v2]

2024-09-24 Thread Kevin Rushforth
On Tue, 24 Sep 2024 14:27:16 GMT, Andy Goryachev wrote: > #1569 has been integrated, we can make the final changes Done. - PR Comment: https://git.openjdk.org/jfx/pull/1575#issuecomment-2371627170

Re: Dead keys followed by space

2024-09-24 Thread Thiago Milczarek Sayão
Hi Johan, It might vary be platform. Which one are you using? (Windows, Mac, Linux). Try disabling IME (Input Method Editor) and see it it works. - Thiago Em ter., 24 de set. de 2024 11:51, Johan Corveleyn escreveu: > Hi, > > (This is my first post here, hope I'm following the right path) > >

Dead keys followed by space

2024-09-24 Thread Johan Corveleyn
Hi, (This is my first post here, hope I'm following the right path) It seems JavaFX TextFields (and friends) do not automatically convert + into simply . They make it into +, which is very atypical. I would consider this behavior a bug, since it is different from any editor I know (and makes it v

[jfx23u] Integrated: Merge jfx:jfx23

2024-09-24 Thread Kevin Rushforth
On Tue, 24 Sep 2024 13:29:24 GMT, Kevin Rushforth wrote: > Clean merge from `jfx:jfx23` to `master` (final sync to pick up release > notes). This pull request has now been integrated. Changeset: dba5b200 Author:Kevin Rushforth URL: https://git.openjdk.org/jfx23u/commit/dba5b20034ae

Re: [jfx23u] RFR: Merge jfx:jfx23 [v2]

2024-09-24 Thread Kevin Rushforth
> Clean merge from `jfx:jfx23` to `master` (final sync to pick up release > notes). Kevin Rushforth has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 21

Re: RFR: 8328629: JUnit test without a timeout value can hang indefinitely [v2]

2024-09-24 Thread Andy Goryachev
On Fri, 20 Sep 2024 18:21:04 GMT, Kevin Rushforth wrote: >> This PR adds a default timeout of 120 seconds for JUnit 5 tests that do not >> have an explicit `@Timeout` on either the methods or the class, and a >> default timeout of 20 seconds for lifecycle methods (e.g., `@BeforeEach`, >> `@Bef

Integrated: 8339510: [TestBug] Convert system tests to JUnit 5

2024-09-24 Thread Andy Goryachev
On Mon, 16 Sep 2024 17:57:07 GMT, Andy Goryachev wrote: > Converting system tests to junit5. > > Please see migration notes: > https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md > > ### Notes: > > I see shutdown timeout on linux, this will be addressed by > [

[jfx23u] RFR: Merge jfx:jfx23

2024-09-24 Thread Kevin Rushforth
Clean merge from `jfx:jfx23` to `master` (final sync to pick up release notes). - Commit messages: - Merge remote-tracking branch 'jfx/jfx23' into merge-jfx-jfx23-to-master-2024-09-24 - 8339247: Create release notes for JavaFX 23 The merge commit only contains trivial merges, so n

Re: RFR: 8297072: Provide gradle option to test a previously built SDK [v2]

2024-09-24 Thread Kevin Rushforth
On Tue, 24 Sep 2024 06:19:13 GMT, Ambarish Rapte wrote: >> Requirement: >> We want to be able to test a JavaFX SDK built somewhere else other than on >> current machine or current repo on same machine. Which means we should be >> able to run the unit and system tests with a different JavaF

Possible leak on prism es2

2024-09-24 Thread Thiago Milczarek Sayão
Hi, While doing some work on replacing GLX with EGL I discovered a possible leak. Running this test: gradle -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests SetSceneScalingTest will result in X11GLDrawable -> nCreateDrawable to be called multiple times on the same test, while GLDrawa

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v25]

2024-09-24 Thread Thiago Milczarek Sayao
On Wed, 21 Aug 2024 09:58:53 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> positioning on `InputMethodRequest`. >>

Re: RFR: 8339510: [TestBug] Convert system tests to JUnit 5 [v6]

2024-09-24 Thread Lukasz Kostyra
On Mon, 23 Sep 2024 18:38:23 GMT, Andy Goryachev wrote: >> Converting system tests to junit5. >> >> Please see migration notes: >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md >> >> ### Notes: >> >> I see shutdown timeout on linux, this will be addressed

Re: RFR: 8328629: JUnit test without a timeout value can hang indefinitely [v2]

2024-09-24 Thread Marius Hanl
On Fri, 20 Sep 2024 18:21:04 GMT, Kevin Rushforth wrote: >> This PR adds a default timeout of 120 seconds for JUnit 5 tests that do not >> have an explicit `@Timeout` on either the methods or the class, and a >> default timeout of 20 seconds for lifecycle methods (e.g., `@BeforeEach`, >> `@Bef