On Tue, 24 Sep 2024 15:47:12 GMT, Andy Goryachev <[email protected]> wrote:
>> Kevin Rushforth has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - throw new AssertionError(ex) --> fail(ex)
>> - Merge remote-tracking branch 'upstream/master' into 8328629-junit-timeout
>> - Remove unused sleep method from BehaviorRobotTestBase.
>> - Fix typo (extra spaces) in system property name
>> - 8328629: JUnit test without a timeout value can hang indefinitely
>
> tests/system/src/test/java/test/javafx/scene/text/ArabicWrappingTest.java
> line 112:
>
>> 110: Thread.sleep(2000);
>> 111: } catch (Exception e) {
>> 112: fail(e);
>
> something wrong with indent?
Good catch. I'll fix.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1575#discussion_r1773682420
