Re: RFR: 8301121: RichTextArea Control (Incubator) [v3]

2024-08-18 Thread Robert Lichtenberger
On Wed, 14 Aug 2024 18:33:30 GMT, Andy Goryachev wrote: >> tests/manual/RichTextAreaDemo/src/com/oracle/demo/richtext/codearea/DemoSyntaxDecorator.java >> line 54: >> >>> 52: >>> 53: @Override >>> 54: public RichParagraph createRichParagraph(CodeTextModel model, int >>> index) { >> >

Re: RFR: 8301121: RichTextArea Control (Incubator) [v3]

2024-08-18 Thread Robert Lichtenberger
On Wed, 14 Aug 2024 18:26:03 GMT, Andy Goryachev wrote: >> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/BasicTextModel.java >> line 198: >> >>> 196: */ >>> 197: public static class InMemoryContent implements Content { >>> 198: private

Re: RFR: 8337400: [Linux] Initial window position is not centered on Ubuntu 24.04 / Xorg

2024-08-18 Thread Thiago Milczarek Sayao
On Fri, 16 Aug 2024 20:28:20 GMT, Kevin Rushforth wrote: > This causes a regression on Ubuntu 22.04. The following tests fail with this > fix (they all pass with current master), when using X.org or Wayland: > > ``` > SizeToSceneTest > testInitialSizeOnFullscreenThenSizeToScene() FAILED > o

Re: RFR: 8337400: [Linux] Initial window position is not centered on Ubuntu 24.04 / Xorg

2024-08-18 Thread Thiago Milczarek Sayao
On Mon, 29 Jul 2024 17:46:52 GMT, Thiago Milczarek Sayao wrote: > On Ubuntu 24.04 with Xorg windows are not shown centered. > > This is due a configure event being received with position 0,0 which is wrong. > > The fix ignores the configure events until the window is mapped. The problem is a

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v22]

2024-08-18 Thread Martin Fox
On Sun, 18 Aug 2024 20:10:09 GMT, Thiago Milczarek Sayao wrote: >> modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkView.java line >> 123: >> >>> 121: if (w != null) { >>> 122: pos[0] -= (pos[0] > 0) ? ((w.getX() + getX())) : 0; >>> 123: pos[1] -= (

Re: [jfx17u] RFR: 8334657: Enable binary check

2024-08-18 Thread Jose Pereda
On Sun, 18 Aug 2024 20:37:23 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit 101e5175 from the openjdk/jfx > repository. > > The commit being backported was authored by Kevin Rushforth on 25 Jun 2024 > and was reviewed by Ambarish Rapte and Phil Race. > >

Re: [jfx21u] RFR: 8334657: Enable binary check

2024-08-18 Thread Jose Pereda
On Sun, 18 Aug 2024 20:46:48 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit 101e5175 from the openjdk/jfx > repository. > > The commit being backported was authored by Kevin Rushforth on 25 Jun 2024 > and was reviewed by Ambarish Rapte and Phil Race. > >

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v24]

2024-08-18 Thread Thiago Milczarek Sayao
> This replaces obsolete XIM and uses gtk api for IME. > Gtk uses [ibus](https://github.com/ibus/ibus) > > Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative > positioning on `InputMethodRequest`. > > [Screencast from 17-09-2023 > 21:59:04.webm](https://github.com/openj

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v22]

2024-08-18 Thread Thiago Milczarek Sayao
On Fri, 16 Aug 2024 15:48:00 GMT, Martin Fox wrote: >> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains 96 commits: >> >> - Merge branch 'refs/heads/master' into new_ime >> - Merge branch 'refs/heads/master

[jfx21u] RFR: 8334657: Enable binary check

2024-08-18 Thread Johan Vos
Hi all, This pull request contains a backport of commit 101e5175 from the openjdk/jfx repository. The commit being backported was authored by Kevin Rushforth on 25 Jun 2024 and was reviewed by Ambarish Rapte and Phil Race. Thanks! - Commit messages: - Backport 101e5175ff429828de

[jfx23u] RFR: 8319779: SystemMenu: memory leak due to listener never being removed

2024-08-18 Thread Johan Vos
Hi all, This pull request contains a backport of commit 25ac6fed from the openjdk/jfx repository. The commit being backported was authored by Johan Vos on 25 Jul 2024 and was reviewed by John Hendrikx, Ambarish Rapte and Jose Pereda. Thanks! - Commit messages: - Backport 25ac6fe

[jfx17u] RFR: 8334657: Enable binary check

2024-08-18 Thread Johan Vos
Hi all, This pull request contains a backport of commit 101e5175 from the openjdk/jfx repository. The commit being backported was authored by Kevin Rushforth on 25 Jun 2024 and was reviewed by Ambarish Rapte and Phil Race. Thanks! - Commit messages: - Backport 101e5175ff429828de

[jfx23u] RFR: 8334874: Horizontal scroll events from touch pads should scroll the TabPane tabs

2024-08-18 Thread Johan Vos
Hi all, This pull request contains a backport of commit [1bdb93c7](https://github.com/openjdk/jfx/commit/1bdb93c792cf7c218c74ec5cacda8bac1242f73b) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The commit being backported was authored by Jose Pereda on 25 Jul 2024 and was revi

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v23]

2024-08-18 Thread Thiago Milczarek Sayao
> This replaces obsolete XIM and uses gtk api for IME. > Gtk uses [ibus](https://github.com/ibus/ibus) > > Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative > positioning on `InputMethodRequest`. > > [Screencast from 17-09-2023 > 21:59:04.webm](https://github.com/openj

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v22]

2024-08-18 Thread Thiago Milczarek Sayao
On Fri, 16 Aug 2024 15:54:30 GMT, Martin Fox wrote: >> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains 96 commits: >> >> - Merge branch 'refs/heads/master' into new_ime >> - Merge branch 'refs/heads/master

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v22]

2024-08-18 Thread Thiago Milczarek Sayao
On Fri, 16 Aug 2024 15:41:44 GMT, Martin Fox wrote: >> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains 96 commits: >> >> - Merge branch 'refs/heads/master' into new_ime >> - Merge branch 'refs/heads/master