On Fri, 16 Aug 2024 15:41:44 GMT, Martin Fox <m...@openjdk.org> wrote:
>> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains 96 commits: >> >> - Merge branch 'refs/heads/master' into new_ime >> - Merge branch 'refs/heads/master' into new_ime >> - Merge branch 'master' into new_ime >> - Add signals to avoid warnings >> - Merge branch 'master' into new_ime >> >> # Conflicts: >> # modules/javafx.graphics/src/main/native-glass/gtk/GlassApplication.cpp >> - Add check for jview >> - - Fix comment path >> - - Fix double keyrelease >> - - Use a work-around to relative positioning (until wayland is not >> officially supported) >> - Unref pango attr list >> - Merge branch 'master' into new_ime >> - ... and 86 more: https://git.openjdk.org/jfx/compare/c8b96e4e...d6230dec > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkView.java line > 123: > >> 121: if (w != null) { >> 122: pos[0] -= (pos[0] > 0) ? ((w.getX() + getX())) : 0; >> 123: pos[1] -= (pos[1] > 0) ? ((w.getY() + getY())) : 0; > > This code will only adjust a position coordinate if it's positive. I can't > easily test a dual-display Linux system but I'm pretty sure X or Y can be > negative on a secondary display to the left or above the primary display. I > think the conditional checks should be removed (but would appreciate a second > opinion on this). > > By the way, I test on a Retina display at 200% scaling and the IM positioning > is working as expected. I tested on both XWayland and Xorg. They are never negative. The input method window did always pop up on the right place.   ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1080#discussion_r1721048492
