On Fri, 16 Aug 2024 15:54:30 GMT, Martin Fox <m...@openjdk.org> wrote:
>> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains 96 commits: >> >> - Merge branch 'refs/heads/master' into new_ime >> - Merge branch 'refs/heads/master' into new_ime >> - Merge branch 'master' into new_ime >> - Add signals to avoid warnings >> - Merge branch 'master' into new_ime >> >> # Conflicts: >> # modules/javafx.graphics/src/main/native-glass/gtk/GlassApplication.cpp >> - Add check for jview >> - - Fix comment path >> - - Fix double keyrelease >> - - Use a work-around to relative positioning (until wayland is not >> officially supported) >> - Unref pango attr list >> - Merge branch 'master' into new_ime >> - ... and 86 more: https://git.openjdk.org/jfx/compare/c8b96e4e...d6230dec > > modules/javafx.graphics/src/main/native-glass/gtk/glass_window_ime.cpp line > 110: > >> 108: slen, >> 109: slen, >> 110: NULL); > > This call is expecting a byte integer so you should be passing in 0 instead > of NULL. Fixed ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1080#discussion_r1721051923
