On Thu, 8 Aug 2024 12:35:59 GMT, Lukasz Kostyra wrote:
> When fixing [JDK-8233955](https://bugs.openjdk.org/browse/JDK-8233955) offset
> calculation was left out, which made Dragboard offset API not work on macOS.
>
> This change fixes this mistake. Now drag image should be properly offset.
Th
On Mon, 12 Aug 2024 18:04:47 GMT, Kevin Rushforth wrote:
>> buildSrc/genVSproperties.bat line 52:
>>
>>> 50: for %%a in (2022, 2019, 2017) do (
>>> 51: set year=%%a
>>> 52: for %%b in (Enterprise, Professional, Community) do (
>>
>> Quick two cents from me on this part - Mic
On Mon, 12 Aug 2024 23:15:58 GMT, Kevin Rushforth wrote:
> I see one minor difference between the upstream and your PR in a commented
> out line of code in `sysv_intel.S`. I don't know whether it is significant (I
> guess not, as long as it compiles with the current inline comment style).
>
>
On Mon, 12 Aug 2024 17:13:51 GMT, Lukasz Kostyra wrote:
>> When fixing [JDK-8233955](https://bugs.openjdk.org/browse/JDK-8233955)
>> offset calculation was left out, which made Dragboard offset API not work on
>> macOS.
>>
>> This change fixes this mistake. Now drag image should be properly of
On Wed, 7 Aug 2024 00:26:13 GMT, Alexander Matveev wrote:
> - libFFI updated to 3.4.6.
> - No additional changes are done.
> - Tested on Windows, macOS and Linux with all supported formats.
I see one minor difference between the upstream and your PR in a commented out
line of code in `sysv_inte
On Mon, 12 Aug 2024 22:38:32 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/native-glass/mac/GlassViewDelegate.m line
>> 1053:
>>
>>> 1051: float imageH = [image size].height;
>>> 1052:
>>> 1053: if (offset.x < 0.0f) {
>>
>> I am puzzled a bit:
On Mon, 12 Aug 2024 17:13:51 GMT, Lukasz Kostyra wrote:
>> When fixing [JDK-8233955](https://bugs.openjdk.org/browse/JDK-8233955)
>> offset calculation was left out, which made Dragboard offset API not work on
>> macOS.
>>
>> This change fixes this mistake. Now drag image should be properly of
On Wed, 7 Aug 2024 00:26:13 GMT, Alexander Matveev wrote:
> - libFFI updated to 3.4.6.
> - No additional changes are done.
> - Tested on Windows, macOS and Linux with all supported formats.
@tiainen Do you want to be the second reviewer?
-
PR Comment: https://git.openjdk.org/jfx/pu
On Mon, 12 Aug 2024 17:13:51 GMT, Lukasz Kostyra wrote:
>> When fixing [JDK-8233955](https://bugs.openjdk.org/browse/JDK-8233955)
>> offset calculation was left out, which made Dragboard offset API not work on
>> macOS.
>>
>> This change fixes this mistake. Now drag image should be properly of
On Mon, 12 Aug 2024 21:58:51 GMT, Andy Goryachev wrote:
>> Lukasz Kostyra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Merge two if image != nil statements together
>>
>> Those were unnecessarily split
>
> modules/javafx.graphics
On Mon, 12 Aug 2024 17:13:51 GMT, Lukasz Kostyra wrote:
>> When fixing [JDK-8233955](https://bugs.openjdk.org/browse/JDK-8233955)
>> offset calculation was left out, which made Dragboard offset API not work on
>> macOS.
>>
>> This change fixes this mistake. Now drag image should be properly of
On Mon, 12 Aug 2024 21:31:49 GMT, Kevin Rushforth wrote:
>> 1. Added logic to look in the standard locations for Visual Studio 2022,
>> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in
>> the following locations:
>>
>> C:("Program Files"|"Program Files (x86)")\Micros
On Mon, 12 Aug 2024 20:31:37 GMT, Phil Race wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert "Add debug prints"
>>
>> This reverts commit 3ea8ee58867d21e5c0aeb6a22170cdc28dd7a486.
>
> buildSrc/genVSpr
On Mon, 12 Aug 2024 20:41:13 GMT, Phil Race wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments
>
> buildSrc/win.gradle line 93:
>
>> 91: defineProperty("WINDOWS_VS_LIB", properties,
>> "$W
> 1. Added logic to look in the standard locations for Visual Studio 2022, with
> a fallback to 2019 and then 2017 if 2022 is not found. It will look in the
> following locations:
>
> C:("Program Files"|"Program Files (x86)")\Microsoft Visual
> Studio(2022|2019|2017)\
> (Enterprise|Profess
On Mon, 12 Aug 2024 17:13:51 GMT, Lukasz Kostyra wrote:
>> When fixing [JDK-8233955](https://bugs.openjdk.org/browse/JDK-8233955)
>> offset calculation was left out, which made Dragboard offset API not work on
>> macOS.
>>
>> This change fixes this mistake. Now drag image should be properly of
On Mon, 12 Aug 2024 17:13:51 GMT, Lukasz Kostyra wrote:
>> When fixing [JDK-8233955](https://bugs.openjdk.org/browse/JDK-8233955)
>> offset calculation was left out, which made Dragboard offset API not work on
>> macOS.
>>
>> This change fixes this mistake. Now drag image should be properly of
On Mon, 12 Aug 2024 17:13:51 GMT, Lukasz Kostyra wrote:
>> When fixing [JDK-8233955](https://bugs.openjdk.org/browse/JDK-8233955)
>> offset calculation was left out, which made Dragboard offset API not work on
>> macOS.
>>
>> This change fixes this mistake. Now drag image should be properly of
On Mon, 12 Aug 2024 17:13:51 GMT, Lukasz Kostyra wrote:
>> When fixing [JDK-8233955](https://bugs.openjdk.org/browse/JDK-8233955)
>> offset calculation was left out, which made Dragboard offset API not work on
>> macOS.
>>
>> This change fixes this mistake. Now drag image should be properly of
On Mon, 12 Aug 2024 15:37:10 GMT, Kevin Rushforth wrote:
>> 1. Added logic to look in the standard locations for Visual Studio 2022,
>> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in
>> the following locations:
>>
>> C:("Program Files"|"Program Files (x86)")\Micros
On Mon, 12 Aug 2024 19:48:11 GMT, Kevin Rushforth wrote:
> > The wiki page for building OpenJFX will also need an update.
>
> Yes. I plan to (I meant to list that in the Description, but forgot to add
> it). Thanks for the reminder.
Yes indeed, Kevin and I discussed that at some length. What i
On Mon, 12 Aug 2024 19:18:40 GMT, Nir Lisker wrote:
> The wiki page for building OpenJFX will also need an update.
Yes. I plan to (I meant to list that in the Description, but forgot to add it).
Thanks for the reminder.
-
PR Comment: https://git.openjdk.org/jfx/pull/1534#issuecomm
On Mon, 12 Aug 2024 15:37:10 GMT, Kevin Rushforth wrote:
>> 1. Added logic to look in the standard locations for Visual Studio 2022,
>> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in
>> the following locations:
>>
>> C:("Program Files"|"Program Files (x86)")\Micros
On Mon, 12 Aug 2024 17:32:10 GMT, Lukasz Kostyra wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert "Add debug prints"
>>
>> This reverts commit 3ea8ee58867d21e5c0aeb6a22170cdc28dd7a486.
>
> buildSrc/ge
On Mon, 12 Aug 2024 17:13:51 GMT, Lukasz Kostyra wrote:
>> When fixing [JDK-8233955](https://bugs.openjdk.org/browse/JDK-8233955)
>> offset calculation was left out, which made Dragboard offset API not work on
>> macOS.
>>
>> This change fixes this mistake. Now drag image should be properly of
On Mon, 12 Aug 2024 15:37:10 GMT, Kevin Rushforth wrote:
>> 1. Added logic to look in the standard locations for Visual Studio 2022,
>> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in
>> the following locations:
>>
>> C:("Program Files"|"Program Files (x86)")\Micros
On Mon, 12 Aug 2024 17:21:58 GMT, Jose Pereda wrote:
>> I wanted to chime in, thought it might be unrelated:
>>
>> In the context of a docking framework, it is impossible to disable the
>> cancel animation. We should have a way to disable it. The use case is when
>> the user drags and drops
On Mon, 12 Aug 2024 16:22:17 GMT, Andy Goryachev wrote:
>> By the way, this is how you can disable the cancel animation:
>>
>>
>> diff --git
>> a/modules/javafx.graphics/src/main/native-glass/mac/GlassDraggingSource.m
>> b/modules/javafx.graphics/src/main/native-glass/mac/GlassDraggingSource.
> When fixing [JDK-8233955](https://bugs.openjdk.org/browse/JDK-8233955) offset
> calculation was left out, which made Dragboard offset API not work on macOS.
>
> This change fixes this mistake. Now drag image should be properly offset.
Lukasz Kostyra has updated the pull request incrementally w
On Sat, 10 Aug 2024 11:53:00 GMT, John Hendrikx wrote:
>>> This is not the case. The sorting is still correct. Claiming that the
>>> sorting is invalid because a newly added item was not placed in a specific
>>> location relative to other equal items is a bit of misrepresentation.
>>>
>>> So,
On Mon, 12 Aug 2024 16:02:32 GMT, Jose Pereda wrote:
>> Right, there is a built-in native animation from the offset point to the
>> mouse cursor (in and out).
>>
>> When the drag event is cancelled, the image returns to the offset location
>> with this animation. We still want that, so I woul
On Mon, 12 Aug 2024 12:39:52 GMT, Jose Pereda wrote:
>> Out of curiosity I removed offset clamping (macOS snaps the drag image
>> regardless) and technically it still works, but when you cancel the drag the
>> image snaps back to the offset position. With high enough (or negative)
>> values dr
On Mon, 12 Aug 2024 12:58:25 GMT, Lukasz Kostyra wrote:
>> When fixing [JDK-8233955](https://bugs.openjdk.org/browse/JDK-8233955)
>> offset calculation was left out, which made Dragboard offset API not work on
>> macOS.
>>
>> This change fixes this mistake. Now drag image should be properly of
On Mon, 12 Aug 2024 15:37:10 GMT, Kevin Rushforth wrote:
>> 1. Added logic to look in the standard locations for Visual Studio 2022,
>> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in
>> the following locations:
>>
>> C:("Program Files"|"Program Files (x86)")\Micros
> 1. Added logic to look in the standard locations for Visual Studio 2022, with
> a fallback to 2019 and then 2017 if 2022 is not found. It will look in the
> following locations:
>
> C:("Program Files"|"Program Files (x86)")\Microsoft Visual
> Studio(2022|2019|2017)\
> (Enterprise|Profess
On Tue, 6 Aug 2024 08:08:09 GMT, Hima Bindu Meda wrote:
>> Updated libxslt to v1.1.42. Verified build on all platforms. No issue seen
>
> Hima Bindu Meda has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Remove deprecated file
+looks good to
On Sat, 10 Aug 2024 17:59:52 GMT, Michael Strauß wrote:
> I strongly suggest to do this as part of
> [JDK-8338121](https://bugs.openjdk.org/browse/JDK-8338121)
+1. I am fine with splitting the work in two parts. My only suggestion is to
valign the table cells to top instead of center.
-
On Mon, 12 Aug 2024 14:21:14 GMT, Kevin Rushforth wrote:
> 1. Added logic to look in the standard locations for Visual Studio 2022, with
> a fallback to 2019 and then 2017 if 2022 is not found. It will look in the
> following locations:
>
> C:("Program Files"|"Program Files (x86)")\Microsoft V
1. Added logic to look in the standard locations for Visual Studio 2022, with a
fallback to 2019 and then 2017 if 2022 is not found. It will look in the
following locations:
C:("Program Files"|"Program Files (x86)")\Microsoft Visual
Studio(2022|2019|2017)\
(Enterprise|Professional|Communit
> When fixing [JDK-8233955](https://bugs.openjdk.org/browse/JDK-8233955) offset
> calculation was left out, which made Dragboard offset API not work on macOS.
>
> This change fixes this mistake. Now drag image should be properly offset.
Lukasz Kostyra has updated the pull request incrementally w
On Tue, 6 Aug 2024 08:08:09 GMT, Hima Bindu Meda wrote:
>> Updated libxslt to v1.1.42. Verified build on all platforms. No issue seen
>
> Hima Bindu Meda has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Remove deprecated file
@jaybhaskar Ca
On Mon, 12 Aug 2024 12:14:26 GMT, Lukasz Kostyra wrote:
>> modules/javafx.graphics/src/main/native-glass/mac/GlassViewDelegate.m line
>> 1068:
>>
>>> 1066:
>>> 1067: dragPoint.x -= offset.x;
>>> 1068: dragPoint.y -= offset.y;
>>
>> This works fine now, _if_ the
On Mon, 12 Aug 2024 09:54:19 GMT, Jose Pereda wrote:
>> Lukasz Kostyra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> GlassViewDelegate: Correctly set origin and offset in dragImage
>>
>> - Centering to dragImage was removed - orig
On Fri, 9 Aug 2024 08:13:16 GMT, Lukasz Kostyra wrote:
>> When fixing [JDK-8233955](https://bugs.openjdk.org/browse/JDK-8233955)
>> offset calculation was left out, which made Dragboard offset API not work on
>> macOS.
>>
>> This change fixes this mistake. Now drag image should be properly off
44 matches
Mail list logo
