Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v22]

2024-08-06 Thread robbiezl
On Sun, 9 Jun 2024 12:56:32 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> positioning on `InputMethodRequest`. >>

Re: RFR: 8323706: Remove SimpleSelector and CompoundSelector classes [v7]

2024-08-06 Thread John Hendrikx
> Moves `SimpleSelector` and `CompoundSelector` to internal packages. > > This can be done with only a minor API break, as `SimpleSelector` and > `CompoundSelector` were public before. However, these classes could not be > constructed by 3rd parties. The only way to access them was by doing a

Re: RFR: 8323706: Remove SimpleSelector and CompoundSelector classes [v7]

2024-08-06 Thread John Hendrikx
On Tue, 6 Aug 2024 22:43:48 GMT, Andy Goryachev wrote: >> I can see if I can externalize this or if that would run into issues. Also >> please note, although technically an API change, it is NOT an accessible API >> (and so can be removed at any time) because only the permitted types can >> a

Re: RFR: 8323706: Remove SimpleSelector and CompoundSelector classes [v6]

2024-08-06 Thread John Hendrikx
> Moves `SimpleSelector` and `CompoundSelector` to internal packages. > > This can be done with only a minor API break, as `SimpleSelector` and > `CompoundSelector` were public before. However, these classes could not be > constructed by 3rd parties. The only way to access them was by doing a

Re: RFR: 8323706: Remove SimpleSelector and CompoundSelector classes [v5]

2024-08-06 Thread John Hendrikx
> Moves `SimpleSelector` and `CompoundSelector` to internal packages. > > This can be done with only a minor API break, as `SimpleSelector` and > `CompoundSelector` were public before. However, these classes could not be > constructed by 3rd parties. The only way to access them was by doing a

RFR: 8336938: Update libFFI to 3.4.6

2024-08-06 Thread Alexander Matveev
- libFFI updated to 3.4.6. - No additional changes are done. - Tested on Windows, macOS and Linux with all supported formats. - Commit messages: - Merge remote-tracking branch 'upstream/master' into JDK-8336938 - 8336938: Update libFFI to 3.4.6 Changes: https://git.openjdk.org/jfx/

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v3]

2024-08-06 Thread Michael Strauß
On Sun, 4 Aug 2024 22:55:22 GMT, John Hendrikx wrote: >> I don't quite like returning any particular value from `convertBack` as a >> signal for "this style converter doesn't support deconstruction", so I've >> made it more explicit with the marker interface >> `StyleConverter.SupportsDeconstr

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v18]

2024-08-06 Thread Michael Strauß
> This PR completes the CSS Transitions story (see #870) by adding > interpolation support for backgrounds and borders, making them targetable by > transitions. > > `Background` and `Border` objects are deeply immutable, but not > interpolatable. Consider the following `Background`, which descr

Re: RFR: 8323706: Remove SimpleSelector and CompoundSelector classes [v4]

2024-08-06 Thread Andy Goryachev
On Tue, 9 Jul 2024 17:58:30 GMT, John Hendrikx wrote: >> it looks to me readBinary should be static, and writeBinary an instance >> method - this is a normal pattern. the asymmetry is dictated by the fact >> that we don't have an instance when reading, so typically read() methods >> read the

[jfx23u] Integrated: 8336277: Colors are incorrect when playing H.265/HEVC on Windows 11

2024-08-06 Thread Alexander Matveev
On Tue, 6 Aug 2024 20:52:26 GMT, Alexander Matveev wrote: > - Clean backport of JDK-8336277. This pull request has now been integrated. Changeset: d0c5cd42 Author:Alexander Matveev URL: https://git.openjdk.org/jfx23u/commit/d0c5cd42d46be7773e5872dca0ceb442354755dd Stats: 628 lin

[jfx23u] RFR: 8336277: Colors are incorrect when playing H.265/HEVC on Windows 11

2024-08-06 Thread Alexander Matveev
- Clean backport of JDK-8336277. - Commit messages: - Backport 635a09c7855351eac8001b60e240c826db3a6bff Changes: https://git.openjdk.org/jfx23u/pull/7/files Webrev: https://webrevs.openjdk.org/?repo=jfx23u&pr=7&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336277 Stats:

Integrated: 8336277: Colors are incorrect when playing H.265/HEVC on Windows 11

2024-08-06 Thread Alexander Matveev
On Wed, 31 Jul 2024 03:45:20 GMT, Alexander Matveev wrote: > - For some reason H.265 decoder on Windows accepts proposed media format > without error, but does not actually change output format. > - For 8-bit we proposed IYUV, but decoder outputs NV12. For 10-bit we > proposed NV12, but decode

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v17]

2024-08-06 Thread Michael Strauß
> This PR completes the CSS Transitions story (see #870) by adding > interpolation support for backgrounds and borders, making them targetable by > transitions. > > `Background` and `Border` objects are deeply immutable, but not > interpolatable. Consider the following `Background`, which descr

Re: RFR: 8336277: Colors are incorrect when playing H.265/HEVC on Windows 11

2024-08-06 Thread Andy Goryachev
On Wed, 31 Jul 2024 03:45:20 GMT, Alexander Matveev wrote: > - For some reason H.265 decoder on Windows accepts proposed media format > without error, but does not actually change output format. > - For 8-bit we proposed IYUV, but decoder outputs NV12. For 10-bit we > proposed NV12, but decode

Re: RFR: 8336277: Colors are incorrect when playing H.265/HEVC on Windows 11

2024-08-06 Thread Andy Goryachev
On Wed, 31 Jul 2024 03:45:20 GMT, Alexander Matveev wrote: > - For some reason H.265 decoder on Windows accepts proposed media format > without error, but does not actually change output format. > - For 8-bit we proposed IYUV, but decoder outputs NV12. For 10-bit we > proposed NV12, but decode

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v16]

2024-08-06 Thread Andy Goryachev
On Sun, 4 Aug 2024 19:08:14 GMT, Michael Strauß wrote: >> This PR completes the CSS Transitions story (see #870) by adding >> interpolation support for backgrounds and borders, making them targetable by >> transitions. >> >> `Background` and `Border` objects are deeply immutable, but not >> i

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v3]

2024-08-06 Thread Andy Goryachev
On Sun, 4 Aug 2024 22:51:33 GMT, John Hendrikx wrote: >> I don't understand this argument at all. Why would it be reasonable to >> _only_ build a more efficient architecture _if_ there's such a huge problem >> with the "naive" alternative that this alone would be readily apparent? If >> taken

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v3]

2024-08-06 Thread Andy Goryachev
On Fri, 2 Aug 2024 21:24:21 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - fix since tag >> - adjust table styling > > modules/javafx.graphics/src/main/java/com/sun/javafx/util/Utils.java l

Re: RFR: 8336277: Colors are incorrect when playing H.265/HEVC on Windows 11

2024-08-06 Thread Kevin Rushforth
On Wed, 31 Jul 2024 03:45:20 GMT, Alexander Matveev wrote: > - For some reason H.265 decoder on Windows accepts proposed media format > without error, but does not actually change output format. > - For 8-bit we proposed IYUV, but decoder outputs NV12. For 10-bit we > proposed NV12, but decode

Re: RFR: 8336277: Colors are incorrect when playing H.265/HEVC on Windows 11

2024-08-06 Thread Kevin Rushforth
On Tue, 6 Aug 2024 17:37:16 GMT, Andy Goryachev wrote: > on my windows 11, I hear the audio but see no video (with this PR). am I > missing any codecs? It should show the video as well. The expected behavior is that the video is shown with incorrect colors without this fix and shown with corre

Re: RFR: 8336277: Colors are incorrect when playing H.265/HEVC on Windows 11

2024-08-06 Thread Andy Goryachev
On Wed, 31 Jul 2024 03:45:20 GMT, Alexander Matveev wrote: > - For some reason H.265 decoder on Windows accepts proposed media format > without error, but does not actually change output format. > - For 8-bit we proposed IYUV, but decoder outputs NV12. For 10-bit we > proposed NV12, but decode

Re: RFR: 8336277: Colors are incorrect when playing H.265/HEVC on Windows 11

2024-08-06 Thread Andy Goryachev
On Wed, 31 Jul 2024 03:45:20 GMT, Alexander Matveev wrote: > - For some reason H.265 decoder on Windows accepts proposed media format > without error, but does not actually change output format. > - For 8-bit we proposed IYUV, but decoder outputs NV12. For 10-bit we > proposed NV12, but decode

Re: RFR: 8336031: Create implementation of NSAccessibilityStaticText protocol [v3]

2024-08-06 Thread Andy Goryachev
On Tue, 6 Aug 2024 15:41:32 GMT, Kevin Rushforth wrote: > Can you run the same tests with mainline Items 1-3 can be seen with mainline, so these might be (new) issues. Item 4 seems to have been introduced by this PR - don't see the issue with the master branch. Also, notice that we don't get

Re: RFR: 8336031: Create implementation of NSAccessibilityStaticText protocol [v3]

2024-08-06 Thread Kevin Rushforth
On Tue, 6 Aug 2024 15:02:48 GMT, Andy Goryachev wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Removing methods that supposed to generate attributed strings. String >> attributes are not available for the stati

Re: RFR: 8336031: Create implementation of NSAccessibilityStaticText protocol [v3]

2024-08-06 Thread Andy Goryachev
On Thu, 1 Aug 2024 22:41:05 GMT, Alexander Zuev wrote: >> Initial implementation of the protocol. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Removing methods that supposed to generate attributed strings. String > at

Re: RFR: 8301121: RichTextArea Control (Incubator)

2024-08-06 Thread Andy Goryachev
On Tue, 6 Aug 2024 11:47:23 GMT, Ajit Ghaisas wrote: >> Incubating a new feature - rich text control, **RichTextArea**, intended to >> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. >> The main design goal is to provide a control that is complete enough to be >> usef

Re: RFR: 8301121: RichTextArea Control (Incubator)

2024-08-06 Thread Ajit Ghaisas
On Tue, 30 Jul 2024 21:01:15 GMT, Andy Goryachev wrote: > Incubating a new feature - rich text control, **RichTextArea**, intended to > bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The > main design goal is to provide a control that is complete enough to be useful

Integrated: 8332222: Linux Debian: Maximized stage shrinks when opening another stage

2024-08-06 Thread Thiago Milczarek Sayao
On Wed, 22 May 2024 21:28:47 GMT, Thiago Milczarek Sayao wrote: > Specific to KDE, in the case of the example provided, when an MODAL window > pops, it calls `set_enabled` `false` on the child (or all other windows if > APPLICATION_MODAL) which causes it to update the window constraints. When

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v5]

2024-08-06 Thread Kevin Rushforth
On Tue, 6 Aug 2024 13:03:15 GMT, Thiago Milczarek Sayao wrote: > Is it ok to integrate? I got the e-mail saying so, but not really sure. Yes. There are two approving reviews, and no outstanding comments or questions. - PR Comment: https://git.openjdk.org/jfx/pull/1460#issuecomment

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v5]

2024-08-06 Thread Thiago Milczarek Sayao
On Mon, 29 Jul 2024 14:29:17 GMT, Thiago Milczarek Sayao wrote: >> Specific to KDE, in the case of the example provided, when an MODAL window >> pops, it calls `set_enabled` `false` on the child (or all other windows if >> APPLICATION_MODAL) which causes it to update the window constraints. Wh

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v5]

2024-08-06 Thread Lukasz Kostyra
On Mon, 29 Jul 2024 14:29:17 GMT, Thiago Milczarek Sayao wrote: >> Specific to KDE, in the case of the example provided, when an MODAL window >> pops, it calls `set_enabled` `false` on the child (or all other windows if >> APPLICATION_MODAL) which causes it to update the window constraints. Wh

Re: RFR: 8336941 : Update libxslt to 1.1.42 [v2]

2024-08-06 Thread Kevin Rushforth
On Tue, 6 Aug 2024 08:08:09 GMT, Hima Bindu Meda wrote: >> Updated libxslt to v1.1.42. Verified build on all platforms. No issue seen > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > Remove deprecated file Marked as revi

Re: RFR: 8336941 : Update libxslt to 1.1.42 [v2]

2024-08-06 Thread Clearvision92
On Tue, 6 Aug 2024 08:08:09 GMT, Hima Bindu Meda wrote: >> Updated libxslt to v1.1.42. Verified build on all platforms. No issue seen > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > Remove deprecated file Help me downlo

Re: RFR: 8336277: Colors are incorrect when playing H.265/HEVC on Windows 11

2024-08-06 Thread Ambarish Rapte
On Wed, 31 Jul 2024 03:45:20 GMT, Alexander Matveev wrote: > - For some reason H.265 decoder on Windows accepts proposed media format > without error, but does not actually change output format. > - For 8-bit we proposed IYUV, but decoder outputs NV12. For 10-bit we > proposed NV12, but decode

Re: RFR: 8336941 : Update libxslt to 1.1.42 [v2]

2024-08-06 Thread Hima Bindu Meda
> Updated libxslt to v1.1.42. Verified build on all platforms. No issue seen Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Remove deprecated file - Changes: - all: https://git.openjdk.org/jfx/pull/1527/files - n