On Tue, 9 Jul 2024 17:58:30 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> it looks to me readBinary should be static, and writeBinary an instance >> method - this is a normal pattern. the asymmetry is dictated by the fact >> that we don't have an instance when reading, so typically read() methods >> read the stream and create an instance at the last moment with the specific >> constructor. unless, of course, the design allows for mutation and the >> fields can be set(). >> >> Alternatively, readBinary() could be moved to another class (helper? >> reader?) to avoid making this an API change. >> >> what do you think? > > I can see if I can externalize this or if that would run into issues. Also > please note, although technically an API change, it is NOT an accessible API > (and so can be removed at any time) because only the permitted types can > access this API. > > In other words, this could wait and be done separately or never. what is the resolution, @hjohn ? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1333#discussion_r1706186666
