Re: RFR: 8337229: Missing @Overrides in GlassSystemMenuShim

2024-07-25 Thread Kevin Rushforth
On Thu, 25 Jul 2024 19:07:01 GMT, Andy Goryachev wrote: > We need to turn this warning into error in the gradle build. There's an umbrella issue, [JDK-8327170](https://bugs.openjdk.org/browse/JDK-8327170), for adding various lint options (once we are lint clean) to the build. "override" is on

RFR: 8337229: Missing @Overrides in GlassSystemMenuShim

2024-07-25 Thread Andy Goryachev
Added missing @Overrides We need to turn this warning into error in the gradle build. - Commit messages: - 8337229: Missing @Overrides in GlassSystemMenuShim Changes: https://git.openjdk.org/jfx/pull/1517/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1517&range=00 Issu

RFR: 8337228: Eclipse: missing dependencies in systemTests-test project

2024-07-25 Thread Andy Goryachev
Fixed Eclipse .classpath in the systemTests-test project. - Commit messages: - 8337228: Eclipse: missing dependencies in systemTests-test project Changes: https://git.openjdk.org/jfx/pull/1516/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1516&range=00 Issue: https://bu

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v21]

2024-07-25 Thread Andy Goryachev
On Tue, 9 Jul 2024 09:06:58 GMT, Johan Vos wrote: >> A listener was added but never removed. >> This patch removes the listener when the menu it links to is cleared. Fix >> for https://bugs.openjdk.org/browse/JDK-8319779 > > Johan Vos has updated the pull request incrementally with one additiona

Integrated: 8334874: Horizontal scroll events from touch pads should scroll the TabPane tabs

2024-07-25 Thread Jose Pereda
On Mon, 24 Jun 2024 18:05:09 GMT, Jose Pereda wrote: > This PR considers the horizontal scroll events that can be generated on a > trackpad, on an horizontally sided `TabPane` control (top or bottom), adding > to the existing vertical scroll events from mouse wheel and trackpad, to > scroll it

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v21]

2024-07-25 Thread Andy Goryachev
On Tue, 9 Jul 2024 09:06:58 GMT, Johan Vos wrote: >> A listener was added but never removed. >> This patch removes the listener when the menu it links to is cleared. Fix >> for https://bugs.openjdk.org/browse/JDK-8319779 > > Johan Vos has updated the pull request incrementally with one additiona

Integrated: 8319779: SystemMenu: memory leak due to listener never being removed

2024-07-25 Thread Johan Vos
On Fri, 10 Nov 2023 10:34:08 GMT, Johan Vos wrote: > A listener was added but never removed. > This patch removes the listener when the menu it links to is cleared. Fix for > https://bugs.openjdk.org/browse/JDK-8319779 This pull request has now been integrated. Changeset: 25ac6fed Author:J

Re: RFR: 8334874: Horizontal scroll events from touch pads should scroll the TabPane tabs [v4]

2024-07-25 Thread Kevin Rushforth
On Wed, 24 Jul 2024 23:12:05 GMT, Jose Pereda wrote: >> This PR considers the horizontal scroll events that can be generated on a >> trackpad, on an horizontally sided `TabPane` control (top or bottom), adding >> to the existing vertical scroll events from mouse wheel and trackpad, to >> scrol

Re: RFR: 8334874: Horizontal scroll events from touch pads should scroll the TabPane tabs [v4]

2024-07-25 Thread Andy Goryachev
On Wed, 24 Jul 2024 23:12:05 GMT, Jose Pereda wrote: >> This PR considers the horizontal scroll events that can be generated on a >> trackpad, on an horizontally sided `TabPane` control (top or bottom), adding >> to the existing vertical scroll events from mouse wheel and trackpad, to >> scrol

Is it possible to disable JavaFX shutdown hook?

2024-07-25 Thread PavelTurk
Hello all. JavaFX adds its own shutdown hook. That gives many problems when it is necessary to work with application, when system is shutting down, for example, if user presses CTRL+C. The first problem I described here - https://bugs.openjdk.org/browse/JDK-8320923 Another problem is that afte

Re: RFR: 8336389: Infinite loop occurs while resolving lookups [v5]

2024-07-25 Thread Kevin Rushforth
On Mon, 22 Jul 2024 22:38:17 GMT, Andy Goryachev wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add lines I forgot to commit > > modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java >

Re: RFR: 8336389: Infinite loop occurs while resolving lookups [v5]

2024-07-25 Thread Kevin Rushforth
On Mon, 22 Jul 2024 20:46:08 GMT, John Hendrikx wrote: >> Fixes an infinite loop that can occur while resolving lookups. >> >> There were 2 bugs: >> - A `contains` check was done on some value X, but then a value Y was added >> to the set used to track duplicates >> - The `Set` to track duplica