On Mon, 22 Jul 2024 22:38:17 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add lines I forgot to commit
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java
> line 699:
>
>> 697:
>> 698: // Note: on Windows, the message is using inconsistent line
>> endings (sometimes Windows, sometimes Linux)
>> 699: // so I've stripped it.
>
> would looking for substrings be a better solution? for example:
>
>
> contains("Caught java.lang.IllegalArgumentException: Loop detected in
> *.root{") &&
> contains("while resolving '-fx-base'' while calculating value for
> '-fx-background-color' from rule '*.pane' in stylesheet"
Yeah, this seems less fragile. If we ever run into a problem because the
message changes slightly, we could consider such a change in the future.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1505#discussion_r1691604202
