On Mon, 22 Jul 2024 20:46:08 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> Fixes an infinite loop that can occur while resolving lookups. >> >> There were 2 bugs: >> - A `contains` check was done on some value X, but then a value Y was added >> to the set used to track duplicates >> - The `Set` to track duplicates was cleared in some recursive calls, meaning >> that the caller (which may be processing multiple values in a loop) would >> end up with an empty set, losing track of what was visited so far >> >> Also removed a redundant `null` check (an NPE would have occurred before it >> could reach that code). > > John Hendrikx has updated the pull request incrementally with one additional > commit since the last revision: > > Add lines I forgot to commit I see the ready label on this PR, but GitHub has noted a merge conflict. I'll see if adding this comment (with a redundant Skara command) causes Skara to wake up and notice. Either way, it might be good to merge the latest master into this PR branch. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1505#issuecomment-2250485819
