Checked code and fixed the gramatical error in Transition files:
s/interval/intervals
Fill and Stroke Transition had correct grammatical form already, so those were
untouched. I couldn't find any other instances of this error in our javadoc
documentation.
-
Commit messages:
- Fix
It looks as if this issue was reported in 2021, 2022, and 2023. The
difference now is that, as of Maven 3.9.7, the failure occurs
immediately when it tries to download the JavaFX dependencies.
2021-12-27
JDK-8279380: Duplicate profile id in JavaFX maven POM
https://bugs.openjdk.org/browse/JDK-8
> Implementation of [CSS
> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a).
>
> ### Future enhancements
> CSS transitions requires all participating objects to implement the
> `Interpolatable` interface. For example, targeting `-fx-background-color`
> only works if
On Tue, 28 May 2024 21:44:36 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
On Tue, 28 May 2024 21:41:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
On Tue, 28 May 2024 04:48:32 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
On Tue, 28 May 2024 21:37:43 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/test/java/test/com/sun/javafx/css/FixedCapacitySetTest.java
>> line 1:
>>
>>> 1: package test.com.sun.javafx.css;
>>
>> The Copyright is missing from this class and the `if` and `for` clauses have
>> no spa
On Tue, 28 May 2024 21:31:53 GMT, Marius Hanl wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added 100% coverage test for FixedCapacitySet
>
> modules/javafx.graphics/src/test/java/test/com/sun/javafx/css/FixedCa
> Improves performance of selector matching in the CSS subsystem. This is done
> by using custom set implementation which are highly optimized for the most
> common cases where the number of selectors is small (most commonly 1 or 2).
> It also should be more memory efficient for medium sized and
Vote: YES
Jose
On Mon, May 27, 2024 at 7:20 AM Ajit Ghaisas
wrote:
> Vote: YES
>
> Regards,
> Ajit
>
> > On 23-May-2024, at 4:54 AM, Kevin Rushforth
> wrote:
> >
> > I hereby nominate John Hendrikx [1] to OpenJFX Reviewer.
> >
> > John is an OpenJFX community member, who has contributed 39 com
On Tue, 28 May 2024 21:15:47 GMT, John Hendrikx wrote:
>> This PR fixes the incorrect computation of the `CornerRadii.uniform` flag
>> for the 16-argument constructor.
>>
>> I've also added tests for all other constructors.
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/CornerRad
On Tue, 28 May 2024 04:35:34 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
On Tue, 28 May 2024 04:48:32 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
On Tue, 28 May 2024 16:15:25 GMT, Michael Strauß wrote:
> This PR fixes the incorrect computation of the `CornerRadii.uniform` flag for
> the 16-argument constructor.
>
> I've also added tests for all other constructors.
LGTM
modules/javafx.graphics/src/main/java/javafx/scene/layout/CornerRad
JavaFX applications fail to build with Maven 3.9.7, which was released
on May 25. The Maven developers identified the JavaFX parent POM file as
the source of the problem:
Maven Central: org.openjfx:javafx:22.0.1
https://central.sonatype.com/artifact/org.openjfx/javafx/22.0.1
To see the errors,
On Tue, 28 May 2024 04:48:32 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
On Tue, 28 May 2024 11:25:51 GMT, Michael Strauß wrote:
>> True, but I think it's a lot easier to follow than the logic before it. I
>> see it a bit more as a hint to future maintainers (which might be me) that
>> there are assumptions being made here that code relies on.
>
> I understand that,
On Tue, 28 May 2024 17:55:24 GMT, Andy Goryachev wrote:
>> This PR fixes the incorrect computation of the `CornerRadii.uniform` flag
>> for the 16-argument constructor.
>>
>> I've also added tests for all other constructors.
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/Cor
On Tue, 28 May 2024 16:15:25 GMT, Michael Strauß wrote:
> This PR fixes the incorrect computation of the `CornerRadii.uniform` flag for
> the 16-argument constructor.
>
> I've also added tests for all other constructors.
the change looks good. thank you for adding a comprehensive test!
modul
On Fri, 24 May 2024 06:48:50 GMT, Jayathirth D V wrote:
> In IJG library's jmemmgr.c file we can define MEM_STATS(by default this flag
> is not defined and we don't see any issue) to enable printing of memory
> statistics log. But if we enable it, we get crash while disposing IJG stored
> obje
On Sun, 26 May 2024 13:02:23 GMT, Marius Hanl wrote:
>> This PR fixes a long standing issue where the `Tooltip` will always wait one
>> second until it appears the very first time, even if the
>> `-fx-show-delay` was set to another value.
>>
>> The culprit is, that the `cssForced` flag is not
On Sun, 26 May 2024 13:02:23 GMT, Marius Hanl wrote:
>> This PR fixes a long standing issue where the `Tooltip` will always wait one
>> second until it appears the very first time, even if the
>> `-fx-show-delay` was set to another value.
>>
>> The culprit is, that the `cssForced` flag is not
On Sun, 26 May 2024 13:02:23 GMT, Marius Hanl wrote:
>> This PR fixes a long standing issue where the `Tooltip` will always wait one
>> second until it appears the very first time, even if the
>> `-fx-show-delay` was set to another value.
>>
>> The culprit is, that the `cssForced` flag is not
This PR fixes the incorrect computation of the `CornerRadii.uniform` flag for
the 16-argument constructor.
I've also added tests for all other constructors.
-
Commit messages:
- fixed computation of uniform flag
- failing test
Changes: https://git.openjdk.org/jfx/pull/1465/files
On Fri, 24 May 2024 18:18:22 GMT, Hima Bindu Meda wrote:
> Updated libxml to v2.12.7. Sanity testing looks fine. No issue seen
This pull request has now been integrated.
Changeset: dedcf1d2
Author:Hima Bindu Meda
URL:
https://git.openjdk.org/jfx/commit/dedcf1d236b5429dcf3c42f5fd1095
On Sun, 26 May 2024 12:44:23 GMT, Marius Hanl wrote:
> Yeah this is a 'known bug' for me, and has nothing to do with this fix.
I do not see the issue without the fix though (at the same resolution).
-
PR Comment: https://git.openjdk.org/jfx/pull/1462#issuecomment-2135380812
On Tue, 28 May 2024 04:48:32 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
On Tue, 28 May 2024 11:01:21 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/FixedCapacitySet.java
>> line 419:
>>
>>> 417: */
>>> 418:
>>> 419: assert elements.length > requestedCapacity : "must have
>>> more buckets than capacit
On Tue, 28 May 2024 09:43:28 GMT, Michael Strauß wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 21 commits:
>>
>> - Merge branch 'openjdk:master' into
>> feature/selector-performance-improvement
>> - Me
On Tue, 28 May 2024 04:48:32 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
Hi Andy
Maybe a fix (quick?) could be a option to always show the scrollbar? I have
used that option before in HTML/CSS:
https://www.w3schools.com/howto/howto_css_force_scrollbars.asp
Kind Regards
Mads
Den tirs. 26. mar. 2024 kl. 16.31 skrev Andy Goryachev <
andy.goryac...@oracle.com>:
> Hi the
On Tue, 21 May 2024 14:25:51 GMT, Michael Strauß wrote:
> This PR fixes a bug
> ([JDK-8289115](https://bugs.openjdk.org/browse/JDK-8289115)) that was
> introduced with #394, which changed the following line in the
> `NotifyTouchInput` function (ViewContainer.cpp):
>
> - const bool isDirect =
32 matches
Mail list logo
