On Tue, 28 May 2024 11:25:51 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> True, but I think it's a lot easier to follow than the logic before it. I >> see it a bit more as a hint to future maintainers (which might be me) that >> there are assumptions being made here that code relies on. > > I understand that, my objection is only with the `assert` keyword. I don't > like test code in production code (which this is, it verifies that an > assumption holds). I think only unit tests should contain test code, but it's > a minor issue and I'll reapprove as-is. I think (and please correct me if I am wrong) that by default java assertions are disabled. They are only enabled for the tests, see build.gradle :2106 :2628 ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1316#discussion_r1617767401
