On Tue, 28 May 2024 16:15:25 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
> This PR fixes the incorrect computation of the `CornerRadii.uniform` flag for
> the 16-argument constructor.
>
> I've also added tests for all other constructors.
the change looks good. thank you for adding a comprehensive test!
modules/javafx.graphics/src/test/java/test/javafx/scene/layout/CornerRadiiTest.java
line 65:
> 63:
> 64: @Nested
> 65: class IsUniformTests {
just curious - what was the rationale for `@Nested` here, as the number of the
test cases is fairly small.
-------------
Marked as reviewed by angorya (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1465#pullrequestreview-2083526426
PR Review Comment: https://git.openjdk.org/jfx/pull/1465#discussion_r1617694868
