Re: RFR: 8311895: CSS Transitions [v19]

2024-05-25 Thread Nir Lisker
On Sat, 25 May 2024 21:39:24 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). >> >> ### Future enhancements >> CSS transitions requires all participating objects to implement the >> `Interpolatable` interface.

Re: RFR: 8311895: CSS Transitions [v18]

2024-05-25 Thread Michael Strauß
On Sat, 25 May 2024 21:17:06 GMT, Nir Lisker wrote: > This is what I would expect, so looks good. Where is this mentioned to the > user? Good question. Since we don't have any suitable API elements for javadocs, I've added some documentation to the CSS reference. - PR Comment: ht

Re: RFR: 8311895: CSS Transitions [v19]

2024-05-25 Thread Michael Strauß
> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Future enhancements > CSS transitions requires all participating objects to implement the > `Interpolatable` interface. For example, targeting `-fx-background-color` > only works if

Re: RFR: 8311895: CSS Transitions [v18]

2024-05-25 Thread Nir Lisker
On Sat, 25 May 2024 20:40:39 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). >> >> ### Future enhancements >> CSS transitions requires all participating objects to implement the >> `Interpolatable` interface.

Re: RFR: 8311895: CSS Transitions [v17]

2024-05-25 Thread Michael Strauß
On Sat, 25 May 2024 19:39:12 GMT, Nir Lisker wrote: > I still don't know what happens when a value is programmatically set while a > css transition is in progress. What I understood is that binding the property > will not allow the transition to start/continue, but didn't see where setting > a

Re: RFR: 8311895: CSS Transitions [v17]

2024-05-25 Thread Nir Lisker
On Sat, 25 May 2024 21:04:24 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html >> line 690: >> >>> 688: changed, it smoothly transitions to the new value over a >>> period of time. Implicit transitions are supported >>> 689:

Re: RFR: 8311895: CSS Transitions [v17]

2024-05-25 Thread Michael Strauß
On Sat, 25 May 2024 19:35:56 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 57 commits: >> >> - Merge branch 'refs/heads/master' into feature/css-transitions >> - extract magic string to

Re: RFR: 8311895: CSS Transitions [v17]

2024-05-25 Thread Michael Strauß
On Sat, 25 May 2024 19:28:56 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 57 commits: >> >> - Merge branch 'refs/heads/master' into feature/css-transitions >> - extract magic string to

Re: RFR: 8311895: CSS Transitions [v17]

2024-05-25 Thread Nir Lisker
On Sat, 25 May 2024 20:37:44 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/javafx/animation/Interpolator.java >> line 277: >> >>> 275: * @since 23 >>> 276: */ >>> 277: public enum StepPosition { >> >> I think it would be helpful to include (or link to) image

Re: RFR: 8311895: CSS Transitions [v17]

2024-05-25 Thread Michael Strauß
On Sat, 25 May 2024 17:40:01 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 57 commits: >> >> - Merge branch 'refs/heads/master' into feature/css-transitions >> - extract magic string to

Re: RFR: 8311895: CSS Transitions [v17]

2024-05-25 Thread Michael Strauß
On Sat, 25 May 2024 10:40:05 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 57 commits: >> >> - Merge branch 'refs/heads/master' into feature/css-transitions >> - extract magic string to

Re: RFR: 8311895: CSS Transitions [v18]

2024-05-25 Thread Michael Strauß
> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Future enhancements > CSS transitions requires all participating objects to implement the > `Interpolatable` interface. For example, targeting `-fx-background-color` > only works if

Re: RFR: 8311895: CSS Transitions [v2]

2024-05-25 Thread Nir Lisker
On Mon, 31 Jul 2023 18:10:46 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/javafx/animation/Interpolator.java >> line 319: >> >>> 317: * The output time value is determined by the {@link StepPosition}. >>> 318: * >>> 319: * @param intervals the number of int

Re: RFR: 8311895: CSS Transitions [v17]

2024-05-25 Thread Nir Lisker
On Fri, 24 May 2024 11:18:35 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). >> >> ### Future enhancements >> CSS transitions requires all participating objects to implement the >> `Interpolatable` interface.

Re: RFR: 8322964: Optimize performance of CSS selector matching [v9]

2024-05-25 Thread Kevin Rushforth
On Fri, 24 May 2024 15:04:08 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Move getStyleClassNames to location it was introduced to reduce diff > > The code looks good. I didn't test it, but I'm