On Sat, 25 May 2024 21:04:24 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html >> line 690: >> >>> 688: changed, it smoothly transitions to the new value over a >>> period of time. Implicit transitions are supported >>> 689: for all primitive types, as well as for types that implement >>> <code>javafx.animation.Interpolatable</code>.</p> >>> 690: <p>Transitions can be defined for any node in the JavaFX scene >>> graph with the following properties:</p> >> >> The way this is phrased makes it sound like the node has "the following >> properties", not the transition. Maybe move that part: >> "Transitions with the following properties can be defined for any node in >> the JavaFX scene graph", or just add a comma. > > I understand that you're saying that `property`, `duration`, > `timing-function`, and `delay` are all sub-properties of `transition`. > > However, from a CSS perspective, `transition-property`, > `transition-duration`, `transition-timing-function` and `transition-delay` > are properties of `Node`, in the same way as `-fx-background-color`, > `-fx-background-insets`, etc. are properties of `Node`. > > `transition` is a short-hand property that combines all four properties into > one (we don't have a short-hand property for backgrounds yet). I think that > both mental models are basically correct (four properties of node, vs. four > sub-properties of transition). I understand. I find it a bit confusing, but OK to leave as is. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/870#discussion_r1614892590
