On Fri, 24 May 2024 15:04:08 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Move getStyleClassNames to location it was introduced to reduce diff > > The code looks good. I didn't test it, but I'm fine with integrating. > Also some clarification on the contributing rules: "all Reviewers who have > requested the chance to review have done so" -- does the indication at the > top right of the PR count towards this or should it be a comment? :) In the > first case, @nlisker and @arapte, please indicate if you wish to review this > still. If someone wants you to wait for them, they should make it clear by adding a comment. Also if someone has given substantive feedback, but hasn't (re)approved, it's good to give them a change to review. @arapte can add a comment if he wants to review, otherwise go ahead and integrate on Monday. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1316#issuecomment-2131275284
