On Thu, 16 May 2024 22:23:40 GMT, Kevin Rushforth wrote:
> Clean backport of Linux GHA fix to jfx22u (so we can get clean GHA runs for
> future 22u backports)
@johanvos Since this is a clean backport, it doesn't need to be reviewed, but
it does need maintainer approval. It's not an urgent fix,
Clean backport of Linux GHA fix to jfx22u (so we can get clean GHA runs for
future 22u backports)
-
Commit messages:
- Backport d7ab55184f757a614f9fc8f191c3c5794a16cc88
Changes: https://git.openjdk.org/jfx22u/pull/29/files
Webrev: https://webrevs.openjdk.org/?repo=jfx22u&pr=29&ra
On Tue, 14 May 2024 13:37:32 GMT, Florian Kirmaier
wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8323511: Adjust javadoc of the getViewportLength()
>
> Ok, I've updated the CSR accrodingly together with
On Mon, 6 May 2024 23:14:11 GMT, Andy Goryachev wrote:
>> Adding alt-ctrl-LEFT/RIGHT/UP/DOWN (option-command-LEFT/RIGHT/UP/DOWN) key
>> bindings to
>>
>> - ListView
>> - TreeView
>> - TableView
>> - TreeTableView
>>
>> to support keyboard-only horizontal and vertical scrolling. The main reaso
On Thu, 9 May 2024 14:49:26 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
Hello!
On 15/05/2024 14:49, Martin Fox wrote:
> Mark,
>
> You may already know this but before JavaFX 21 the Mac and Windows Robot code
> had some long-standing bugs with non-US keyboards. Linux is in better shape
> but you can encounter problems if the user has installed multiple layouts (I
>
Root cause: premature 'return' from initialization code leaves the hover square
visible, even when it should be hidden, as the case is when the color value is
not present in the palette.
- added unit tests
-
Commit messages:
- 8324327: ColorPicker shows a white rectangle on clicki
On Wed, 15 May 2024 23:01:30 GMT, Andy Goryachev wrote:
> The javadoc for `Region.getPrefHeight() / getPrefWidth()` incorrectly refers
> to `getPrefHeight(forWidth) / getPrefWidth(forHeight)`
>
> should be
>
> `prefHeight(forWidth) / prefWidth(forHeight)`
>
> - same issue is also fixed in `Po
On Thu, 16 May 2024 16:23:26 GMT, Ambarish Rapte wrote:
>> thank you for pointing this out, I am going to revert back to `` and
>> update `PopupControl`.
>
> Looks good,
> I recommend to update the summary, current summary is quite specific to
> Region / prefWidth/Height.
>
> A suggestion->
>
On Thu, 16 May 2024 15:42:05 GMT, Kevin Rushforth wrote:
> It looks like the list of packages available in the Ubuntu 22.04 GitHub
> Actions test runner no longer includes `gcc-13` as of yesterday. I didn't
> find any documentation to indicate that this was intentional, but now that
> Ubuntu 2
On Thu, 16 May 2024 15:42:05 GMT, Kevin Rushforth wrote:
> It looks like the list of packages available in the Ubuntu 22.04 GitHub
> Actions test runner no longer includes `gcc-13` as of yesterday. I didn't
> find any documentation to indicate that this was intentional, but now that
> Ubuntu 2
In another thread someone asked whether JavaFX could report which keyboard
layout is currently active. I don’t think there’s any useful way of doing this.
The Mac organizes layouts using language codes. There are five variants for
German and 15 for English. The German variants are ABC-QWERTZ, Au
On Thu, 16 May 2024 15:42:05 GMT, Kevin Rushforth wrote:
> It looks like the list of packages available in the Ubuntu 22.04 GitHub
> Actions test runner no longer includes `gcc-13` as of yesterday. I didn't
> find any documentation to indicate that this was intentional, but now that
> Ubuntu 2
On Thu, 16 May 2024 14:54:47 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/layout/Region.java line
>> 1212:
>>
>>> 1210: *
>>> 1211: * Defaults to the USE_COMPUTED_SIZE flag, which
>>> means that
>>> 1212: * {@link #prefHeight(forWidth)} will
On Thu, 16 May 2024 14:58:29 GMT, Andy Goryachev wrote:
>> The javadoc for `Region.getPrefHeight() / getPrefWidth()` incorrectly refers
>> to `getPrefHeight(forWidth) / getPrefWidth(forHeight)`
>>
>> should be
>>
>> `prefHeight(forWidth) / prefWidth(forHeight)`
>>
>> - same issue is also fixe
On Thu, 16 May 2024 15:42:05 GMT, Kevin Rushforth wrote:
> It looks like the list of packages available in the Ubuntu 22.04 GitHub
> Actions test runner no longer includes `gcc-13` as of yesterday. I didn't
> find any documentation to indicate that this was intentional, but now that
> Ubuntu 2
On Thu, 16 May 2024 15:42:05 GMT, Kevin Rushforth wrote:
> It looks like the list of packages available in the Ubuntu 22.04 GitHub
> Actions test runner no longer includes `gcc-13` as of yesterday. I didn't
> find any documentation to indicate that this was intentional, but now that
> Ubuntu 2
It looks like the list of packages available in the Ubuntu 22.04 GitHub Actions
test runner no longer includes `gcc-13` as of yesterday. I didn't find any
documentation to indicate that this was intentional, but now that Ubuntu 24.04
is available we can fix the problem by updating to that versio
> The javadoc for `Region.getPrefHeight() / getPrefWidth()` incorrectly refers
> to `getPrefHeight(forWidth) / getPrefWidth(forHeight)`
>
> should be
>
> `prefHeight(forWidth) / prefWidth(forHeight)`
>
> - same issue is also fixed in `PopupControl`.
Andy Goryachev has updated the pull request
On Thu, 16 May 2024 10:01:05 GMT, Ambarish Rapte wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> popup control
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/Region.java line
> 1212:
>
>> 1210:
On Wed, 15 May 2024 23:01:30 GMT, Andy Goryachev wrote:
> The javadoc for `Region.getPrefHeight() / getPrefWidth()` incorrectly refers
> to `getPrefHeight(forWidth) / getPrefWidth(forHeight)`
>
> should be
>
> `prefHeight(forWidth) / prefWidth(forHeight)`
>
> - also converted these references
On Thu, 16 May 2024 07:30:31 GMT, Johan Vos wrote:
>> Yeah, that was a typo (which I didn't notice when copying the block from the
>> other doc). I'll fix it. And I agree with your concern, so I'll remove the
>> last sentence.
>
> I agree with the concern, but I still think it's much better to
On Wed, 15 May 2024 21:57:23 GMT, Kevin Rushforth wrote:
>> CONTRIBUTING.md line 233:
>>
>>> 231: * Don't worry too much about import order. Try not to change it but
>>> don't worry about fighting your IDE to stop it from doing so.
>>> 232:
>>> 233: New code should be formatted consistently in
On Wed, 15 May 2024 19:39:10 GMT, Kevin Rushforth wrote:
>> README-code-reviews.md line 66:
>>
>>> 64: * Focus first on substantive comments rather than stylistic comments
>>> 65: * Consider the risk of regression
>>> 66: * Consider any compatibility concerns
>>
>> regression and compatibility
On Mon, 6 May 2024 21:11:35 GMT, Martin Fox wrote:
> I'll look into the Linux failure. The core EventLoop code passes an object
> into the application's leaveNestedEventLoop and expects to see that object
> returned from the applications's matching enterNestedEventLoop call. On Mac
> and Windo
25 matches
Mail list logo
