On Fri, 29 Apr 2022 14:59:41 GMT, Alexander Scherbatiy
wrote:
>> There are sometimes multitouch events detected, when only a single touch
>> should be detected under certain conditions. This lead to touch events on
>> previous touch positions.
>>
>> The referenced bug is closed with "won't fi
On code inspection it is revealed that in jpegloader.c->decompressIndirect() we
are allocating memory for "scanline_ptr", but if we error_exit() from
jpeg_read_scanlines() we are not releasing this memory.
Added release of "scanline_ptr" with NULL check at appropriate places.
As part of this fix
> This provides and uses a new implementation of `ExpressionHelper`, called
> `ListenerManager` with improved semantics.
>
> # Behavior
>
> |Listener...|ExpressionHelper|ListenerManager|
> |---|---|---|
> |Invocation Order|In order they were registered, invalidation listeners
> always before ch
> This provides and uses a new implementation of `ExpressionHelper`, called
> `ListenerManager` with improved semantics.
>
> # Behavior
>
> |Listener...|ExpressionHelper|ListenerManager|
> |---|---|---|
> |Invocation Order|In order they were registered, invalidation listeners
> always before ch
> This provides and uses a new implementation of `ExpressionHelper`, called
> `ListenerManager` with improved semantics.
>
> # Behavior
>
> |Listener...|ExpressionHelper|ListenerManager|
> |---|---|---|
> |Invocation Order|In order they were registered, invalidation listeners
> always before ch
On Tue, 25 Apr 2023 18:36:45 GMT, Andy Goryachev wrote:
>> @andy-goryachev-oracle My highest priorities are #425 (Mac) and the Java
>> code in this PR. I'll get it switched over to Windows as soon as possible so
>> we have a complete implementation of the new key event pipeline to review.
>> T
On Fri, 9 Jun 2023 00:18:46 GMT, Thiago Milczarek Sayao
wrote:
>> Martin Fox has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updating classpath for Eclipse users
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/View.java line
On Tue, 25 Apr 2023 18:36:45 GMT, Andy Goryachev wrote:
>> @andy-goryachev-oracle My highest priorities are #425 (Mac) and the Java
>> code in this PR. I'll get it switched over to Windows as soon as possible so
>> we have a complete implementation of the new key event pipeline to review.
>> T
On Thu, 27 Apr 2023 18:07:53 GMT, Martin Fox wrote:
>> The algorithm in `KeyCharacterCombination.match` relies on the call
>> `Toolkit.getKeyCodeForChar` which is difficult to implement correctly. It
>> defies the way most keyboard API’s work and no platform has got it right
>> yet. In particu
On Thu, 27 Apr 2023 18:07:53 GMT, Martin Fox wrote:
>> The algorithm in `KeyCharacterCombination.match` relies on the call
>> `Toolkit.getKeyCodeForChar` which is difficult to implement correctly. It
>> defies the way most keyboard API’s work and no platform has got it right
>> yet. In particu
On Thu, 27 Apr 2023 18:07:53 GMT, Martin Fox wrote:
>> The algorithm in `KeyCharacterCombination.match` relies on the call
>> `Toolkit.getKeyCodeForChar` which is difficult to implement correctly. It
>> defies the way most keyboard API’s work and no platform has got it right
>> yet. In particu
On Thu, 8 Jun 2023 21:38:02 GMT, Andy Goryachev wrote:
> I am somewhat divided on which version to start with. On one hand, it makes
> sense to use last LTS version (or previous, if the current one is also LTS),
> so 17.
I think we should either start from 9 or 11.
Depending on the source, Jav
On Thu, 27 Apr 2023 11:39:24 GMT, Nir Lisker wrote:
>> Adds the javadoc commands to generate the NEW page and to be able to select
>> versions in the DEPRECATED page.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Auto-dete
On Tue, 6 Jun 2023 01:09:36 GMT, Thiago Milczarek Sayao
wrote:
>> I replicated the fix on #1054 on Linux.
>>
>> Also fixes [Monocle: Stage no longer gets focus after fix for
>> JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734)
>
> Thiago Milczarek Sayao has updated the pull request inc
On Wed, 7 Jun 2023 20:59:01 GMT, Marius Hanl wrote:
> This PR does two small improvements to `VirtualFlow`.
> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
> `computeWidth` methods, although a fixed cell size is set and we therefore
> don't need to call those method (and
On Thu, 8 Jun 2023 17:44:21 GMT, Karthik P K wrote:
> All the tests added here passes with the fix and fails without it. No issues
> now. Could have been some problem from my end.
Alright, thanks for the feedback!
-
PR Comment: https://git.openjdk.org/jfx/pull/1150#issuecomment-15
An easier way would be to use the shims classes, which is what "gradle
test" uses. Monocle is included with the shims even without needing to
specify anything. Try something like this:
gradle shims
java @build/testrun.args -Dglass.platform=Monocle
-Dmonocle.platform=Headless WindowTest.java
On Thu, 8 Jun 2023 15:59:13 GMT, Marius Hanl wrote:
>> This PR does two small improvements to `VirtualFlow`.
>> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
>> `computeWidth` methods, although a fixed cell size is set and we therefore
>> don't need to call those method (
Hi,
I'm building javafx with:
./gradlew -PincludeMonocle build
And trying to test with:
java @/home/tsayao/jfx/build/run.args -Dglass.platform=Monocle
-Dmonocle.platform=Headless -Dprism.order=sw WindowTest.java
But it seems monocle was not included:
java.lang.ClassNotFoundException:
com.sun.gla
On Thu, 8 Jun 2023 06:47:44 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
>> line 1954:
>>
>>> 1952: * Gets the breadth of a specific cell
>>> 1953: */
>>> 1954: double getCellBreadth(T cell) {
>>
>> is there a possibi
On Thu, 8 Jun 2023 15:59:13 GMT, Marius Hanl wrote:
>> This PR does two small improvements to `VirtualFlow`.
>> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
>> `computeWidth` methods, although a fixed cell size is set and we therefore
>> don't need to call those method (
On Thu, 8 Jun 2023 15:59:13 GMT, Marius Hanl wrote:
>> This PR does two small improvements to `VirtualFlow`.
>> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
>> `computeWidth` methods, although a fixed cell size is set and we therefore
>> don't need to call those method (
> This PR does two small improvements to `VirtualFlow`.
> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
> `computeWidth` methods, although a fixed cell size is set and we therefore
> don't need to call those method (and never should do, as we may don't get the
> expected r
On Thu, 8 Jun 2023 13:41:04 GMT, Karthik P K wrote:
> Tested the changes in MacOS 13.3.1, I'm seeing failure ...
I added two more test that directly fail if those methods are called. You will
get a better stacktrace from them. If this issue still appears, please paste it
here. :)
On Thu, 8 Jun 2023 13:41:56 GMT, Karthik P K wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8309470: Improved Tests
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
> line 3
On Thu, 8 Jun 2023 15:43:00 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/VirtualFlowTest.java
>> line 1542:
>>
>>> 1540: @Override
>>> 1541: protected double computeMinHeight(double width) {
>>> 1542: ret
> This PR does two small improvements to `VirtualFlow`.
> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
> `computeWidth` methods, although a fixed cell size is set and we therefore
> don't need to call those method (and never should do, as we may don't get the
> expected r
On Thu, 8 Jun 2023 07:18:22 GMT, Marius Hanl wrote:
>> This PR does two small improvements to `VirtualFlow`.
>> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
>> `computeWidth` methods, although a fixed cell size is set and we therefore
>> don't need to call those method (
Hi
Could someone please add the following lines as comment to the issue
JDK-8289115 (https://bugs.openjdk.org/browse/JDK-8289115) Thank you very
much.
@Praveen please have another look at Capture.pptx and you'll see that only
MouseEvents are being fired and NO TouchEvents. The test case
On Thu, 8 Jun 2023 07:18:22 GMT, Marius Hanl wrote:
>> This PR does two small improvements to `VirtualFlow`.
>> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
>> `computeWidth` methods, although a fixed cell size is set and we therefore
>> don't need to call those method (
On Thu, 8 Jun 2023 07:19:35 GMT, Marius Hanl wrote:
> Note: This PR needs a merge/rebase.
Yes, I will get around to it this weekend
-
PR Comment: https://git.openjdk.org/jfx/pull/1076#issuecomment-1582034862
On Tue, 25 Apr 2023 07:14:07 GMT, John Hendrikx wrote:
>> This fix introduces immutable sets of `PseudoClass` almost everywhere, as
>> they are rarely modified. These are re-used by caching them in a new class
>> `ImmutablePseudoClassSetsCache`.
>>
>> In order to make this work, `BitSet` had
> This PR does two small improvements to `VirtualFlow`.
> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
> `computeWidth` methods, although a fixed cell size is set and we therefore
> don't need to call those method (and never should do, as we may don't get the
> expected r
On Thu, 8 Jun 2023 00:07:20 GMT, Andy Goryachev wrote:
> I don't see any ill effects in the MonkeyTester. There is still a bit of lag
> with 10,000,000 row model, same as before.
Yeah for me as well. This is a very minor improvement and actually with this PR
the following assertion is now true
> This PR does two small improvements to `VirtualFlow`.
> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
> `computeWidth` methods, although a fixed cell size is set and we therefore
> don't need to call those method (and never should do, as we may don't get the
> expected r
On Thu, 8 Jun 2023 06:46:28 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/VirtualFlowTest.java
>> line 1579:
>>
>>> 1577: @Test
>>> 1578: public void
>>> testComputeWidthShouldNotBeCalledWhenFixedCellSizeIsSet() {
>>> 1579: int
36 matches
Mail list logo
