I think Option 1 makes the most sense. Specially since JDK 21 is LTS. Do we
want to be stuck with OS 10.x through the entire LTS period?
Scott
> On May 11, 2023, at 3:23 PM, Kevin Rushforth
> wrote:
>
> Thanks for the additional info. I had meant to look it up and add it prior
> to sending
On Thu, 11 May 2023 20:20:01 GMT, Marius Hanl wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/layout/AnchorPane.java
>> line 349:
>>
>>> 347: private double computeChildHeight(Node child, Double topAnchor,
>>> Double bottomAnchor, double areaHeight, double width) {
>>> 348:
On Wed, 10 May 2023 16:16:36 GMT, Kevin Rushforth wrote:
>> this test reflects the exact failure scenario described in the ticket.
>
> If it's easy to add another test for additional missing cases that would
> provide better coverage for your fix, it seems worth doing.
added one more test case,
> Fixed a memory leak in TreeTableView by reverting to register**Listener
> (which is ok in this particular situation) - the leak is specific to
> TreeTableRowSkin.
>
> Added a unit test.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revisi
On Wed, 10 May 2023 16:14:43 GMT, Kevin Rushforth wrote:
>> The problem is, `dispose()` is never called for cells discarded by the
>> refresh() method.
>>
>> In the absence of explicit release, these cells are still listening - so
>> using a weak listener in this case is, I think, the right ap
> Fixed a memory leak in TreeTableView by using WeakInvalidationListener (which
> is the right approach in this particular situation) - the leak is specific to
> TreeTableRowSkin.
>
> Added a unit test.
>
> Added Refresh buttons and Skin menu to the Monkey Tester (will expand these
> to other
On Thu, 11 May 2023 01:09:53 GMT, Alexander Matveev
wrote:
>> - libFFI updated to 3.4.4.
>> - No additional changes are done to the code.
>> - Tested on Linux, Windows x64 and macOS x64/aarch64.
>> - Windows x86 config files are updated, but no build/testing was done for
>> 32-bit.
>
> Alexande
On Thu, 4 May 2023 18:50:35 GMT, Andy Goryachev wrote:
> Adding TextFlow.underlineShape() to add support for a spellchecker-like
> decoration, using
>
> getRange(start, end, TextLayout.TYPE_UNDERLINE);
>
>
> which mirrors an existing method in Text with exactly the same signature.
This pull
On Thu, 11 May 2023 17:59:48 GMT, Carl Döbbelin wrote:
>> Replaced querying of `System.getProperty("os.name")` to check for OS with
>> the use of the methods provided by `PlatformUtils`
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revi
On Thu, 11 May 2023 19:39:36 GMT, Marius Hanl wrote:
> This PR changes the `columnPopupMenu`, so that it is created lazily.
>
> The problem here is, that the `columnPopupMenu` is always initialized and
> updated via bindings, even if the table menu button is never shown
> (`setTableMenuButtonV
On Thu, 11 May 2023 19:58:18 GMT, Andy Goryachev wrote:
>> Marius Hanl has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - 8295078: Snap anchors as well
>> - Merge branch 'master' of https://github.com/openjdk/
> The problem here is, that the `AnchorPane` does not use its snapped insets.
> Therefore, the fix is to replace all `getInsets().getXXX` calls with their
> corresponding `snappedXXXInset()` methods.
>
> Note: The reason the `AnchorPane` inside a `TitledPane` is blurry in the
> first place is b
> Replaced querying of `System.getProperty("os.name")` to check for OS with the
> use of the methods provided by `PlatformUtils`
Carl Döbbelin has updated the pull request incrementally with one additional
commit since the last revision:
made launcherimpl one line
-
Changes:
-
On Mon, 26 Dec 2022 03:03:50 GMT, Michael Strauß wrote:
> On Windows, a `Stage` that is restricted by minimum and maximum sizes can
> briefly be observed to appear with incorrect dimensions when it is first
> shown. The root cause of this bug is that the native `WinWindow._setBounds`
> method
On Thu, 8 Dec 2022 18:29:48 GMT, Marius Hanl wrote:
>> The problem here is, that the `AnchorPane` does not use its snapped insets.
>> Therefore, the fix is to replace all `getInsets().getXXX` calls with their
>> corresponding `snappedXXXInset()` methods.
>>
>> Note: The reason the `AnchorPane`
On Mon, 8 May 2023 18:56:43 GMT, Andy Goryachev wrote:
>> Marius Hanl has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - 8295078: Snap anchors as well
>> - Merge branch 'master' of https://github.com/openjdk/j
On Wed, 10 May 2023 23:32:04 GMT, Andy Goryachev wrote:
>> Adding TextFlow.underlineShape() to add support for a spellchecker-like
>> decoration, using
>>
>> getRange(start, end, TextLayout.TYPE_UNDERLINE);
>>
>>
>> which mirrors an existing method in Text with exactly the same signature.
>
On Thu, 11 May 2023 19:12:52 GMT, Marius Hanl wrote:
>> I think I now understand the snapping better, especially after discussion in
>> https://github.com/openjdk/jfx/pull/
>>
>> it looks like we should be operating in terms of final pixels, that is, in
>> snapped coordinates. this might
This PR changes the `columnPopupMenu`, so that it is created lazily.
The problem here is, that the `columnPopupMenu` is always initialized and
updated via bindings, even if the table menu button is never shown
(`setTableMenuButtonVisible(false)`) or the user never clicked on it.
This problem can
Thanks for the additional info. I had meant to look it up and add it
prior to sending it out, but hit "send" too soon.
My preference would be Option 1: change the minimum to macOS 11.0 in
JavaFX 21.
If there are some significant concerns over doing that, we could go with
Option 2 as a fallba
On Mon, 8 May 2023 19:04:01 GMT, Andy Goryachev wrote:
>> It's seems little tricky to choose an approach for this fix.
>>
>> - NOT snapping intermediate values (new approach):
>> 1. It definitely seems correct NOT to snap intermediate values.
>> 2. But currently, code Controls snap the intermedi
> My preference is to change the minimum version for Mac / x64 to be macOS
> 11.0, matching both the currently oldest version of macOS supported by Apple,
> and also unifying the minimum for the two chip architectures.
So no one else has to look this up:
The last security update for macOS 10.
On Sat, 15 Apr 2023 23:32:40 GMT, Thiago Milczarek Sayao
wrote:
>> This PR does:
>>
>> - Remove specific Idea files and let it be imported from gradle;
>> - Adds checkstyle (to use with checkstyle plugin - it will let you know
>> style mistakes);
>> - Configures auto-format to sun style (with
On Thu, 11 May 2023 17:09:34 GMT, Kevin Rushforth wrote:
>> Carl Döbbelin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added export of javafx.base to javafx.web and added platform utils call in
>> urlloader
>
> .idea/jarRepositories.
> Replaced querying of `System.getProperty("os.name")` to check for OS with the
> use of the methods provided by `PlatformUtils`
Carl Döbbelin has updated the pull request incrementally with one additional
commit since the last revision:
Delete jarRepositories.xml
-
Changes:
-
On Thu, 11 May 2023 16:29:14 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/native-glass/mac/GlassViewDelegate.m line
>> 988:
>>
>>> 986: }
>>> 987:
>>> 988: if (image == nil && [pbItemTypes
>>> containsObject:NSPasteboardTypeFileURL])
>>
>> `NSPasteboardType
I propose bumping the minimum version of macOS for which we target
JavaFX. The current minimum version of macOS is:
ARM (aarch64) : 11.0 -- this is the first version that Apple added ARM
support
Intel (x64) : 10.12
Apple hasn't supported 10.12 in several years (it went out of support in
> Replaced querying of `System.getProperty("os.name")` to check for OS with the
> use of the methods provided by `PlatformUtils`
Carl Döbbelin has updated the pull request incrementally with one additional
commit since the last revision:
removed unneeded idea xml and imports, fixed line break
On Thu, 11 May 2023 16:30:58 GMT, Carl Döbbelin wrote:
>> Replaced querying of `System.getProperty("os.name")` to check for OS with
>> the use of the methods provided by `PlatformUtils`
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revi
On Thu, 11 May 2023 16:30:58 GMT, Carl Döbbelin wrote:
>> Replaced querying of `System.getProperty("os.name")` to check for OS with
>> the use of the methods provided by `PlatformUtils`
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revi
On Thu, 11 May 2023 15:48:39 GMT, Martin Fox wrote:
>> Crashes started happening due to macOS DnD API change from macOS 10.14
>> onwards. 10.14 incrodues some [DnD
>> constrains](https://developer.apple.com/documentation/macos-release-notes/appkit-release-notes-for-macos-10_14#Drag-and-Drop)
>>
> Replaced querying of `System.getProperty("os.name")` to check for OS with the
> use of the methods provided by `PlatformUtils`
Carl Döbbelin has updated the pull request incrementally with one additional
commit since the last revision:
added export of javafx.base to javafx.web and added pla
On Thu, 11 May 2023 16:20:10 GMT, Kevin Rushforth wrote:
> > > > I cannot use the PlatformUtils in the
> > > > `com.sun.webkit.network.URLLoader` class, as the PlatformUtils are not
> > > > Exported to the corresponding module.
> > >
> > >
> > > I wonder if this was done on purpose.
> >
> >
On Thu, 11 May 2023 16:11:44 GMT, Carl Döbbelin wrote:
> > > I cannot use the PlatformUtils in the `com.sun.webkit.network.URLLoader`
> > > class, as the PlatformUtils are not Exported to the corresponding module.
> >
> >
> > I wonder if this was done on purpose.
>
> i assumed it was.
In thi
On Thu, 11 May 2023 15:43:30 GMT, Nir Lisker wrote:
> > I cannot use the PlatformUtils in the `com.sun.webkit.network.URLLoader`
> > class, as the PlatformUtils are not Exported to the corresponding module.
>
> I wonder if this was done on purpose.
i assumed it was.
-
PR Comment:
On Wed, 12 Apr 2023 16:50:38 GMT, Lukasz Kostyra wrote:
> Crashes started happening due to macOS DnD API change from macOS 10.14
> onwards. 10.14 incrodues some [DnD
> constrains](https://developer.apple.com/documentation/macos-release-notes/appkit-release-notes-for-macos-10_14#Drag-and-Drop)
>
On Thu, 11 May 2023 14:57:31 GMT, Carl Döbbelin wrote:
> I cannot use the PlatformUtils in the `com.sun.webkit.network.URLLoader`
> class, as the PlatformUtils are not Exported to the corresponding module.
I wonder if this was done on purpose.
-
PR Comment: https://git.openjdk.org
On Wed, 10 May 2023 18:47:16 GMT, Carl Döbbelin wrote:
> Replaced querying of `System.getProperty("os.name")` to check for OS with the
> use of the methods provided by `PlatformUtils`
I cannot use the PlatformUtils in the `com.sun.webkit.network.URLLoader` class,
as the PlatformUtils are not E
> Replaced querying of `System.getProperty("os.name")` to check for OS with the
> use of the methods provided by `PlatformUtils`
Carl Döbbelin has updated the pull request incrementally with two additional
commits since the last revision:
- Merge branch 'JDK-8307807-replace-system-getproperty-
On Thu, 11 May 2023 00:45:42 GMT, Nir Lisker wrote:
> * ... `"os.arch"` could be moved to `PlatformUtil` probably.
Creating additional methods for os.arch would be best done via a separate JBS
enhancement / separate PR.
> * `ClipboardExtImageTest` line 59.
> * `BigGlyphIDTest` line 39.
> * `IN
On Wed, 10 May 2023 17:22:01 GMT, Phil Race wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> Seems fine.
@prrace Can you re-review this when you get a chance?
-
PR Comment: https
On Wed, 10 May 2023 23:32:04 GMT, Andy Goryachev wrote:
>> Adding TextFlow.underlineShape() to add support for a spellchecker-like
>> decoration, using
>>
>> getRange(start, end, TextLayout.TYPE_UNDERLINE);
>>
>>
>> which mirrors an existing method in Text with exactly the same signature.
>
Voting for Andy Goryachev [1] to OpenJFX Reviewer [2] is now closed.
Yes: 5
Veto: 0
Abstain: 0
According to the Bylaws definition of Three-Vote Consensus, this is
sufficient to approve the nomination.
-- Kevin
[1] https://openjdk.org/census#angorya
[2] https://mail.openjdk.org/pipermail/open
On Thu, 11 May 2023 12:00:59 GMT, Karthik P K wrote:
>> The test was failing on the first run and then it was not failing. Cause for
>> the failure looked to be the UI state not getting updated. Hence added call
>> to `Toolkit` `firePulse` method.
>>
>> Able to run the test consistently withou
> The test was failing on the first run and then it was not failing. Cause for
> the failure looked to be the UI state not getting updated. Hence added call
> to `Toolkit` `firePulse` method.
>
> Able to run the test consistently without failure in Linux after the fix.
Karthik P K has updated t
On Tue, 9 May 2023 22:31:53 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove 136 changed files
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/application/ParametersImpl.java
> line
On Tue, 9 May 2023 22:42:19 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove 136 changed files
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line 238:
>
>> 236:
On Wed, 10 May 2023 16:49:56 GMT, Nir Lisker wrote:
> I started reviewing but there are too many files, which makes the GitHub
> interface unresponsive. Can you break it into 4 PRs of ~50 files chunks?
>
> Many of these are not trivial changes - finding the correct type requires
> understandin
> Focused only on raw type problems, and removing casts that were no longer
> needed because of the changes.
John Hendrikx has updated the pull request incrementally with one additional
commit since the last revision:
Remove 136 changed files
-
Changes:
- all: https://git.open
On Thu, 11 May 2023 01:09:53 GMT, Alexander Matveev
wrote:
>> - libFFI updated to 3.4.4.
>> - No additional changes are done to the code.
>> - Tested on Linux, Windows x64 and macOS x64/aarch64.
>> - Windows x86 config files are updated, but no build/testing was done for
>> 32-bit.
>
> Alexande
On Mon, 17 Apr 2023 06:00:19 GMT, Michael Strauß wrote:
>> This PR adds the following methods to the `EventTarget` interface:
>> 1. `addEventHandler`
>> 2. `removeEventHandler`
>> 3. `addEventFilter`
>> 4. `removeEventFilter`
>
> Michael Strauß has updated the pull request incrementally with one
51 matches
Mail list logo
