On Thu, 8 Dec 2022 18:29:48 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> The problem here is, that the `AnchorPane` does not use its snapped insets.
>> Therefore, the fix is to replace all `getInsets().getXXX` calls with their
>> corresponding `snappedXXXInset()` methods.
>>
>> Note: The reason the `AnchorPane` inside a `TitledPane` is blurry in the
>> first place is because a `TitledPane` applies padding to its content.
>> Line 2995 in `modena.css`:
>>
>> .titled-pane > .content > AnchorPane {
>> -fx-padding: 0.8em;
>> }
>>
>> which translates to 9.6px.
>>
>> EDIT: This is btw a good example of the JUnit 5 feature `@ParameterizedTest`
>> with `@ValueSource`
>
> Marius Hanl has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains five commits:
>
> - 8295078: Snap anchors as well
> - Merge branch 'master' of https://github.com/openjdk/jfx into
> 8295078-textfield-blurry
>
> Conflicts:
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/AnchorPaneTest.java
> - 8295078: Replace JUnit4 with Junit5 imports
> - 8295078: Adjusted Copyright year
> - 8295078: TextField blurry when inside an TitledPane -> AnchorPane
modules/javafx.graphics/src/main/java/javafx/scene/layout/AnchorPane.java line
349:
> 347: private double computeChildHeight(Node child, Double topAnchor,
> Double bottomAnchor, double areaHeight, double width) {
> 348: if (topAnchor != null && bottomAnchor != null &&
> child.isResizable()) {
> 349: return areaHeight - snappedTopInset() - snappedBottomInset()
> - topAnchor - bottomAnchor;
same comment about areaHeight - should it be snapSize'd?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/910#discussion_r1191631791
