On Thu, 11 May 2023 16:29:14 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> modules/javafx.graphics/src/main/native-glass/mac/GlassViewDelegate.m line >> 988: >> >>> 986: } >>> 987: >>> 988: if (image == nil && [pbItemTypes >>> containsObject:NSPasteboardTypeFileURL]) >> >> `NSPasteboardTypeFileURL` was introduced in MacOS 10.13 and JavaFX is >> currently targeted at 10.12. The compiler caught this but the warning was >> lost in the sea of other warnings the Mac build generates. > > Good catch (which reminds me that I need to get back to your warnings PR). > This might misbehave on macOS 10.12 then, but I haven't seen a machine that > old in a few years, so it would be difficult to test. > > We really should bump the minimum at some point (to at _least_ 10.14, but > ideally to 11 to match what Apple currently supports, and to match what the > minimum has always been for ARM-based Mac systems), so this seems like the > right time to broach that subject. I just sent a [proposal](https://mail.openjdk.org/pipermail/openjfx-dev/2023-May/040392.html) to openjfx-dev to bump the minimum version of macOS to either 10.14 or 11. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1089#discussion_r1191512491
