Re: [OE-core] [poky][master][PATCH] systemd: fix codesonar warnings

2020-08-07 Thread Richard Purdie
On Fri, 2020-08-07 at 14:45 +, Amitanand N Chikorde wrote: > The patch is having 8 fixes of which only 1 is applicable to upstream > systemd. This implies the issues are in patches that Yocto Project is applying? If that is the case, why aren't we fixing those patches rather than what amount

Re: [OE-core] [poky][master][PATCH] systemd: fix codesonar warnings

2020-08-07 Thread Amitanand N Chikorde
N Chikorde ; openembedded-core@lists.openembedded.org ; raj.k...@gmail.com Cc: Nisha Parrakat ; Anuj Chougule ; Aditya Tayade Subject: Re: [OE-core] [poky][master][PATCH] systemd: fix codesonar warnings On Fri, 2020-08-07 at 14:27 +0530, Amitanand N Chikorde wrote: > Fixed below systemd codes

Re: [OE-core] [poky][master][PATCH] systemd: fix codesonar warnings

2020-08-07 Thread Richard Purdie
On Fri, 2020-08-07 at 14:27 +0530, Amitanand N Chikorde wrote: > Fixed below systemd codesonar warnings. > 1. isprint() and isspace() is invoked here with an argument of signed > type char, but only has defined behavior for int arguments that are > either representable as unsigned char or equal to

[OE-core] [poky][master][PATCH] systemd: fix codesonar warnings

2020-08-07 Thread Amitanand N Chikorde
Fixed below systemd codesonar warnings. 1. isprint() and isspace() is invoked here with an argument of signed type char, but only has defined behavior for int arguments that are either representable as unsigned char or equal to the value of macro EOF(-1). As per codesonar report, in a number of li

Re: [OE-core] [poky][master][PATCH] systemd: Fix codesonar warnings

2020-07-10 Thread Paul Barker
On Fri, 10 Jul 2020 at 12:55, Amitanand N Chikorde wrote: > > From: "Amitanand.Chikorde" > > Fixed below systemd codesonar warnings. > 1. isprint() and isspace() is invoked here with an argument of signed > type char, but only has defined behavior for int arguments that are > either representable

[OE-core] [poky][master][PATCH] systemd: Fix codesonar warnings

2020-07-10 Thread Amitanand N Chikorde
From: "Amitanand.Chikorde" Fixed below systemd codesonar warnings. 1. isprint() and isspace() is invoked here with an argument of signed type char, but only has defined behavior for int arguments that are either representable as unsigned char or equal to the value of macro EOF(-1). As per codeso