On Fri, 2020-08-07 at 14:27 +0530, Amitanand N Chikorde wrote: > Fixed below systemd codesonar warnings. > 1. isprint() and isspace() is invoked here with an argument of signed > type char, but only has defined behavior for int arguments that are > either representable as unsigned char or equal to the value > of macro EOF(-1). > > As per codesonar report, in a number of libc implementations, > isprint() > and isspace() functions implemented using lookup tables (arrays): > passing in a negative value can result in a read underrun. > > To avoid this unexpected behaviour, typecasted char type argument to > unsigned char type. > > 2. "seqnum" defined, not initialized & used in device-private.c > Intialized "seqnum" at definition. > > Signed-off-by: Amitanand <amitanand.chiko...@kpit.com> > --- > files/systemd_codesonar_warnings_fix.patch | 106 > +++++++++++++++++++++++++++++ > 1 file changed, 106 insertions(+) > create mode 100644 files/systemd_codesonar_warnings_fix.patch
This patch simply creates a patch file. It doesn't get applied anywhere and is in a generic files/ directory. Shouldn't this go to upstream systemd? Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141287): https://lists.openembedded.org/g/openembedded-core/message/141287 Mute This Topic: https://lists.openembedded.org/mt/76045467/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
