Hi Richard, The patch is having 8 fixes of which only 1 is applicable to upstream systemd.
The applicable fix is up-streamed to systemd project ( pull request https://github.com/systemd/systemd/pull/16625 ), it is merged into upstream systemd master branch. We need to upstream all of the systemd codesonar fixes. Moved patch file to path "poky/meta/recipes-core/systemd/systemd/" and will be sending the patch file to openembedded-core mailing list. Regards, Amit ________________________________ From: Richard Purdie <richard.pur...@linuxfoundation.org> Sent: Friday, August 7, 2020 2:51 PM To: Amitanand N Chikorde <amitanand.chiko...@kpit.com>; openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>; raj.k...@gmail.com <raj.k...@gmail.com> Cc: Nisha Parrakat <nisha.parra...@kpit.com>; Anuj Chougule <anuj.choug...@kpit.com>; Aditya Tayade <aditya.tay...@kpit.com> Subject: Re: [OE-core] [poky][master][PATCH] systemd: fix codesonar warnings On Fri, 2020-08-07 at 14:27 +0530, Amitanand N Chikorde wrote: > Fixed below systemd codesonar warnings. > 1. isprint() and isspace() is invoked here with an argument of signed > type char, but only has defined behavior for int arguments that are > either representable as unsigned char or equal to the value > of macro EOF(-1). > > As per codesonar report, in a number of libc implementations, > isprint() > and isspace() functions implemented using lookup tables (arrays): > passing in a negative value can result in a read underrun. > > To avoid this unexpected behaviour, typecasted char type argument to > unsigned char type. > > 2. "seqnum" defined, not initialized & used in device-private.c > Intialized "seqnum" at definition. > > Signed-off-by: Amitanand <amitanand.chiko...@kpit.com> > --- > files/systemd_codesonar_warnings_fix.patch | 106 > +++++++++++++++++++++++++++++ > 1 file changed, 106 insertions(+) > create mode 100644 files/systemd_codesonar_warnings_fix.patch This patch simply creates a patch file. It doesn't get applied anywhere and is in a generic files/ directory. Shouldn't this go to upstream systemd? Cheers, Richard This message contains information that may be privileged or confidential and is the property of the KPIT Technologies Ltd. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message. KPIT Technologies Ltd. does not accept any liability for virus infected mails.
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141294): https://lists.openembedded.org/g/openembedded-core/message/141294 Mute This Topic: https://lists.openembedded.org/mt/76045467/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
