Re: [Okular-devel] Review Request 126158: Set objectName for 'm_name'

2015-11-27 Thread Oliver Sander
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126158/ --- (Updated Nov. 27, 2015, 6:50 p.m.) Status -- This change has been ma

Re: [Okular-devel] Review Request 126158: Set objectName for 'm_name'

2015-11-26 Thread Oliver Sander
> On Nov. 24, 2015, 10:52 nachm., Albert Astals Cid wrote: > > > Reason: it expects the dialog to have a KLineEdit member with object name > > > 'name'. > > > > Who does expect that? > > Oliver Sander wrote: > The unit test 'editdrawingtooldialogtest', originally written by Laurent > Mont

Re: [Okular-devel] Review Request 126158: Set objectName for 'm_name'

2015-11-26 Thread Albert Astals Cid
> On nov. 24, 2015, 10:52 p.m., Albert Astals Cid wrote: > > > Reason: it expects the dialog to have a KLineEdit member with object name > > > 'name'. > > > > Who does expect that? > > Oliver Sander wrote: > The unit test 'editdrawingtooldialogtest', originally written by Laurent > Montel

Re: [Okular-devel] Review Request 126158: Set objectName for 'm_name'

2015-11-26 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126158/#review4 --- Ship it! Ship It! - Albert Astals Cid On nov. 24, 2015, 7:

Re: [Okular-devel] Review Request 126158: Set objectName for 'm_name'

2015-11-25 Thread Oliver Sander
> On Nov. 24, 2015, 10:52 nachm., Albert Astals Cid wrote: > > > Reason: it expects the dialog to have a KLineEdit member with object name > > > 'name'. > > > > Who does expect that? > > Oliver Sander wrote: > The unit test 'editdrawingtooldialogtest', originally written by Laurent > Mont

Re: [Okular-devel] Review Request 126158: Set objectName for 'm_name'

2015-11-25 Thread Albert Astals Cid
> On nov. 24, 2015, 10:52 p.m., Albert Astals Cid wrote: > > > Reason: it expects the dialog to have a KLineEdit member with object name > > > 'name'. > > > > Who does expect that? > > Oliver Sander wrote: > The unit test 'editdrawingtooldialogtest', originally written by Laurent > Montel

Re: [Okular-devel] Review Request 126158: Set objectName for 'm_name'

2015-11-24 Thread Oliver Sander
> On Nov. 24, 2015, 10:52 nachm., Albert Astals Cid wrote: > > > Reason: it expects the dialog to have a KLineEdit member with object name > > > 'name'. > > > > Who does expect that? The unit test 'editdrawingtooldialogtest', originally written by Laurent Montel, committed by Tobias König in

Re: [Okular-devel] Review Request 126158: Set objectName for 'm_name'

2015-11-24 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126158/#review88777 --- > Reason: it expects the dialog to have a KLineEdit member wit

[Okular-devel] Review Request 126158: Set objectName for 'm_name'

2015-11-24 Thread Oliver Sander
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126158/ --- Review request for Okular. Repository: okular Description --- The